From: "humin (Q)" <humin29@huawei.com>
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Cc: <oss-drivers@corigine.com>, <niklas.soderlund@corigine.com>,
Long Wu <long.wu@corigine.com>, <matan@mellanox.com>,
<stable@dpdk.org>
Subject: Re: [PATCH] net/bonding: fix destroy dedicated queues flow
Date: Tue, 20 Jun 2023 11:02:05 +0800 [thread overview]
Message-ID: <78d00943-e942-9498-b1d1-ac92a4695919@huawei.com> (raw)
In-Reply-To: <20230608025903.814504-1-chaoyong.he@corigine.com>
Acked-by: Min Hu (Connor) <humin29@huawei.com>
在 2023/6/8 10:59, Chaoyong He 写道:
> From: Long Wu <long.wu@corigine.com>
>
> Bonding port in mode 4 enables dedicated queues, we
> will create a flow for this feature. So we need to
> destroy this flow when we remove the member port.
>
> Furthermore if we don't destroy the flow that created
> for dedicated queues when we remove the member port,
> maybe we couldn't add the member port to a new bonding
> port that needed dedicated queues.
>
> We add the destroy action in removing member port
> function.
>
> Fixes: 49dad9028e2a ("net/bonding: support flow API")
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
> drivers/net/bonding/rte_eth_bond_api.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
> index c0178369b4..85d0528b7c 100644
> --- a/drivers/net/bonding/rte_eth_bond_api.c
> +++ b/drivers/net/bonding/rte_eth_bond_api.c
> @@ -712,6 +712,16 @@ __eth_bond_slave_remove_lock_free(uint16_t bonded_port_id,
> }
> }
>
> + /* Remove the dedicated queues flow */
> + if (internals->mode == BONDING_MODE_8023AD &&
> + internals->mode4.dedicated_queues.enabled == 1 &&
> + internals->mode4.dedicated_queues.flow[slave_port_id] != NULL) {
> + rte_flow_destroy(slave_port_id,
> + internals->mode4.dedicated_queues.flow[slave_port_id],
> + &flow_error);
> + internals->mode4.dedicated_queues.flow[slave_port_id] = NULL;
> + }
> +
> slave_eth_dev = &rte_eth_devices[slave_port_id];
> slave_remove(internals, slave_eth_dev);
> slave_eth_dev->data->dev_flags &= (~RTE_ETH_DEV_BONDED_SLAVE);
next prev parent reply other threads:[~2023-06-20 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 2:59 Chaoyong He
2023-06-20 3:02 ` humin (Q) [this message]
2023-06-20 11:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d00943-e942-9498-b1d1-ac92a4695919@huawei.com \
--to=humin29@huawei.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=matan@mellanox.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).