From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BEFBA0C56; Wed, 8 Sep 2021 15:40:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBBE141140; Wed, 8 Sep 2021 15:40:06 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 77CAD40E25 for ; Wed, 8 Sep 2021 15:40:04 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="207597980" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="207597980" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 06:40:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="524833350" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 08 Sep 2021 06:40:03 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 06:40:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 06:40:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 8 Sep 2021 06:40:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fr5Vx0QV0HaC+p6lV4fxmeb3XqleqnTb+N2D73t+ySGNfmTga5Kpay1QlZ9okIAzWgY6JRCcVtT23SQdZViQ0qEkQ37rD5a6KY1S3IxDtMaaR8VfOOaP8S6KV/XD0hI6liqhv6pUUya04iZc59PUS7CF6aV9bUjhs0rmeeFVnJpE9XOReUflKgC4AWpCEFCHXhnUYeCcEkNJkbKLP9NSSFvRkewlW26MKKOnGmICo7pLuyKR7XDryo5CK1vh42slVo0PMIVnZkQ3N7jh1wAZNF9IOsGE+tf6BXiVDQ8B/UPBjPCn88aon2uKSMVwnbZdfoKBnsXfnqnwhspVKxdiog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8Eo0Cu+ie1nY/kV1KyOj1uqT65kkZmNXSRCa7ATSMdk=; b=TvgjUxCilDt7/ShoMbHrT4JQunhK4RGkk/LaelV7BSEnknmWaYM2c6fWkupJbTwg9c3eH5NURjQa2GnQITYdgtJqZs/1AUSDQm/XmZrgXz25ECQRop/BvoEyj2FjrMOygeMXqv14skq3o885Xb6aqgB4jlV29cip7mS8t8uYzWZVeimXHt/d1YggYNLElbm/RRITKvc4KDVcjlRZI+gwdEpTLUw12x2EuaYKtVbCZrjvlkwVXdCRhHM2FvuiWUgbhcLiAwr+sJZLxLj/lmWHcAVehlo6XEWptFaPL/lTO6gWGRqLoiaJ6TB8944wb/APA1J5ZqOAFJCU7ZF0sDy3vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Eo0Cu+ie1nY/kV1KyOj1uqT65kkZmNXSRCa7ATSMdk=; b=V7WmyTph4qy5w8ReO0DmROZPDdytISHji3c8eiFHlKtAOeqF//yo1QVPJoOyfPjtLB00xLhPJ6wP5BuJkgX4J0Pa0cIYTdPK2PDbg2w/FWYeYTUKAcVhFnHvbLu92nI9HGWd2bWgpt5LdUrmO/+Zi4eFGxyvgACyg/NP8LRxfro= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 13:40:01 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 13:40:01 +0000 To: Chengfeng Ye , CC: References: <20210826190258.108062-1-cyeaa@connect.ust.hk> From: Ferruh Yigit X-User: ferruhy Message-ID: <78d0549e-e699-d5a7-79e6-da6529fd4571@intel.com> Date: Wed, 8 Sep 2021 14:39:55 +0100 In-Reply-To: <20210826190258.108062-1-cyeaa@connect.ust.hk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0167.eurprd04.prod.outlook.com (2603:10a6:10:2b0::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0167.eurprd04.prod.outlook.com (2603:10a6:10:2b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Wed, 8 Sep 2021 13:40:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d435d704-fa07-45e3-5948-08d972ce2825 X-MS-TrafficTypeDiagnostic: PH0PR11MB5013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: isbLvBP5SaF5iGpiOIhF2B14YESImIQLazBGfh2jtCeKMjd6ctCjNh0WIZqFKvzAkM1xoTNAxMMO1j/O1aKK0o0CeloqAIklf0GW2YA/xQf9E9cHpC3bYSl4R44xEgSP0IKui3wQz29lzR9NX4gHSAWbCC1H229JG45651EHDXPxnQ7bPiQRTnmrGpJPu87rRXcCR7j9avq3Pp5srTAULdGs01Z8kxiNyJNvSNXUFcRPJWOqJEzJirKoZo/LmALUKlX/W8MuhYDDG7dvP6aDcAQQb6hyMO9LSUhpR2FcDHIXzKDaegTFRHvrjc9nqFAnBKm41IOXfu8u4xCMxFTXbRIDHj5FNV+n3CMHETYzQ7lzNeHhTGi3brq3w41AahXGdbXmDpp6PdgTt+hKVOg4UBtE0CEU5T4e8FeJvCtefwxSjnfa+2Z9rnL+oV718ITIGBrp15B1rCiPdkw5u4m+Q/C4PFXFw4ZZRTYw++5KkH6Zifyq/jSdxi1Dlf3B+gLbn3871xGE0leuwm+ijysBp5V+LxMF9xqZgzQZuExkMX4+xfcusWosXZeZ3Xdo1Hz8ryz7F91youRNHUJ2HsqhWo5HPAl7hYOddOco4EUbsWe8JE2qPEIzaTrbD1rsy8YDrVZRNZbRxW+WCCXbA7G6o4fKKxR1rYF3pPL+a6Uo2HoWwGMKDmSuQe5JgtFTtQa72wb1PwlUvH7UvW7gp0fi+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(396003)(376002)(53546011)(478600001)(5660300002)(31696002)(36756003)(26005)(8936002)(86362001)(66476007)(66946007)(6486002)(44832011)(66556008)(6666004)(2906002)(186003)(4326008)(2616005)(31686004)(956004)(316002)(16576012)(83380400001)(8676002)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzIzNGZ2d2dSNzhWWWMzaHNaK3FRYW1ORzI1cFBUSHl3MEVyZDkxNE1EWXFj?= =?utf-8?B?VkVtbjRrR1YybW5LUnBlZ2NuYkltZU0ySEltTmRXWnNKRFFidkhEVVNMZnNG?= =?utf-8?B?R0FIbmJoK2hWMGtpS3o2dldkUDlrV3ZoWmQ1MEIwelgxSzFKR0dJMGFHK0o4?= =?utf-8?B?WUdhRVdJWXlpVmJjMGhVcy9MWHhmdkVmTHk5ekNRa294VmV1WHc5YTlsTklX?= =?utf-8?B?Ymd1Wkhkc1d5eEVnYmdVL2h4T2tLWmUrTXFkV1VNMXlzYStUSlYrOTVBRzcy?= =?utf-8?B?aGJodzJ5cjZQWDV4Z2piMVFKYnB3SHNCS2xVUnh1TzQ3cm43eG1Kb29xdWR3?= =?utf-8?B?MzY4Wkx4YlEwcFV4VDJFcjlVTzIxVDVLdEFyeFRWZXdML0hIVU9BVXVKNU01?= =?utf-8?B?S0ZGQnVnZ1JTVmJzTE00a3dJT0I3bU1uTmVQK1ZicUc5UEVHMTFvTldlQ3Z6?= =?utf-8?B?WnhhaTZXWjg1N1ZWSEhlN0JoRFl6d1AyT2pVOHdtb2s4SUR1ajdLVlZBdVZ5?= =?utf-8?B?UDNUcTRnbi9Qbk9KdFJpRGNpdHBReWhQcjdQNURTNUNoYzN6QUlRdjZIQkZW?= =?utf-8?B?NFI1ZU02aEQvb0xHdVVDQzVMTWFOSEpCU1liRlBvcUpHMFpwUytmeFZWYkQz?= =?utf-8?B?bSsydkQvZVFKK3pmK0QrTlU5czRIOW1rMTIwa3NTRkwrdGxha2JTOTlHc3Q2?= =?utf-8?B?NE9KeTAwMkdIZndVSnFxek9xRWJaSS9sYWJuUkU4RlZ0bUNkUlhXd2Q2b3hQ?= =?utf-8?B?eFZaUEVIUEZ5VXlsZFZqOWhSWDZidC81bit1SVVRVG1SMFRDQXArdHNTaDlV?= =?utf-8?B?aE1Jc2grYitHZHAxSGtzTWJsTTI3SjhKZWJPQkRGcTJKQjdXNEw4TmppMGh1?= =?utf-8?B?UDNaZXY5bUV0UHdqcDhxQllvMHJIZlBEbWtKSDBtVzFFTDIzbW9yOERCZS8v?= =?utf-8?B?Y3JIQmZzSE9FSEF3bVhzVlR1NzlBNHhibDMzV3pVeXRoZVhkbTVTekFoS2Rs?= =?utf-8?B?NzBQWVZIaDRtZk5YSjVXR2ltbFJ4K1FqM1ZIaDF5ZGtNT01QaWFxSlVqc1B2?= =?utf-8?B?QXM3VytKMEw4ZFhYdHFpbUYzemFQK2dNK3p3SzUvOGFpRGg4RlV1Z3ZnVUJh?= =?utf-8?B?QXZibVFUa1NTdGZuY2g1NUZGWWJkTEYra0pHOGZQaFpITTdDWnFWaTh0UnVu?= =?utf-8?B?QzBNdHlzY2Q2RndNQ1A5THNkZ3MvRlUrUitjTGZYcStZam15WU90bnRQL1d4?= =?utf-8?B?c3k5NmZYYmdWN1l1OGk2MWg0bmdndUZTTEhsNUFRZ1hXQ0FRemgzeTZmWW5r?= =?utf-8?B?ZVlrQWpEVU4xeDAvbXY1Zm03Y2hIbmlQVTlnRTFmZklkbkdsZlRtZUxvbFR1?= =?utf-8?B?ZkJRK3JYRnFvTmdmUjdvT0NCRTFaaHJSSitTUkZuUUFnN010cE4yV0xsQVFa?= =?utf-8?B?elFyR2tENXRlNEpaVXlGeUM2YURzVHhrcDBpUkhvbmJHVnhGRTMzRCtBbTJz?= =?utf-8?B?ZU0wM0hVallKUGV4NWJHb29lSTc5c08wUU9Fck1uVnJYQmZkMmNpVEZJNHFv?= =?utf-8?B?SUhtUmlsY2hOK3dvVEVZSWtGdk15QzlEeDdOczhaRllNSnpRc0NKNHdlU0U4?= =?utf-8?B?ckRxNnFHREMrZzk5eVJ2YUI5bitpWVRMTVJUeW1HNnJ0bzJCMTJ4d0tzQTc0?= =?utf-8?B?cy9GaDRmOUhBVGY5Q0pzcGFFZ1NtUXE2SUZma3VvRFFhVk90bndKd0g2M25O?= =?utf-8?Q?OuN8WhlRZFWe1Cx9e/CF9eGpGfBDQoRKFLbAav3?= X-MS-Exchange-CrossTenant-Network-Message-Id: d435d704-fa07-45e3-5948-08d972ce2825 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 13:40:01.3654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 45i2ZFJS1977WZu5MrUKXJaM4kFJ9jcAWHU0dht3EGSJnyM+jjvLce1r6gPiP6UCsMmTYa7nJ5f7izT0Qg30Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/26/2021 8:02 PM, Chengfeng Ye wrote: > The lock pdata->phy_mutex may not be correctly released if the > function return in these two branches, which may lead to > deadlock if the lock is acquired again. > > Cc: cyeaa@connect.ust.hk > Bugzilla ID: 776 > > Signed-off-by: Chengfeng Ye > --- > drivers/net/axgbe/axgbe_phy_impl.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c > index 02236ec192..cf39095ee4 100644 > --- a/drivers/net/axgbe/axgbe_phy_impl.c > +++ b/drivers/net/axgbe/axgbe_phy_impl.c > @@ -418,8 +418,10 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) > */ > pthread_mutex_lock(&pdata->phy_mutex); > > - if (phy_data->comm_owned) > + if (phy_data->comm_owned) { > + pthread_mutex_unlock(&pdata->phy_mutex); > return 0; > + } > > /* Clear the mutexes */ > XP_IOWRITE(pdata, XP_I2C_MUTEX, AXGBE_MUTEX_RELEASE); > @@ -444,6 +446,7 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) > XP_IOWRITE(pdata, XP_MDIO_MUTEX, mutex_id); > > phy_data->comm_owned = 1; > + pthread_mutex_unlock(&pdata->phy_mutex); > return 0; > } > > 'axgbe_phy_get_comm_ownership()' seems intended to keep the lock on success. Please also check: Fixes: c8c2296b5974 ("net/axgbe: fix double unlock") Perhaps you can comment the 'axgbe_phy_get_comm_ownership()' function instead?