From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04F5E43866; Mon, 8 Jan 2024 16:42:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CD7C40648; Mon, 8 Jan 2024 16:42:37 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2084.outbound.protection.outlook.com [40.107.94.84]) by mails.dpdk.org (Postfix) with ESMTP id BEE4740261; Mon, 8 Jan 2024 16:42:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9mtOeJUGCTs+IACTeP1zWHcDriwskAwuA5HA6p0kZF5atV1HxEszpCgzyFnMsfoqe9lDqpYfS8BNrcqMyp+hEZB3uxHr4Awqzvw4PecC8o9Ktsf5PmsOamHrV2YZJj/HgbCuvNzpGS+NwCd8j4grXTlGfr7VybnFa6s80Ciliy0LxQp5Ld1NiZ5hNDoGRTuOu5zG1musvjzqcFu1L7rFEYdHKdXc1/GlRaMDtvI1bbt1F5M7tzy9lwU7rwQ3tpSfVXSKswPRZDc1etvccZkesU9z+dgGoYuKrBSlexmGVP7x5+Uv/qKFHktR0B1/o8R+iE4s0HnhThFKh/gc80fMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U3ZTOoWzIOyfLMDMimMHnbcPPvi20JqPMeaufwl0bkQ=; b=KYgJEt1WvD8e0QgMlJ1/dRVZ1oa2bDR0d3JhPmH9d3mio9Nk1+2q6suAdxfVJsMOQ2Eairis0sjZ1NPbpI5wT/Uyw7fh+KTp0dcJ6ExPZD250CJ9+KSGtZznDhPwdXcc/8/z+z13Uuw/CDm5EWYbCdGIEYeHbMjiRQLko/h6wuu9yScYyuMMShQKknMRF3tr9nf0AvleyS/6ooY+T11ms5iN9AtFnKiyJM8m7/0xVN5dLDJk+H8k3vb+k1Iu4JWsNVtTGWJOFEgdsqY8h8E6H3z4FlUxt3xFh/Dd776KLe7H64ylFHIAtBLh3K3CndrmJvRoqEhXrQVEcVAGntTm6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3ZTOoWzIOyfLMDMimMHnbcPPvi20JqPMeaufwl0bkQ=; b=fgUMcpU6liOpML+bBV+gcli+gx7dG+5fXBgTjV7JCVs+QOFs6kB3tkBydY3xrjRYyZVVlhevo/gHxFjbMw1ax+p63Zay99lSRDVP1wdIDmcSySxDAbJwhDCN4oeXehnj9VlvLuABiEmEalyap7bKyx6p8SkTZZIslHkxSjsIenw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB6985.namprd12.prod.outlook.com (2603:10b6:510:1bc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Mon, 8 Jan 2024 15:42:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 15:42:31 +0000 Message-ID: <7905a240-7457-4986-8afe-959d57462d94@amd.com> Date: Mon, 8 Jan 2024 15:42:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] net/nfp: fix free resource problem To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , Long Wu , "stable@dpdk.org" , Nole Zhang References: <20231214102431.2091608-1-chaoyong.he@corigine.com> <20231214102431.2091608-3-chaoyong.he@corigine.com> <0a5a69d7-2d2e-4a0e-9d29-18ec856b5be2@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b8::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: 79a95d07-2a1e-45b5-4b8e-08dc10606cf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4JWYfWaKx1mfmoMhfa2Qq4Sjvo++rPL8VQDC42mErEd2m1d+iQZdFrsVfL/SlyGCCqINIyeSQqP3z3iuBxeQDNShGJtwLXPlI2zYmJYEIFhD37uuXbgZwfkKV/MNb1ToEon/MciLQILuUIgCCiey7EQGQDWtqEnd0L72FVEFwoNSqx9etBw6VfIkcAv+Wcn3LUi1XK5UeCCIbDHjRYZfxaSg84RAP934l5YrzIJk4SwA0SibqVcTKK1k8Jc4JjQdHzL0dgobFv7dJzHn7Eoc121HdGQmPfdrqeyANygqBD8dVOGGmiQ5Q+hZn1kAk36UYWXgNwJ2ZhZP2G+xol9pfV7e/TIgcJIn0d9J8nP66vGoyYzLMRFUfTcVqJk6rNg8YaDgVk/J3hgOdG/gcKLUb8c2GfzI8gilarHxtyGVzeWcvVFNXFvDcFOFY+TiHVNCr6nTnVjp/A8scFEMxjsHLw1P7Ybod/k2tCvYRMg0m0Y8LDiGV8LKcOQYTfAb83o6z/2615hpDv9xI22VLACkCJfRL7ssjrUIYo2L6M2llAfCijqQtP9a0qOWVuGxp645/xPRhHIFLU5QuWFyZeuh5SRECFRHcQ6Y2LrywJEk1QoXclpgIjK0mp+3toi7hrKfLA9pKlkhHAnTtzgm1TNcZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(346002)(39860400002)(366004)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(6486002)(53546011)(26005)(2616005)(478600001)(6512007)(6506007)(6666004)(83380400001)(5660300002)(2906002)(41300700001)(66556008)(66946007)(316002)(54906003)(8936002)(110136005)(44832011)(8676002)(4326008)(66476007)(38100700002)(31696002)(36756003)(86362001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXlwVkp0UzcyYTJSUEgwUmxtUVJya2VPQ00rV3liNjFrVkVhZS8vem95UWRs?= =?utf-8?B?cURrOC9sbjNYNEZlNjcwN0J4dFQ2ejdTOGNMa241dHdYc1liaU9vZ1lyOXFs?= =?utf-8?B?dHptaG52SkJBLzA1VHlUUXROQStOVFhOQkgxalNlK3poZ2NtSk43QzlFZzV5?= =?utf-8?B?OUY2N0gySElCUGdGZm9mUUpncG9aRmxRNW9rMVJybEJWNWtLSGJwbXhOY040?= =?utf-8?B?NlZFMEI5VkxFUk5WTDlxc3RxY0NWWXZvOWRWbzZsSFNBUW5BN2JQa1VoejFs?= =?utf-8?B?SnFTSit5RzlBNXpSQ3paVEJLWUY1R2d6bFBta2ZwVkRRcDhlbGNqSlppMTdt?= =?utf-8?B?emgwUXUzTjFaK2pWM2F1Y2NMeTducE4zS2xxTGhhejRKVW5hUmUwVW5HZjhx?= =?utf-8?B?SmJ6ZlN4ODNvME90UDJkRklsZjgvelFpNnIxMGFFb0J3YUZUcW13OXdSQ2dw?= =?utf-8?B?R3ZxeWJ5c0M4WVZKRkJDZ2Fidng5ckpQWHNLNXFBeDkyNGt6NUxCUmx1dkpu?= =?utf-8?B?Mk1aZXhyN1AwZG5hUEhUK0xUdzhQeWlYenM4N0txeFVTTFhPeUJQd09RUng3?= =?utf-8?B?QktQUm51dWpKMXVFemNlWC9vNHlDY0srdnRMU3dpVHphTXVMZ2xUbW9vMU1X?= =?utf-8?B?MkppV3UybnAzWXB3OHloeEFleDZCMmI3RHh2RE5XZDdDTERXeXROOEw2YUNm?= =?utf-8?B?dGpvOGwzSzFyWmVDVDZ1UTRqcEh5VHVCQjI3bHBPcTRpenFielpXTGpWd3B4?= =?utf-8?B?Q1JWaVJNNUkraExscXJGb2hMSUU0RStpbGg4MVRxYWFjZnM4RWNMVDdlMHow?= =?utf-8?B?QWdJckhRMkRMMWpma0tEOUpGMWlDbmNjNjZLMUN0UjBQa25uWDNPZU56ZFZj?= =?utf-8?B?NktZNmc1NTQ3bjNHL1NYQjgvU3NxcUJIRVJZUHJsSTB4OWhNbnBPY3NBUlRM?= =?utf-8?B?Wmc5M3l3K05uOGt3bUJQUmw0V2htN25ORjE0NGVQSVRHQ09Za2llY1diclBx?= =?utf-8?B?Q3l6c0ZLL2lQK3JJNjhPNWUwV1hBQUNJWW0vK3NLTzNOaVg2MU1kWW04MUIx?= =?utf-8?B?ZmpkcEYwWExCS1p2aUpQZVoveEpubEFZZDR0ZmM4SWxJTE9VTDFhZWZwVUx3?= =?utf-8?B?dFNYemlqYno2NG9JUGlqc1F4aFYxTzYrNytnSFo2OWpUa2VyWERKeXVBajRi?= =?utf-8?B?M0VjR3Zlai9kZGxzbnIrL3h6ZWZENTN1MVcybExrMHR2YWlqcC84elR3bDVV?= =?utf-8?B?U2lKSEFrY2dvcUNwL0djODJlNjZHZWJET0VpVjF0RTVIclh1Y3ZaeWphMEQ1?= =?utf-8?B?QldnZnVubXpBeURNSDVyekdmY3k2WENSa1RnWXhpNzQzU1dSc3ptVGZlNk02?= =?utf-8?B?UmdUcXdOakxmN1ZObE5iMmV3N2ZkOVJ2RW9pQklabml5Y2RIQ3RucnRiMGo1?= =?utf-8?B?VC92RzFwZlUxWmhqTVhBUzQ3cFV4RkZ6SUp4NG84RG9FU2RNQVEzTWo4bjli?= =?utf-8?B?OHpwM0d2MXI3OFVJTlJYVExPbmxPeTE5OFFOdEpPbkVpZkxGWmEvcTNtbFky?= =?utf-8?B?NnZmSWVnNXdLeHRCbkxKRkkrNmR2bStPQXVnaFphbFRITHFJVmdNYWtnbklB?= =?utf-8?B?cnNpL2FMZ09ucGVTUVQ4Rkx3YlBoM3F4U1ppQ0wyY3hBWTV1bG90Qy8vT3Bq?= =?utf-8?B?Nk8zT2c0ait5UTBURzNVMWZaK0FLWEFBa1BGWll0Uk51endvamthN2hlYlFO?= =?utf-8?B?WGlrQlc3TkUwQnZ6MFVnOWVKZXVwL1RTNXRlcGV0Z2xzT0ducW8xS1lNZUJJ?= =?utf-8?B?QndCUnByTStDVmtLSk9xcnIvUWJKZ055WGRFa1BqN3lYZTA3cFRGOEhtMHZh?= =?utf-8?B?azhVbGhTQ3FTU3IzWldhbHdzTkVySElDbFlYN3hySC9VSjhrTnlpekJLaFlO?= =?utf-8?B?d1dzeFhJV2ZubFVieHpEaXZHcFZBcG5yQ1dPVVBLRHhPOHlxa21rbU44bUhm?= =?utf-8?B?UVVVTk1FM3ZpdFVtZ1Rld1BodlQvekg0UENsOXJpNG5DeGpjTUZqcElBRUJK?= =?utf-8?B?Z1ZzWU1lUXFvbnFBRExHQWt2MWZNSjdkMXVnRGU1Nkp3ODd1WDdHMXZVVkh5?= =?utf-8?Q?rwSw=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79a95d07-2a1e-45b5-4b8e-08dc10606cf8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 15:42:31.2726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r46yz17rMidUUeDKg+TioVImdYVEFuaKmaYhacJ1R2bwl8G6vJTy21P5vEYDN/Tl X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6985 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/18/2023 1:50 AM, Chaoyong He wrote: >> On 12/14/2023 10:24 AM, Chaoyong He wrote: >>> From: Long Wu >>> >>> Set the representor array to NULL to avoid that close interface does >>> not free some resource. >>> >>> Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware") >>> Cc: chaoyong.he@corigine.com >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Long Wu >>> Reviewed-by: Chaoyong He >>> Reviewed-by: Peng Zhang >>> --- >>> drivers/net/nfp/flower/nfp_flower_representor.c | 15 ++++++++++++++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c >>> b/drivers/net/nfp/flower/nfp_flower_representor.c >>> index 27ea3891bd..5f7c1fa737 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower_representor.c >>> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c >>> @@ -294,17 +294,30 @@ nfp_flower_repr_tx_burst(void *tx_queue, static >>> int nfp_flower_repr_uninit(struct rte_eth_dev *eth_dev) { >>> + uint16_t index; >>> struct nfp_flower_representor *repr; >>> >>> repr = eth_dev->data->dev_private; >>> rte_ring_free(repr->ring); >>> >>> + if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) { >>> + index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr- >>> port_id); >>> + repr->app_fw_flower->phy_reprs[index] = NULL; >>> + } else { >>> + index = repr->vf_id; >>> + repr->app_fw_flower->vf_reprs[index] = NULL; >>> + } >>> + >>> return 0; >>> } >>> >>> static int >>> -nfp_flower_pf_repr_uninit(__rte_unused struct rte_eth_dev *eth_dev) >>> +nfp_flower_pf_repr_uninit(struct rte_eth_dev *eth_dev) >>> { >>> + struct nfp_flower_representor *repr = eth_dev->data->dev_private; >>> + >>> + repr->app_fw_flower->pf_repr = NULL; >>> >> >> Here it is assigned to NULL but is it freed? If freed, why not set to NULL where >> it is freed? >> >> Same for above phy_reprs & vf_reprs. > > The whole invoke view: > rte_eth_dev_close() > --> nfp_flower_repr_dev_close() > --> nfp_flower_repr_free() > --> nfp_flower_pf_repr_uninit() > --> nfp_flower_repr_uninit() > // In these two functions, we just assigned to NULL but not freed yet. > // It is still refer by the `eth_dev->data->dev_private`. > --> rte_eth_dev_release_port() > --> rte_free(eth_dev->data->dev_private); > // And here it is really freed (by the rte framework). > 'rte_eth_dev_release_port()' frees the device private data, but not all pointers, like 'repr->app_fw_flower->pf_repr', in the struct are freed, it is dev_close() or unint() functions responsibility. Can you please double check if 'eth_dev->data->dev_private->app_fw_flower->pf_repr' freed or not?