From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE649A04B1; Wed, 23 Sep 2020 23:52:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14C091DB48; Wed, 23 Sep 2020 23:52:19 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 56FBE1DB32 for ; Wed, 23 Sep 2020 23:52:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 69A84580229; Wed, 23 Sep 2020 17:52:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 17:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= pypxJ5f3FB6pi7SCmL6p4tjseWjCNh9xGoVZD0mIIfQ=; b=WQ60DA0HYLoNWnk0 WFOi6/xrjDv+l2EFc/a/ZZQUb0UI2t8Z19JHLV5OlZIrCJ2xfZIUvODwnNvvU3Mm StG1eR37rxvYZLRJ8s3KrI4ki7pR01ZqkhFd/Z0Q+xWK8FM/JKYKAA7N8sSXWIJx MeFyGn41MB6yFzQ0fFDVyJ1aj35+8dj9wzjN0zKfWGm2fzKr+csdwspRQDVBBZ8o QOCf9jXpzCiRVcIjL2V4HCMEq2yBVEEDHuH5dvODuiwtI27jZ48kN8DuweH2KTqW nLqXqi6COrb3Xml4zbhlZfGuA1U09zoMFyKvBkbV2QBSWyCXAeG0gJ8lhWTdKgVu hXWdWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=pypxJ5f3FB6pi7SCmL6p4tjseWjCNh9xGoVZD0mII fQ=; b=W+3uMynID/466Ao+WzApLEgU5pGdrPRVF6JDwwDUx2ZlF2eEwp53XCKK0 8tyrLK0h7hjK97TGHwcdUbBjUSrDoDIiYM48MQUJXWYKk/PyzN7VFTsMHsr9Dif0 3uMkdbsWqyl5vW2WWbt1ARzkAUYpkzch+DTRhTtV/gk5Rk9iiq/le5beA+TUas7L 7NLCNq8FK+iX17X1fY0+M/pB/2jccNHd1U39PlgSf2sRy7/xjiJ8rf27s18pOQNr Qa6ruerqc2jRHe2Yfj6XRYt1Uc063Fd9gffxsGAYezbqJN7lr/CUfNaWAajVzu8d Odd2y9KhcFkLpo1LrySiKxu5sguqg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E34D3280059; Wed, 23 Sep 2020 17:52:08 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Ferruh Yigit , dev@dpdk.org, arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang Date: Wed, 23 Sep 2020 23:52:07 +0200 Message-ID: <7906978.WFKINk0of7@thomas> In-Reply-To: <20200923144744.6ebf0065@hermes.lan> References: <20200913220711.3768597-1-thomas@monjalon.net> <3329768.rLCo6hCP44@thomas> <20200923144744.6ebf0065@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/09/2020 23:47, Stephen Hemminger: > On Wed, 23 Sep 2020 23:06:42 +0200 > Thomas Monjalon wrote: > > > 23/09/2020 23:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 22:53:46 +0200 > > > Thomas Monjalon wrote: > > > > 23/09/2020 18:41, Ferruh Yigit: > > > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > > > The device operation .dev_close was returning void. > > > > > > This driver interface is changed to return an int. > > > > > > > > > > > > Note that the API rte_eth_dev_close() is still returning void, > > > > > > although a deprecation notice is pending to change it as well. > > > > > > > > > > Why not update the 'rte_eth_dev_close()' in this patch? After the > > > > > updates below it should be easier. > > > > > > > > Yes it is a step in the right direction. > > > > Changing the API means adding some error checks in every apps. > > > > The reason for not doing is that I did not commit for this task, > > > > and I am not the author of the deprecation notice. > > > > We can discuss how to follow up once this series is merged. > > > > > > Not sure what application can really do if dev_close fails other than call rte_exit()? > > > > At least, it can show a message to the user. > > Agree, but no code checks return from close() system call now. > At least testpmd should be updated; the examples are fine. How do you explicitly silence the static code analyzers? Do you recommend adding (void) in front of the call to close()?