From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 10CB0ADC3 for ; Tue, 24 Feb 2015 02:29:46 +0100 (CET) Received: by wghk14 with SMTP id k14so2304057wgh.3 for ; Mon, 23 Feb 2015 17:29:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=J/+7W4t9/DGF90Hwp5A2sNFWT8c0T6hqmLbSfJnTRp4=; b=d4kF21MW83HdqkbYO7gdICgDCr2iTRcHbQ02aPiTKcVIW2QMYKSHQBGfu9LCaYlLlq 4SGPVKEDNsKnG1/Z9NBxsLgnOsvyhCIVbwWNnOqiV+T4nT54RUixA2zhgNZhNMOZ3iKU uLn4EDz16iL7Jx3wRMBf70KMy0Cde355hvUd81gGhTUE6KjLyo8Bk8Zk6A6vYMt/0drd C1Z9q4xD86hhkYfIYk22O82FW+z34h2h2JjV/zLVkcztP019ftTPWBFg0G+5uGi4sEzN G0LCQIDGPPQbJcP9JCwkTo2n4//ezS+MZzJ2wSKNgsgmNjmGTiU9gDwPHrGctHBhjV19 FVeA== X-Gm-Message-State: ALoCoQlKdxo/br1DH/HGKf6Iik1VWlWp7x++l1nwYFBcVyqTjvzVJRzKJuXddAb5rbpgiBzMHHnm X-Received: by 10.194.75.193 with SMTP id e1mr26956846wjw.126.1424741385790; Mon, 23 Feb 2015 17:29:45 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q10sm57924390wjr.41.2015.02.23.17.29.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 17:29:44 -0800 (PST) From: Thomas Monjalon To: Hemant Agrawal Date: Tue, 24 Feb 2015 02:29:14 +0100 Message-ID: <7915859.T53PE4ELEn@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <2263080.JfiolkiDdp@xps13> References: <14060979121185-git-send-email-Hemant@freescale.com> <1520998.LI3zsdbzN8@xps13> <2263080.JfiolkiDdp@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: optimizing the rte_kni_rx_burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 01:29:46 -0000 > > > 2014-07-23 12:15, Hemant Agrawal: > > > > The current implementation of rte_kni_rx_burst polls the fifo for buffers. > > > > Irrespective of success or failure, it allocates the mbuf and try to put them into the alloc_q > > > > if the buffers are not added to alloc_q, it frees them. > > > > This waste lots of cpu cycles in allocating and freeing the buffers if alloc_q is full. > > > > > > > > The logic has been changed to: > > > > 1. Initially allocand add buffer(burstsize) to alloc_q > > > > 2. Add buffers to alloc_q only when you are pulling out the buffers. > > > > > > > > Signed-off-by: Hemant Agrawal > > From http://dpdk.org/ml/archives/dev/2015-January/011771.html, Jay said > "The patch looks good from a DPDK 1.6r2 viewpoint. We saw the same behavior > in our app and ended up avoiding it higher in the stack (in our code)." > Reviewed-by: Jay Rolette Applied, thanks