From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 903F85A5D for ; Tue, 27 Jan 2015 11:12:06 +0100 (CET) Received: by mail-wg0-f50.google.com with SMTP id b13so13786631wgh.9 for ; Tue, 27 Jan 2015 02:12:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=04ImJZex2uDWjQB6YR4hHSwcoWeR2wc2HwQ5+hOLpCI=; b=cG0SSMlOKp3PXnuWh50eKmxZY/CQR3HHqyfvL/ycxfs6ZShiwgkVC1l5wQCXW0GvTN 4FYqNbo9UJ4X2KMYwyLoL4l2HgoxJ1etv00v/PcYV2cIsWjM1Ht/v4N7KkfqKgM/wzVm 7qpO+rJsZaqiTwqvEUQA4HN+Or49ytx536ITQ2zDSfHQAlWWAzAGTq5LEV9sZm8ixmjm F2Qnupb92YSEBm3vdYLZLqfzbk01rEeDRBSYiYjnpmiBtIbOa6H+zd/SxwvsjIIuOXhz 0qkRF3LXnejwKO0xm0yDGY5dGYcf1Ip6DWps/JJmasrMrvtAdqr7EALlwEMaPG8MzZSk j7NA== X-Gm-Message-State: ALoCoQmNV4xdSDlAbxFTGPhfLiwQIpnJlmTuXiGGT99yXxVMNeGpWFXOKuca5eMWkEr5hStTPrQ9 X-Received: by 10.194.243.165 with SMTP id wz5mr1031758wjc.1.1422353526411; Tue, 27 Jan 2015 02:12:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id tc2sm17448371wic.21.2015.01.27.02.12.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 02:12:05 -0800 (PST) From: Thomas Monjalon To: stephen@networkplumber.org Date: Tue, 27 Jan 2015 11:11:39 +0100 Message-ID: <7916082.1WV7FdSlI3@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 10:12:06 -0000 Hi Stephen, 2015-01-22 22:23, stephen@networkplumber.org: > From: Stephen Hemminger > > The ixgbe driver was including CRC in the transmit packet byte > count, but not for packets received. This was notice when forwarding and > the number of bytes received was greater than the number of bytes transmitted Tx includes CRC and Rx count is greater, really? > for the same number of packets. Make the driver behave like other > virtual devices and not include CRC in byte count. Use the same queue > counters already computed and used for Rx. Please could you describe the difference between gptc/gotc and qptc/qbtc? Thank you -- Thomas