From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C144558A; Fri, 5 Jul 2024 00:44:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1FE742FED; Fri, 5 Jul 2024 00:44:02 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by mails.dpdk.org (Postfix) with ESMTP id 181A442F95 for ; Fri, 5 Jul 2024 00:44:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZtgwGy49DXJ0DmEGhhgOyGqElLKCraqCu/BG3eWjZK4bHeNB/MvBrj2p6u5uSxFD1EfUOnotUzMewKRVVz55kg0c9APBsqoSqiQuLFWWe5Nah0ZDXZwKxTSiE9YPH/wX0Cx2gb2JYC0vnjUEmEHEk/S3RuALZSiQFy7dv77tixG++W+NDWlJADhoc49q9DhK5d7xiMj+5SofYN+JOnd7AI0ItQSzruG+AjDv3fs76nVBoeSdZLYBRxBa7fHAHuJSejHV8/D702Lyrjw4bUBbnzvTEr0mqpjGr8dCad1T54KyJW7BFaLeBwUbM1nD/CgOmzdwwV3+iB9kFrLLDwvJ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5C9Hp2Vqog+77QlSuM5QrHoEDSTEnhTGq/wjkQr4nGw=; b=A88zgIqLvn8wt3aguIXAx5bfFPF1xcqtAsm+itiemVe4Kh+/fOKcbAi7h2tSBeCfngtLHPrd2YQic3Mk9snXxHUr7wzSALh8j8XMf6uTtCmSuWHWw3Ll46bZ+QdUIfwL/XrrP/Bwc3u0qcFXJakaXBeQyEElEs/M2GzlnKZQj4mhGq+f0BkzoJf65K3FuRWNQJd8wuWry7YLgnhoRkZAoy/RBGYD91oEoD/LaeBheH7TGi2tbitgamHVHEJSaaJFjTYF/zc5d1S6N25oHA0xAE3Vx38b/yoR+Xow4qulhaAG7MaISoTUN61cYwyayiCH9TmET6DUk6xCc27CrTcYwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5C9Hp2Vqog+77QlSuM5QrHoEDSTEnhTGq/wjkQr4nGw=; b=VfUn0CtqzFQmL3R2DP+4OAyRSZPwoThlXa6nBBIlBGkjAJLOuv0UFH9mwgAZr7IqIKdUoTLpYpIJW50DQjQrMTjOIsL+6gNEWn7vwxsSNJ+TNYe7BxdmMPeATA2Lm62GPrakRFVWufZAG3zkIcD+VT2dymYerMhcPrs+mkbVch4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB9101.namprd12.prod.outlook.com (2603:10b6:510:2f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.33; Thu, 4 Jul 2024 22:43:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 22:43:58 +0000 Message-ID: <79201982-dda5-4380-a503-0081915a7287@amd.com> Date: Thu, 4 Jul 2024 23:43:53 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/23] net/ntnic: add logging implementation To: Serhii Iliushyk , dev@dpdk.org Cc: mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240627073918.2039719-1-sil-plv@napatech.com> <20240627073918.2039719-2-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240627073918.2039719-2-sil-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:10:553::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 9402725c-87b9-41c7-e887-08dc9c7acadc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZnloWlZIOC9nY042dHhsSmNyZ3ZpR3VHYkkrUlFYdXBHUHZDRldKNDluNlBK?= =?utf-8?B?cDdMa1cvbmsyWGNlNG1xVU1aNUt6L1lwcVNHQ0pldThDRWVvdnljWFQ2V095?= =?utf-8?B?Y3A0elk1aDRSVEgzOEhHcVZxSnlXbUxNaHNNTHhqMzBPbjlTV2FMck1MdVJK?= =?utf-8?B?cHRIc2pHUzZKd1psOHNwSEhjVmd4ZC9ySTQxY1hncXFnNnZxQUdmNFVpNUpT?= =?utf-8?B?VWJxMnJaczkwVXljWTBEME9OOERhLzF5b3JwclpNcHQzTElPdXhkNWQyWVNa?= =?utf-8?B?cllSSlV1N2NmZVVWL0VzNHhtRUJOeDBNVFplNStLS29EbHoxVEtkbjhQMFFY?= =?utf-8?B?aWNMcnQ3a0drNUk2bzZZOUREUnBWZURoM2tZVDN2MXBmWGFHc2Y3TmZFT1hG?= =?utf-8?B?KzRkUnhSY3hvM1I0RXMwRHovL3BHZ3djMzhXWTU1RzlKckhHUVp0SDJrMzRE?= =?utf-8?B?VHQ0dTUrdVJyL052bG96SXZDL0JvSGdUZTEzVWdLcVZhNnYwallITmYyVS9T?= =?utf-8?B?Nm9hMTltMXN2UFcram5TWmdNT2dCM1NFTW5IZHJSdjRRUU1qSWJuTjA4TTYw?= =?utf-8?B?TkNQaUdVRVlQOVpjd0pVNnJ6Q2xiMHRqR1BvMUdva2xibTZ4WkpPS0VIVXdF?= =?utf-8?B?Zjh5WVBlL1BtZUJGcjMvVENPQk12Qi9NRTJpb2hIamtKSyt5MW44cnhXUmpa?= =?utf-8?B?S09JR2RjckM0N3hHNHZPOSt1bzVtQURDeWNlSlhTRXhNOG9oWUZ0bWIwbEZz?= =?utf-8?B?MmlXdFNwR0t2SWFSc2VoM0pwbERsNG5uamFzNjMrYzBQTHdSQVFmWnpNeXhl?= =?utf-8?B?QmN5dlN1UTZIYzRQeWlBMHNyRkZFaXpyTW5VNGx4K0tGVGpwQjFWUUxNVUNK?= =?utf-8?B?dkR4VjNpNzAxbHM4c3NmV3c4MDZ0SHFuZjBjd0NVWS8rTU00dEN0Q0dtdG9w?= =?utf-8?B?VjNZa2ZiVklKQmxVRGw3eFhuMlF4NDNjbGVpbGZKcUl4Tk1mRWlGMDFSY1ln?= =?utf-8?B?bFAyaDc2OVFiSTY3WWo3MlhkY29DZEw5TmlwRlpzb2tXZDFBcDNvZ0UvM0Fx?= =?utf-8?B?eUROa2hRaDNSeFh0NVBKWllMMVlxOG5XRlBqRm1lZUZ5TkR1M1FuOHozNkZs?= =?utf-8?B?cU1abzNKbWRKUFRpdXhOcSs0ODdLNzJrbXZIbmRxMFkyejFvMmJOT09sQ3ly?= =?utf-8?B?OEhocUJRNVJ2dnFud21sT3lHOFFDeUxNZnBBWmFNOEhiTUNhUEU5SThNMGNm?= =?utf-8?B?NlIxa1FLWnUvb0MzUXZIYk54cDc5QzlrampLY0hGcjAzV2JleDdsMDIrNDJR?= =?utf-8?B?UHgrT1A2cnRvSTE5ajRxWkxEQ0U0QnNTVTNWRkVTZVdBWmZOUG5HU2c4RWFQ?= =?utf-8?B?b0ZrZnZnQXZIRXRDUG5SbWlqWEdTaVBWdVVkazVNTjNGN2Z4SjJ2R1dWWTJt?= =?utf-8?B?RHVCRlZ6M3BFTko0UUdKOUFxQ1VVTkY5NkUrRjd1cjdGUVFuY3QxRmthWVdj?= =?utf-8?B?U2licGZrMjBiSXk3R2gzQWgwL2trNG1NVzh0WVIyQ284Q1VtUG92cjM4aEJ0?= =?utf-8?B?RU9aN2h2d2x6L3V1TDM5VEhjV3A3aTdLSTNnZmNZS0s2MGtWdHNSaFl4dm1i?= =?utf-8?B?NEszdnpwV0RyRHZHcWJEWUdHeGlFcGhZSEpiRUpvaXZjbkRveHBtUFRzZDFn?= =?utf-8?B?WEJGcElzZDZhNFhhckxTWTluODFLMUw2U3dOYTdpdE9ycE5lT3dBdnpLM0t6?= =?utf-8?B?MHBMc25XTStFWFhPQUwvR29hQlVEN3poMm5lNEJxVzFoSTZsd0FnaHpVQ1hB?= =?utf-8?B?eHFYL1U5UllHWDMzY3N6dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmlsSzU1MWFaR2sydnRyNGVtUXNBRnIyQmtQenlGZlZ2S3lNaVYyUTJoYXRq?= =?utf-8?B?aXllQjFnc2tSb00rVEs4bUJ6RFhPbnk4RDVUZWZUZjltZHVBM25HTUJmdSt3?= =?utf-8?B?YUk1VXR6MUFpYVRCS2xWWms4Ui9ydm13c2NHR1NKanplM2lBM0J3RmNVQW1W?= =?utf-8?B?U25STzl0RW9nVUpYdG5Fb1h6dTNweU9FYXlPSlBTeVB2Z0c4OWZjY3AvUkRG?= =?utf-8?B?b0EwNFVBTWl0ZzR0cVlNVmRuMmxHTVBWNkRZdEQzY2pNRnBna1VtU0FoWmoy?= =?utf-8?B?YUg3L3JWbFQ2QW5CUzdPL2pBL3RFUlhBMUppWDFnSUwwcHFYNW54OXNRR3JP?= =?utf-8?B?TUxURWF4b09iaE9hYytrWjF4ZDJnYmYxOUovTzNTKzFmV1g1WW0rWlp0V0ht?= =?utf-8?B?VDg4aUR2U1pMZ3FnSjJ2SjBDaEV2S2ROT0IvL1EzMUFUWFUvMjNsSmV6WnBu?= =?utf-8?B?ejB1dWFXZ05HeHZ3R2F2aVVVOW04VUZRUzQ2K1JoT1VFTkM4MWlnaGJiaFc2?= =?utf-8?B?bUJCS2FkQzBQTDc2cWZKM2FyWElKTTR2blliK1ZqRlhWSUxNbi9uZHVqdXRM?= =?utf-8?B?S2pYSEdLbGxFQ2U0UkJEd2JpOXh1Sko0K2ZDRGhvU2I1OTFwVERla0ZmT1R4?= =?utf-8?B?RkkvbU91bWMwNlI0VVFwaHZ2cmRNWlpRd1RrZTRpajREc2xuNk40eHJ5cmpM?= =?utf-8?B?dEtnK0RzMGNuK2FxNytVWTVBeUpSamlKMzdVZWdSTUlhU1Vpa285M0tlZ1NL?= =?utf-8?B?WVNpazR6T29YU1RtR1RMWlpJSUQ2NllKaG1wc0lVcUlKOTB2VW1QYmtOdFBi?= =?utf-8?B?M2NKT1E1MExuaDFrVnI3Rjh3VnRDMjEyV096UGhpWDN4M3ZUa2JJNE10QjZy?= =?utf-8?B?M0VMWVJuSzlhZ2pQY2NjcnFmaW9NN1VseEZkTHd1a0lJWTRvcGx1U0lzM2hM?= =?utf-8?B?VTR6bUpqWHdpbVl1LzRqblprMmlhbW9IYnVxSVpJODJ4aUNsbjljNmNLeUF1?= =?utf-8?B?bmMzU1ByT2JOcHVGUU1iNGMwTlV1a2FqbGdJMnFBTjd5T1RINm1jY3hwSGNV?= =?utf-8?B?VVo4ZXlYUENPS3l5aW9EajF0UkN2QjhOeUp5MXJCNU93SmZwTXFiL01UZkdK?= =?utf-8?B?dnhiOS9EeFBuMWY2OGE0blFSQUNURW9LbFRBMTRQMzFVTDJTN0ZyeUtZVFBD?= =?utf-8?B?OUQvK1BmQ2FQK3JEUUFjd1kxN1VCdllETFRuTlJtNmVJQ0Jxd1h2L2JuTkFr?= =?utf-8?B?WUMwcE05d0dUdEFpOEcrTjNXL3lERFZDYmFqaVo4Q2VzeEpERHFDZTEwQzJu?= =?utf-8?B?cDJqbytYVlpsU3FiazRoRHlLR3Bla2VnbEdpcHd2TDJIckc4dGh1NjlWTzhw?= =?utf-8?B?My9vQzVkMG1nUENVWDdtQktmUFQrMUVYRWRaYldDMjhUSEFvUnMyQWlVdUJK?= =?utf-8?B?RzFtN0NEd0Y3MDZGOUhybEZ1dDNLd0ZqVnI4VFNZSEZxL0dvN3QzYnBLVitP?= =?utf-8?B?UWk3UktoL01pZzZnTkpPR2JqNzBpSXdhajBGUHZyM08wZFFuVkVKV1RDeFlm?= =?utf-8?B?WHFhQmJxTGJmY1laZ3U3SzUxRVJPUmc4UmRRQko4T1ZDMTZqbVpSRytacCt4?= =?utf-8?B?c1A3a1hwbkllQ2tINTNvRkZlNkNQaC85TVJ2UkhLNVIzWmF0MUUyK1V5WjV2?= =?utf-8?B?TEMyb1UrVzJvRXduVXBSRXlLcE5HN0xQYlNEemtJa0VtbzZRWC9iL3B6eTBY?= =?utf-8?B?RzFqZXgrZWVqNXNodmVYRTJISWZqMXpqS3ZrdFJOMkdqNkViNnpHbmFVcFR3?= =?utf-8?B?S24yWjVPQ1NmcXZINVM5ZEZNRFF3Ry8vckJtdlZZYnpqWm55bDNBeWNtUm0z?= =?utf-8?B?c0QrRDRhZm42cUY5VEhId1NCYU1aajlvcDhwdVhTR3FzRnJNbXFMb2tSNThs?= =?utf-8?B?eitpZnlPazZBd3oxYWhaQlJ2QjNKVUlNeWhCMXRKSlE5TDBpMWdacVNDamxx?= =?utf-8?B?bHdXN0xyVDJ5dUxKRzFGYkJsUTJrREtNWXNFQitHamQ3OVhyK3Z2eURpcEJ2?= =?utf-8?B?ak9LK01KN1hoQ3hzejlrVDBhbldCeGpscVJ2WE9FT2JFTVlpOU5TQWNPaWR0?= =?utf-8?Q?waX72vcbDFn3NuT8vaf4+QmLa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9402725c-87b9-41c7-e887-08dc9c7acadc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 22:43:58.4612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AhkeOiEt8Spp2q2JcMNpv7GWU6Lkoukg8TPax1fe+7EWWv/i77iGzsHRBCwE+8pv X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add ntnic specific implementation for logging > > Signed-off-by: Serhii Iliushyk > --- > drivers/net/ntnic/meson.build | 2 + > drivers/net/ntnic/ntlog/include/ntlog.h | 49 +++++++++++++++++++++++ > drivers/net/ntnic/ntlog/ntlog.c | 53 +++++++++++++++++++++++++ > drivers/net/ntnic/ntnic_ethdev.c | 2 + > 4 files changed, 106 insertions(+) > create mode 100644 drivers/net/ntnic/ntlog/include/ntlog.h > create mode 100644 drivers/net/ntnic/ntlog/ntlog.c > > diff --git a/drivers/net/ntnic/meson.build b/drivers/net/ntnic/meson.build > index 227949eacb..b1ba8a860f 100644 > --- a/drivers/net/ntnic/meson.build > +++ b/drivers/net/ntnic/meson.build > @@ -15,10 +15,12 @@ cflags += [ > # includes > includes = [ > include_directories('.'), > + include_directories('ntlog/include'), > Why have 'include' folder under 'ntlog', but not put log related headers directly under 'ntlog' folder? > ] > > # all sources > sources = files( > + 'ntlog/ntlog.c', > 'ntnic_ethdev.c', > ) > # END > diff --git a/drivers/net/ntnic/ntlog/include/ntlog.h b/drivers/net/ntnic/ntlog/include/ntlog.h > new file mode 100644 > index 0000000000..58dcce0580 > --- /dev/null > +++ b/drivers/net/ntnic/ntlog/include/ntlog.h > @@ -0,0 +1,49 @@ > +/* > + * SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2023 Napatech A/S > + */ > + > +#ifndef NTOSS_SYSTEM_NTLOG_H > +#define NTOSS_SYSTEM_NTLOG_H > + > +#include > +#include > +#include > + > +extern int nt_logtype; > + > +#define NT_DRIVER_NAME "ntnic" > + > +#define NT_PMD_DRV_LOG(level, ...) \ > + rte_log(RTE_LOG_ ## level, nt_logtype, \ > + RTE_FMT(NT_DRIVER_NAME ": " \ > + RTE_FMT_HEAD(__VA_ARGS__, ""), \ > + RTE_FMT_TAIL(__VA_ARGS__, ""))) > + > + > +#define NT_LOG_ERR(...) NT_PMD_DRV_LOG(ERR, __VA_ARGS__) > +#define NT_LOG_WRN(...) NT_PMD_DRV_LOG(WARNING, __VA_ARGS__) > +#define NT_LOG_INF(...) NT_PMD_DRV_LOG(INFO, __VA_ARGS__) > +#define NT_LOG_DBG(...) NT_PMD_DRV_LOG(DEBUG, __VA_ARGS__) > + > +#define NT_LOG(level, module, ...) \ > + NT_LOG_##level(#module ": " #level ":" __VA_ARGS__) > + > +#define NT_LOG_DBGX(level, module, ...) \ > + rte_log(RTE_LOG_ ##level, nt_logtype, \ > + RTE_FMT(NT_DRIVER_NAME #module ": [%s:%u]" \ > + RTE_FMT_HEAD(__VA_ARGS__, ""), __func__, __LINE__, \ > + RTE_FMT_TAIL(__VA_ARGS__, ""))) > +/* > + * nt log helper functions > + * to create a string for NT_LOG usage to output a one-liner log > + * to use when one single function call to NT_LOG is not optimal - that is > + * you do not know the number of parameters at programming time or it is variable > + */ > +char *ntlog_helper_str_alloc(const char *sinit); > + > +void ntlog_helper_str_add(char *s, const char *format, ...); > + > +void ntlog_helper_str_free(char *s); > + > +#endif /* NTOSS_SYSTEM_NTLOG_H */ > diff --git a/drivers/net/ntnic/ntlog/ntlog.c b/drivers/net/ntnic/ntlog/ntlog.c > new file mode 100644 > index 0000000000..2732a9e857 > --- /dev/null > +++ b/drivers/net/ntnic/ntlog/ntlog.c > @@ -0,0 +1,53 @@ > +/* > + * SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2023 Napatech A/S > + */ > + > +#include "ntlog.h" > + > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#define NTLOG_HELPER_STR_SIZE_MAX (1024) > + > +RTE_LOG_REGISTER_DEFAULT(nt_logtype, INFO) > + > Mostly default log type is 'NOTICE' to reduce the noise. Unless there is justification, can you please set default log to notice for consistency. > +char *ntlog_helper_str_alloc(const char *sinit) > +{ > + char *s = malloc(NTLOG_HELPER_STR_SIZE_MAX); > + > + if (!s) > + return NULL; > + > + if (sinit) > + snprintf(s, NTLOG_HELPER_STR_SIZE_MAX, "%s", sinit); > + > Should it put a space after 'sinit'? One sample of usage is like: ntlog_helper_str_alloc("Register::read"); ntlog_helper_str_add(tmp_string, "(Dev: %s, .... Won't this cause an output like: "Register::read(Dev: ..." Is this what intended, or is "Register::read (Dev: ..." intended? <...>