DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows
@ 2017-05-12  7:13 Beilei Xing
  2017-05-12  7:50 ` Adrien Mazarguil
  0 siblings, 1 reply; 3+ messages in thread
From: Beilei Xing @ 2017-05-12  7:13 UTC (permalink / raw)
  To: adrien.mazarguil; +Cc: dev, stable

Application fails to create NVGRE and E_Tag flows with
current configuration, this commit fixes the issue by
adding flow items for E_TAG and NVGRE.

Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/config.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 4d873cd..83a8f52 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -968,6 +968,8 @@ static const struct {
 	MK_FLOW_ITEM(TCP, sizeof(struct rte_flow_item_tcp)),
 	MK_FLOW_ITEM(SCTP, sizeof(struct rte_flow_item_sctp)),
 	MK_FLOW_ITEM(VXLAN, sizeof(struct rte_flow_item_vxlan)),
+	MK_FLOW_ITEM(E_TAG, sizeof(struct rte_flow_item_e_tag)),
+	MK_FLOW_ITEM(NVGRE, sizeof(struct rte_flow_item_nvgre)),
 	MK_FLOW_ITEM(MPLS, sizeof(struct rte_flow_item_mpls)),
 	MK_FLOW_ITEM(GRE, sizeof(struct rte_flow_item_gre)),
 };
-- 
2.5.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows
  2017-05-12  7:13 [dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows Beilei Xing
@ 2017-05-12  7:50 ` Adrien Mazarguil
  2017-06-08 21:03   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-05-12  7:50 UTC (permalink / raw)
  To: Beilei Xing; +Cc: dev, stable

On Fri, May 12, 2017 at 03:13:09PM +0800, Beilei Xing wrote:
> Application fails to create NVGRE and E_Tag flows with
> current configuration, this commit fixes the issue by
> adding flow items for E_TAG and NVGRE.
> 
> Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Missed that obvious issue as I could only validate the command-line parsing
side of things for these items. Thanks.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows
  2017-05-12  7:50 ` Adrien Mazarguil
@ 2017-06-08 21:03   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-06-08 21:03 UTC (permalink / raw)
  To: Beilei Xing; +Cc: stable, Adrien Mazarguil, dev

12/05/2017 09:50, Adrien Mazarguil:
> On Fri, May 12, 2017 at 03:13:09PM +0800, Beilei Xing wrote:
> > Application fails to create NVGRE and E_Tag flows with
> > current configuration, this commit fixes the issue by
> > adding flow items for E_TAG and NVGRE.
> > 
> > Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> 
> Missed that obvious issue as I could only validate the command-line parsing
> side of things for these items. Thanks.
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-08 21:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12  7:13 [dpdk-dev] [PATCH] app/testpmd: fix failure of creating E-Tag and NVGRE flows Beilei Xing
2017-05-12  7:50 ` Adrien Mazarguil
2017-06-08 21:03   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).