From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D04C4A0A0C; Thu, 1 Jul 2021 16:26:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8504340141; Thu, 1 Jul 2021 16:26:28 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E12BA4003E for ; Thu, 1 Jul 2021 16:26:26 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7FE8E7F510; Thu, 1 Jul 2021 17:26:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7FE8E7F510 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625149586; bh=nC1uw7bklWsBso52PE4GDqmM0quVbb/WF3jizsZVknw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=vmr5EPJ7dE+B+ps5KgG6CG9k9sy8IiyYryCRvRPZb7FL2FU1t6XnHqKLpvvrPy09k 0sPP52GEh/FCGwdMG1V7/dTt+hkJvpqcyXT8AdoyBcfo1strs0HwW3Nv9cIaXkCRqz xPFjitp9K5UmxvfXFt+iOkg2v00RYogCuEBd9rq4= To: Alvin Zhang , qi.z.zhang@intel.com, ajit.khaparde@broadcom.com Cc: dev@dpdk.org References: <20210603080352.10924-1-alvinx.zhang@intel.com> <20210615081956.23656-1-alvinx.zhang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7930ac91-7f55-6b42-f086-701d952fc151@oktetlabs.ru> Date: Thu, 1 Jul 2021 17:26:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210615081956.23656-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/15/21 11:19 AM, Alvin Zhang wrote: > This patch defines new RSS offload types for IPv4 and L4 checksum, > which are required when users want to distribute packets based on the > IPv4 or L4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > actions rss types ipv4-chksum end queues end / end", this flow > causes all matching packets to be distributed to queues on > basis of IPv4 checksum. > > Signed-off-by: Alvin Zhang > Reviewed-by: Andrew Rybchenko > Acked-by: Ajit Khaparde > --- > > v3: Add L4 checksum RSS offload type > --- > app/test-pmd/cmdline.c | 4 ++++ > app/test-pmd/config.c | 2 ++ > lib/ethdev/rte_ethdev.h | 2 ++ > 3 files changed, 8 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 0268b18..6148d84 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2254,6 +2254,10 @@ struct cmd_config_rss { > rss_conf.rss_hf = ETH_RSS_ECPRI; > else if (!strcmp(res->value, "mpls")) > rss_conf.rss_hf = ETH_RSS_MPLS; > + else if (!strcmp(res->value, "ipv4-chksum")) > + rss_conf.rss_hf = ETH_RSS_IPV4_CHKSUM; > + else if (!strcmp(res->value, "l4-chksum")) > + rss_conf.rss_hf = ETH_RSS_L4_CHKSUM; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf = 0; > else if (!strcmp(res->value, "level-default")) { > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 43c79b5..14968bf 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -140,6 +140,8 @@ > { "gtpu", ETH_RSS_GTPU }, > { "ecpri", ETH_RSS_ECPRI }, > { "mpls", ETH_RSS_MPLS }, > + { "ipv4-chksum", ETH_RSS_IPV4_CHKSUM }, > + { "l4-chksum", ETH_RSS_L4_CHKSUM }, > { NULL, 0 }, > }; > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index faf3bd9..1268729 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -537,6 +537,8 @@ struct rte_eth_rss_conf { > #define ETH_RSS_PPPOE (1ULL << 31) > #define ETH_RSS_ECPRI (1ULL << 32) > #define ETH_RSS_MPLS (1ULL << 33) > +#define ETH_RSS_IPV4_CHKSUM (1ULL << 34) > +#define ETH_RSS_L4_CHKSUM (1ULL << 35) What does efine which L4 protocols are supported? How user will know?