From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3991FA0547; Mon, 8 Feb 2021 11:56:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F83B40693; Mon, 8 Feb 2021 11:56:30 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id BCD3840147 for ; Mon, 8 Feb 2021 11:56:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 24664580230; Mon, 8 Feb 2021 05:56:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 08 Feb 2021 05:56:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= eqtyhJKV5YXv0HHfxNX+Y/vUVzAaITFXithBUaweJ6A=; b=WiDP2f1XymtwygQW nMW6J1OA24+f0KP+NO7n4iDWoAwNJ9NhwRUlXKZGUFp8HzzCryqXfIXdu32WRZwg Sa9nr105r3yr2URIcsGYXy8TMOrwL2w62lHMzlNKZYfAHWuRXgZG1iQhcX6TfMOD tKPzBHo1tC//3b6/jYEErl5l62ygQcb40/knEa7nzYUwDDIKF/cuBlv5kckV1xe0 DEez5zgMXUkvQPrE2GWDfqK40OtNhXwVOvj1sYKfpGcvjuP5uFe4fNEiIzjyH0WW w6TjBNWfhTgHKhbUo9M+tLZzG/KDYGcIwA6KbtlxuRtQvvPxuKeCwWlyhPIxrJjW 0LjLJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eqtyhJKV5YXv0HHfxNX+Y/vUVzAaITFXithBUaweJ 6A=; b=oRZ8YHQCICa0qP886UUF1cyd7cdb6TUutSkoxJDOSRBmggqTotYSp7d3R 0bbQsqU8LXT1CS+CJDWdGgFHO1gr31Ath7ULBc36DJ8eJI237YsUdFpkTbdBVAUW 9ZDcxnIoXWz48GTwteOs6nlGkNuzM23VlI8LMpBbApWK8N43lqQZg8cVovNMjtrk DQCPx1A4q0bCp+YJjaiu+8cWJ9/DIt5TuHi8hH48vdBdnBQQiLW3/U1te4W+DFua 1S1H7eIja9Xmi914sI+onYs9OMWvFes7KgTrVFArLT8kpYl1VDxjt/A2onPSStMA ErgSmk7CwfDZ+X2IDNBiperGSywAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheefgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C5CE1080057; Mon, 8 Feb 2021 05:56:23 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Juraj =?utf-8?B?TGlua2XFoQ==?= , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" , "david.marchand@redhat.com" , "bluca@debian.org" Date: Mon, 08 Feb 2021 11:56:21 +0100 Message-ID: <7945884.dXLI3N8YQt@thomas> In-Reply-To: <20210208102628.GA2020@bricha3-MOBL.ger.corp.intel.com> References: <1612536397-18008-1-git-send-email-juraj.linkes@pantheon.tech> <121a529885424ec28c24e51f3e8979ff@pantheon.tech> <20210208102628.GA2020@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH v4] build: kni cross-compilation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/02/2021 11:26, Bruce Richardson: > On Mon, Feb 08, 2021 at 10:17:56AM +0000, Juraj Linke=C5=A1 wrote: > > From: Bruce Richardson > > > On Fri, Feb 05, 2021 at 04:04:32PM +0100, Juraj Linke=C5=A1 wrote: > > > > The kni linux module is using a custom target for building, which > > > > doesn't take into account any cross compilation arguments. The > > > > arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and = CC, > > > > LD (for clang). Get those from the cross file and pass them to the > > > > custom target. > > > > > > > > The user supplied path may not contain the 'build' directory, such = as > > > > when using cross-compiled headers, so only append that in the defau= lt > > > > case (when no path is supplied in native builds) and use the > > > > unmodified path from the user otherwise. Also modify the install pa= th > > > > accordingly. > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > --- > > >=20 > > > Thanks, this all looks ok to me now, bar one very minor nit below. Do= ing a native > > > build on my system with the running kernel also works fine. > > >=20 > > > However, the bigger question is one of compatibility for this change.= The current > > > documentation for the kernel_dir option is: > > > option('kernel_dir', type: 'string', value: '', > > > description: 'Path to the kernel for building kernel modules. \ > > > Headers must be in $kernel_dir/build. Modules will be installed \ > > > in $DEST_DIR/$kernel_dir/extra/dpdk.') > > >=20 > > > Obviously the description now needs an update to reflect the new use > >=20 > > I'll change the description. The current patch version is always instal= ling the modules into '/lib/modules/' + kernel_version + '/extra/dpdk', tho= ugh. I don't think we want to change the behavior this way, so I'll make th= e changes to preserve to original behavior ('/lib/modules/' + kernel_versio= n + '/extra/dpdk' when kernel_dir is not supplied, kernel_dir + '/extra/dpd= k' when it is). > >=20 >=20 > In the absense of an explicit kernel_install_dir, I actually think the new > way is better. However, I'd be interested in other opinions on this. I'm not following. What do you call the "new way"?