From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 46DE558C5 for ; Tue, 29 Nov 2016 17:24:25 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 29 Nov 2016 08:24:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,717,1473145200"; d="scan'208";a="197018128" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga004.fm.intel.com with ESMTP; 29 Nov 2016 08:24:23 -0800 To: Michael Bieniek , helin.zhang@intel.com, jingjing.wu@intel.com References: <1480106855-3287-1-git-send-email-michaelbieniekdpdk@gmail.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <79479644-eb62-c249-cd33-f0ab414c9fb7@intel.com> Date: Tue, 29 Nov 2016 16:24:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1480106855-3287-1-git-send-email-michaelbieniekdpdk@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] i40evf: add set maximum frame size support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:24:25 -0000 On 11/25/2016 8:47 PM, Michael Bieniek wrote: > This adds the ability to set maximum frame size for an i40e virtual > interface. This patch is based on the i40e physical function maximum > frame size implementation. This was tested on an system configured with > multiple i40e virtual functions. Verified that the MTU was configurable > and that sending packets greater than the configured MTU resulted in a > drop. > > Signed-off-by: Michael Bieniek Hi Michael, I guess this is the first patch, welcome to the DPDK community. > --- > drivers/net/i40e/i40e_ethdev_vf.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index aa306d6..8477c98 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -158,6 +158,7 @@ i40evf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id); > static void i40evf_handle_pf_event(__rte_unused struct rte_eth_dev *dev, > uint8_t *msg, > uint16_t msglen); > +static int i40evf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t); This is not something functional but, in declaration, if you used parameter name for first argument, let's use parameter name for second too. > > /* Default hash key buffer for RSS */ > static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1]; > @@ -225,6 +226,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = { > .reta_query = i40evf_dev_rss_reta_query, > .rss_hash_update = i40evf_dev_rss_hash_update, > .rss_hash_conf_get = i40evf_dev_rss_hash_conf_get, > + .mtu_set = i40evf_dev_mtu_set, > }; > > /* > @@ -2635,3 +2637,34 @@ i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev, > > return 0; > } > + > +static int > +i40evf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); hw is not used, and causing a build error. > + struct rte_eth_dev_data *dev_data = dev->data; > + uint32_t frame_size = mtu + ETHER_HDR_LEN > + + ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE; > + int ret = 0; > + > + /* check if mtu is within the allowed range */ > + if ((mtu < ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX)) > + return -EINVAL; > + > + /* mtu setting is forbidden if port is started */ > + if (dev_data->dev_started) { > + PMD_DRV_LOG(ERR, > + "port %d must be stopped before configuration\n", > + dev_data->port_id); > + return -EBUSY; > + } > + > + if (frame_size > ETHER_MAX_LEN) > + dev_data->dev_conf.rxmode.jumbo_frame = 1; > + else > + dev_data->dev_conf.rxmode.jumbo_frame = 0; > + > + dev_data->dev_conf.rxmode.max_rx_pkt_len = frame_size; > + > + return ret; > +} >