From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA2DCA0A0C;
	Fri,  9 Jul 2021 11:20:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 88BE84014D;
	Fri,  9 Jul 2021 11:20:05 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5A5F440143
 for <dev@dpdk.org>; Fri,  9 Jul 2021 11:20:04 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D6A797F53F;
 Fri,  9 Jul 2021 12:20:03 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D6A797F53F
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625822403;
 bh=mhLjTOZVtelmSvGEKXhWU4dpKXNZaUbNEgeZanhXl9s=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=kr0sOb6tx6L709Zqysq0DUf2i76UjfLkAn5W/j3262ceQxXyrl+Cn2PLRlyQ0NtHE
 Q8hPTMOBYoQtbuSZDs+QQnpCPndmILRVSyOWeUij4ds+XK0nYlvVT4GgFSbz5qCr++
 Nfugw5VT3TcjcJVOmZOJ8HuZmVzlg1VFMKAHLqvs=
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
References: <1623553508-5478-1-git-send-email-humin29@huawei.com>
 <59bcc1bc-a413-e1b9-698e-de23d8b27375@oktetlabs.ru>
 <ece7b7e7-1900-6ef2-6694-21e52a110e18@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <795a2927-c872-e957-fc7a-621d98e1cb88@oktetlabs.ru>
Date: Fri, 9 Jul 2021 12:20:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <ece7b7e7-1900-6ef2-6694-21e52a110e18@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/9/21 4:32 AM, Min Hu (Connor) wrote:
> Thanks Andrew,
> "net/hns3: supports disabling PFC by dev configure API"
> this patch could be abandoned.
> 
> The other three can be applied.
> 
> 
> 在 2021/6/14 23:00, Andrew Rybchenko 写道:
>> On 6/13/21 6:05 AM, Min Hu (Connor) wrote:
>>> This patch set contains 4 features for hns3 PMD:
>>> add query basic info support for VF
>>> support for VF modify VLAN filter state
>>> support multiple TC MAC pause
>>> supports disabling PFC by dev configure API
>>>
>>> Chengchang Tang (2):
>>>    net/hns3: add query basic info support for VF
>>>    net/hns3: support for VF modify VLAN filter state
>>>
>>> Huisong Li (2):
>>>    net/hns3: support multiple TC MAC pause
>>>    net/hns3: supports disabling PFC by dev configure API
>>>
>>>   drivers/net/hns3/hns3_cmd.h       |  9 ++++
>>>   drivers/net/hns3/hns3_dcb.c       | 61 +++++++++++++------------
>>>   drivers/net/hns3/hns3_ethdev.c    |  5 +-
>>>   drivers/net/hns3/hns3_ethdev.h    |  7 +++
>>>   drivers/net/hns3/hns3_ethdev_vf.c | 96
>>> ++++++++++++++++++++++++++++++---------
>>>   drivers/net/hns3/hns3_mbx.h       | 11 ++++-
>>>   6 files changed, 138 insertions(+), 51 deletions(-)
>>>
>>
>> Overall LGTM, but build breakage must be fixed.
>> .

Please, send a new version with the patch dropped.
I'd like patchwork automation to check it once
again.