From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63747A04FF; Fri, 29 Apr 2022 16:20:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 172E0415D7; Fri, 29 Apr 2022 16:20:17 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 2B8F6410E3 for ; Fri, 29 Apr 2022 16:20:15 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MUFpx/wkDakStdV83Oz25ffuF0z9WcZC+Ovx5utX7sPWxK3kroW6aUyfrrY+MeQX8a87dnWLqI99kbAkAffDpUrXET930s4YIyQrpcM99w4J52bu0yUJEp3qOKPTLgMfvgfUttzi8GODmdzdWHNd01ghdoTAsL2ZxotaTshjt8X3zecbS/GMgjM1xqjd+A8AjPW0fAQJFKexa+5WQeLNumrDyModGTrMio1HY9O6yn8dXVzrOseByKUTswpUEQ9t0g87zplMJmEfWZzixzdDhc8ECvcv4U8LG5lPaSe2AyXVlRg3lmyhE1mgKYStOYlRQQhZ9i4wgBcXMgz++JPM2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yR+eyCzzeKIyDZmIGrS7p28+HkZUOWm3QYVRkU9ZJ6s=; b=CJ2DTDeGP556TPReMeUrVVGl66+4XSg/4DUpmNPBMmQaZt5IgMPyA3pgXitjjrPmLaW5TMwTGBs5hfLKPFVWDqBuP+7+sj/3lqJpQc22IT8dLNt9TF65Cgk2ufduKpnwpU6qJV3pZvCvL0bLMg9WzKafST+MXj5zAgNJKp4e9gO5jfdmD0pP3XKULw33RBfRu6mqiIo91k26auFIsT3ZgKt+JQO0bbyEkYGLLqQKQIK+6F+1E5cRSO1TPy2/H80RZPxpKlNeO+1hS8bgnRoyMmIDla9Ob8OwSidzx5sl3c0e1rDOzRQo6WUXSoL9l4ZNQbSZhlPtwZcqDn+GcZ6HaQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 20.83.241.18) smtp.rcpttodomain=163.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=xilinx.com] dmarc=[1,1,header.from=xilinx.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yR+eyCzzeKIyDZmIGrS7p28+HkZUOWm3QYVRkU9ZJ6s=; b=iRyJ1MjEtlBOnGD001rQQGjXEWIDYnzua6c7haKUAciwGhXgg41R85Ld9t9egNm6cXsqZjngwKoE9g8tRGrEJ4mnVg8SDEHnNRsoPLh+IvWxMzZeiKwLnnoEetJOjek/zg3ccD/uSbi6hS9k77jXURU5Vh4VMgVTVt4UPwYmJmU= Received: from SN7PR04CA0192.namprd04.prod.outlook.com (2603:10b6:806:126::17) by BN6PR02MB2178.namprd02.prod.outlook.com (2603:10b6:404:31::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 14:20:13 +0000 Received: from SN1NAM02FT0013.eop-nam02.prod.protection.outlook.com (2603:10b6:806:126:cafe::86) by SN7PR04CA0192.outlook.office365.com (2603:10b6:806:126::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 14:20:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 20.83.241.18) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 20.83.241.18 as permitted sender) receiver=protection.outlook.com; client-ip=20.83.241.18; helo=mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net; Received: from mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net (20.83.241.18) by SN1NAM02FT0013.mail.protection.outlook.com (10.97.4.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 14:20:12 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net (Postfix) with ESMTPS id 432B23F02B; Fri, 29 Apr 2022 14:20:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njhKxCOh833vb+7TBPEhUJZaYHdLZOwIvJlCSjWqQUDvh0d9jvtIdREZnv5GxtA2wEErx4qxRxMrcW0eOcaIHhE3t8QlO6HaAkSO1oqvVmLwZMWLtbJhTAiwOkPv57sCzenO0RKV/6uNkOK0U8n9QRgRghClm4Y8Qp57i1YmOpfUx2WNe0PPkOKndWYFPweKT0DWfiGujxEOdOagIuJPRteS52aQ+VV6JRKL2Fe2GpUH71c2Mut4lhnBJLQqjEtkIDIUutmrVmugORSQl5QCNNm3faT6MOJFtpAM9ZvWm8vdlW9OVr2nYJmqRtCDIaq2eL+DpcctWp2RDFHeXm8BSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yR+eyCzzeKIyDZmIGrS7p28+HkZUOWm3QYVRkU9ZJ6s=; b=WztXiDZAL8kNwYqFCnpLKYX9vjkWPWUQ6vcw86QizXTxfrAmN6qRBcGIMpnYGE3oWLF8heVqCiLi0adai4fld7MB83thR9m/zWjs5HwmmB0FiahL8xf+wdOxCFIgLYtNHdAZR3dOru4mgLDqsW0UiwPHtEYubZmsxE19z8YdWr2+77EsySEk+Ocu8f4xfXJb5Vyr867ILSfkJttHY/QqQA2/cl/9vh8IDCsaoi5nvrN93wmsaItnu1ivgzgsDkIJ0+xJyVx5bTGEGa3XpD01GUNUCdcwS+qBbc/eYSqtkw3zbdIXeISkoZkoQEGNrP461VqIdYKkHQD0kbUIElM/EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=163.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none Received: from DM6PR02CA0137.namprd02.prod.outlook.com (2603:10b6:5:1b4::39) by BY5PR02MB6978.namprd02.prod.outlook.com (2603:10b6:a03:23f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 14:20:10 +0000 Received: from DM3NAM02FT033.eop-nam02.prod.protection.outlook.com (2603:10b6:5:1b4:cafe::a6) by DM6PR02CA0137.outlook.office365.com (2603:10b6:5:1b4::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 14:20:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT033.mail.protection.outlook.com (10.13.4.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 14:20:09 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 15:20:08 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 15:20:08 +0100 Envelope-to: gaoxiangliu0@163.com, chas3@att.com, humin29@huawei.com, olivier.matz@6wind.com, dev@dpdk.org, liugaoxiang@huawei.com, arybchenko@solarflare.com, mb@smartsharesystems.com, haiyue.wang@intel.com, matan@nvidia.com, viacheslavo@nvidia.com Received: from [172.21.34.28] (port=60165) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkRTX-0002gc-M4; Fri, 29 Apr 2022 15:20:08 +0100 Message-ID: <795c0357-3251-5297-256f-3d4bdf6a3ad8@xilinx.com> Date: Fri, 29 Apr 2022 15:20:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v7] net/bonding: another fix to LACP mempool size Content-Language: en-US To: Gaoxiang Liu , , CC: , , , "Andrew Rybchenko" , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Haiyue Wang , Matan Azrad , Viacheslav Ovsiienko References: <20220325133426.2916-1-gaoxiangliu0@163.com> <20220328151652.221-1-gaoxiangliu0@163.com> From: Ferruh Yigit In-Reply-To: <20220328151652.221-1-gaoxiangliu0@163.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 5840ddea-3f86-4053-f400-08da29eb5fde X-MS-TrafficTypeDiagnostic: BY5PR02MB6978:EE_|SN1NAM02FT0013:EE_|BN6PR02MB2178:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vpLBAwJCt6YaCfapBmXB/imO2tlaP+zYGSJCR/HxTV4J9zwdHuKYFZD+/wUbEeTQnpb1kppTRz2AzkFe9LXN/DU/sqg/Fn4EARJpWUgRL74pS/Qpt1kne0nj35VGGuMcKil0eF8hGM6F3zsXoP7j0w66vo5uvxG5VOmdR3v6qzr+J4wOdF3eGgHNwE63nFp9BrY2vNUT6VLP2mP7ekq/JfwjbYS+jP9ME/hVF2tRTgM3KBo5kehnkW2vqhvqOm5xy2CHq7EQwhRt6mdzS0YOJr4v3xJ6Trm30vyWrTRJowho5+30eZI0mBA86XWSfspacI98sH+qpqxAmM2BkFQ0jqLBbic20ARsTf/W5Iw/s3lxQ0GqU5OfGMzRHMe71OReYiqbMawP4vTKo4pxC2ukN9d0zCPfAle9OcptDpPmN2uqQFsRXLQ99xjGocG1HTtMj9qcqgg56DDfm5N3v/QLvycOTlbxgVVodWmcl4CRL3aCVcIOzXixFX2vsFHuA1cf8LWFsxKvfyBarqwqQzOiDm1fqtWnrwrW1BEgFq9xQzLu7orTYHKGDDFBbh0Cmy3BNO3DO8qdfeSPy4Z+rmo798clk15bO24L6TLOlcIeievpWC9FPGQh/2VkcJbBcRzYeMAG5Xx1fN8Cfyu2l9XxhyzdJi95Vq/UgcuSYyyF0Zkl6rfoHFB6xckf1JGa+cdqG36h+/5jj8k762z/DLBKNxh+UQp8bnzjg2uFuYVjTJQ= X-Forefront-Antispam-Report-Untrusted: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(186003)(5660300002)(36756003)(2906002)(36860700001)(44832011)(316002)(70206006)(7416002)(9786002)(4326008)(83380400001)(8676002)(8936002)(70586007)(31686004)(110136005)(54906003)(2616005)(31696002)(40460700003)(336012)(426003)(47076005)(82310400005)(508600001)(356005)(6666004)(7636003)(26005)(53546011)(50156003)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6978 X-MS-Exchange-Transport-CrossTenantHeadersStripped: SN1NAM02FT0013.eop-nam02.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ed6c738e-fbd5-4897-0942-08da29eb5de3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frMlca5xF4ClSzw9XC/d+0ENiXYf9JLpGYGMKUj9gmKlkubNdMvWEuzwCjrdKdCUCf3/h3A1gFGkyTCo3HD3gIbT1ehsM7zYAXmNd28s3/K6XoeCkcVhwLQo+N57zq20gxSKYaFOQf2FaqpTbOzXJt53x1nzESuOcJB6XIzp8TDgyVGYmaL5iMECwSBsN15ubKdwiS4xoqUgv4rgAwPUTcPZyTZhn0q1B9Ejox3J7MdCBPll4THvI3RVmtccbzOaV54VkAOvFMzNz3WzCEHbuee88WVQeROFl8rc4KjeGO4P1lk0nMABqJjabVNwD4JMLFjZ42ZVd2eACpkhAzzGsQjgcdVBU588VwH8FJOkunm8rDEunv8ZL3/JQ3/pCWG6riGedksi/Ssx7nSFOQA4k17gnGXAny8YA+PzPssjc/2IU2w41ayYq7mBJcC5S1TFcv9Bz9pwqnA9Xa1bO9rYExzHVrOMc+V5FIbbY2yUblxv75GstYeUswsl7MvohDhrNXGhiQmumQo2C5qEPDXzLLGptacX/XOtkNAAAsEBt3UmGV+vQFbk13cwo0KArMymmAOncEMkNI/vATn+XnFjIF3vErmp/SycmUWHiwKn5zn554IznnVhFkLaaCyl6aU6FaDzBBbgxqgRyNAOyKoTbvBL4hdgHQ+zQCOpIhaPiwaomSmbSq6PWT1PPe/MG/qZ8FTEMy7kFf0PGdzN7itpoW8Jqwyfwqmk62Dw/m/L5YXfR5REGO+Hc8nMEPYab5RnnauuO5opZgHyckhkspEO1Q== X-Forefront-Antispam-Report: CIP:20.83.241.18; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(40460700003)(6666004)(31696002)(70206006)(8676002)(36756003)(4326008)(2906002)(8936002)(44832011)(5660300002)(9786002)(7416002)(26005)(36860700001)(83380400001)(2616005)(110136005)(508600001)(426003)(54906003)(53546011)(31686004)(316002)(336012)(82310400005)(81166007)(186003)(47076005)(50156003)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 14:20:12.7596 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5840ddea-3f86-4053-f400-08da29eb5fde X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[20.83.241.18]; Helo=[mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1NAM02FT0013.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2178 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/28/2022 4:16 PM, Gaoxiang Liu wrote: > The following log message may appear after a slave is idle(or nearly > idle) > for a few minutes:"PMD: Failed to allocate LACP packet from pool". > And bond mode 4 negotiation may fail. > > Problem:When bond mode 4 has been chosed and delicated queue has > not been enable, all mbufs from a slave' private pool(used > exclusively for transmitting LACPDUs) have been allocated in > interrupt thread, and are still sitting in the device's tx > descriptor ring and other cores' mempool caches in fwd thread. > Thus the interrupt thread can not alloc LACP packet from pool. > > Solution: Ensure that each slave'tx (LACPDU) mempool owns more than > n-tx-queues * n-tx-descriptor + fwd_core_num * > per-core-mmempool-flush-threshold mbufs. > > Note that the LACP tx machine fuction is the only code that allocates > from a slave's private pool. It runs in the context of the interrupt > thread, and thus it has no mempool cache of its own. > > Signed-off-by: Gaoxiang Liu > > --- > v2: > * Fixed compile issues. > > v3: > * delete duplicate code. > > v4; > * Fixed some issues. > 1. total_tx_desc should use += > 2. add detailed logs > > v5: > * Fixed some issues. > 1. move CACHE_FLUSHTHRESH_MULTIPLIER to rte_eth_bond-8023ad.c > 2. use RTE_MIN > > v6: > * add a comment of CACHE_FLUSHTHRESH_MULTIPLIER macro > > v7: > * Fixed some issues. > 1. move CACHE_FLUSHTHRESH_MULTIPLIER to rte_mempool.h > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 7 ++++--- > lib/mempool/rte_mempool.h | 2 ++ > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index ca50583d62..f7f6828126 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -1050,6 +1050,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, > uint32_t total_tx_desc; > struct bond_tx_queue *bd_tx_q; > uint16_t q_id; > + uint32_t cache_size; > > /* Given slave mus not be in active list */ > RTE_ASSERT(find_slave_by_id(internals->active_slaves, > @@ -1100,11 +1101,11 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, > total_tx_desc += bd_tx_q->nb_tx_desc; > } > > + cache_size = RTE_MIN(RTE_MEMPOOL_CACHE_MAX_SIZE, 32); > + total_tx_desc += rte_lcore_count() * cache_size * RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER; > snprintf(mem_name, RTE_DIM(mem_name), "slave_port%u_pool", slave_id); > port->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc, > - RTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ? > - 32 : RTE_MEMPOOL_CACHE_MAX_SIZE, > - 0, element_size, socket_id); > + cache_size, 0, element_size, socket_id); > > /* Any memory allocation failure in initialization is critical because > * resources can't be free, so reinitialization is impossible. */ > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h > index 1e7a3c1527..fa15ed710f 100644 > --- a/lib/mempool/rte_mempool.h > +++ b/lib/mempool/rte_mempool.h > @@ -56,6 +56,8 @@ > extern "C" { > #endif > > +#define RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER 1.5 > + This change seems already get some comments and changes in previous versions. I also thought why we are adding a new macro to the mempool for a bonding driver update, but that is not the whole picture. There is an existing 'CACHE_FLUSHTHRESH_MULTIPLIER' macro in mempool, this patch wants to use it but that macro is not exposed. And I can see there is other user of that macros (mlx5_rxq.c [1]) suffering from same problem. So, what do you think having two patches, - first one is only for mempool update, which removes the 'CACHE_FLUSHTHRESH_MULTIPLIER' from 'rte_mempool.c', adds 'RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER' to 'rte_mempool.h' as this patch does, and update existing usage. - second patch just updates the bonding driver and use the new 'RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER' macro [1] @Matan, @Slava, 'mlx5_rxq.c', comment mentions that it intends to use 'CACHE_FLUSHTHRESH_MULTIPLIER' but can't access it and use a hardcoded value (2). But the hard coded value and macro values doesn't match, is it intentional. When 'RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER' is exposed in header, can it be replaced with hard coded value in the driver? > #define RTE_MEMPOOL_HEADER_COOKIE1 0xbadbadbadadd2e55ULL /**< Header cookie. */ > #define RTE_MEMPOOL_HEADER_COOKIE2 0xf2eef2eedadd2e55ULL /**< Header cookie. */ > #define RTE_MEMPOOL_TRAILER_COOKIE 0xadd2e55badbadbadULL /**< Trailer cookie.*/