DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Ori Kam <orika@mellanox.com>
Cc: dev@dpdk.org, Yongseok Koh <yskoh@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix Direct Verbs flow matcher caching
Date: Tue, 9 Oct 2018 15:52:13 +0100	[thread overview]
Message-ID: <79631986-f1f4-fdc0-c303-4415fea07d44@intel.com> (raw)
In-Reply-To: <1894764.h71D8BIBkf@xps>

On 10/4/2018 9:39 PM, Thomas Monjalon wrote:
> 04/10/2018 07:53, Ori Kam:
>> The Direct Verbs are using matcher object to filter flows, This object
>> can be reused for all flows that are using the same flow items and
>> masks.
>>
>> This was implemented with an issue, that the list pointer pointed
>> to incorrect list type, this resulted in compilation error when using
>> GCC greater then 4.8.5
>>
>> This commit fixes this issue by setting that the matcher object
>> will include the LIST required members directly and not as a subobject.
>>
>> Fixes: 8d21c3d7b237 ("net/mlx5: add Direct Verbs translate items")
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> 
> applied to dpdk-next-net-mlx

Squashed into relevant commit in next-net, thanks.

But since this patch touches more than what it claims fixing [1], it took some
effort, final output of conflict resolving looks OK but please confirm top of
next-net.


[1]
net/mlx5: add Direct Verbs final functions
net/mlx5: add Direct Verbs translate items
net/mlx5: add Direct Verbs prepare function

      reply	other threads:[~2018-10-09 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04  5:53 Ori Kam
2018-10-04 20:39 ` Thomas Monjalon
2018-10-09 14:52   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79631986-f1f4-fdc0-c303-4415fea07d44@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=orika@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).