From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 88E427D42 for ; Wed, 23 Aug 2017 12:48:41 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2017 03:47:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,416,1498546800"; d="scan'208";a="121843523" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 23 Aug 2017 03:47:31 -0700 To: David Harton , mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com Cc: dev@dpdk.org References: <20170823004145.29046-1-dharton@cisco.com> From: Ferruh Yigit Message-ID: <79655ab0-8e8f-b9b2-51bd-af50fc783604@intel.com> Date: Wed, 23 Aug 2017 11:47:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170823004145.29046-1-dharton@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 10:48:42 -0000 On 8/23/2017 1:41 AM, David Harton wrote: > eth_ena_dev_init() was not initializing all of the common > pci dev info for the rte_eth_dev. Added call to > rte_eth_copy_pci_info() to complete the init particularly > the driver name. rte_eth_copy_pci_info() already called during probe [1], what information was missing? [1] eth_ena_pci_probe() rte_eth_dev_pci_generic_probe() rte_eth_dev_pci_allocate() rte_eth_copy_pci_info() <--- eth_ena_dev_init() ... <--- where rte_eth_copy_pci_info() added again. > > Signed-off-by: David Harton > --- > drivers/net/ena/ena_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 80ce1f3..a6c408b 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) > return 0; > > pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); > + rte_eth_copy_pci_info(eth_dev, pci_dev); > adapter->pdev = pci_dev; > > PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d", >