[dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

[dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

[David Harton]

eth_ena_dev_init() was not initializing all of the common
pci dev info for the rte_eth_dev.  Added call to
rte_eth_copy_pci_info() to complete the init particularly
the driver name.

Signed-off-by: David Harton <dharton@cisco.com>
---
 drivers/net/ena/ena_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 80ce1f3..a6c408b 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
 		return 0;
 
 	pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
+	rte_eth_copy_pci_info(eth_dev, pci_dev);
 	adapter->pdev = pci_dev;
 
 	PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

[Michał Krawczyk]

Acked-by: Michal Krawczyk <mk@semihalf.com>

2017-08-23 2:41 GMT+02:00 David Harton <dharton@cisco.com>:

> eth_ena_dev_init() was not initializing all of the common
> pci dev info for the rte_eth_dev.  Added call to
> rte_eth_copy_pci_info() to complete the init particularly
> the driver name.
>
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 80ce1f3..a6c408b 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev
> *eth_dev)
>                 return 0;
>
>         pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> +       rte_eth_copy_pci_info(eth_dev, pci_dev);
>         adapter->pdev = pci_dev;
>
>         PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
> --
> 1.8.3.1
>
>

Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

[Ferruh Yigit]

On 8/23/2017 1:41 AM, David Harton wrote:
> eth_ena_dev_init() was not initializing all of the common
> pci dev info for the rte_eth_dev.  Added call to
> rte_eth_copy_pci_info() to complete the init particularly
> the driver name.

rte_eth_copy_pci_info() already called during probe [1], what
information was missing?

[1]
eth_ena_pci_probe()
  rte_eth_dev_pci_generic_probe()
    rte_eth_dev_pci_allocate()
      rte_eth_copy_pci_info()  <---
    eth_ena_dev_init()
      ... <--- where rte_eth_copy_pci_info() added again.

> 
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 80ce1f3..a6c408b 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
>  		return 0;
>  
>  	pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> +	rte_eth_copy_pci_info(eth_dev, pci_dev);
>  	adapter->pdev = pci_dev;
>  
>  	PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
> 

Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

[David Harton (dharton)]

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Wednesday, August 23, 2017 6:48 AM
> To: David Harton (dharton) <dharton@cisco.com>; mw@semihalf.com;
> mk@semihalf.com; gtzalik@amazon.com; evgenys@amazon.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info
> 
> On 8/23/2017 1:41 AM, David Harton wrote:
> > eth_ena_dev_init() was not initializing all of the common pci dev info
> > for the rte_eth_dev.  Added call to
> > rte_eth_copy_pci_info() to complete the init particularly the driver
> > name.
> 
> rte_eth_copy_pci_info() already called during probe [1], what information
> was missing?
> 
> [1]
> eth_ena_pci_probe()
>   rte_eth_dev_pci_generic_probe()
>     rte_eth_dev_pci_allocate()
>       rte_eth_copy_pci_info()  <---
>     eth_ena_dev_init()
>       ... <--- where rte_eth_copy_pci_info() added again.

This patch was based on 16.07.  It looks like "recent" change added the missing coverage and I missed it:
dcd5c8112bc3d0c8407cbab1f3a16799a8c7e5e4

Thanks,
Dave

> 
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
> > ---
> >  drivers/net/ena/ena_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ena/ena_ethdev.c
> > b/drivers/net/ena/ena_ethdev.c index 80ce1f3..a6c408b 100644
> > --- a/drivers/net/ena/ena_ethdev.c
> > +++ b/drivers/net/ena/ena_ethdev.c
> > @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev
> *eth_dev)
> >  		return 0;
> >
> >  	pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> > +	rte_eth_copy_pci_info(eth_dev, pci_dev);
> >  	adapter->pdev = pci_dev;
> >
> >  	PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
> >