* [PATCH] app/dumpcap: allow help/version without primary process
@ 2022-01-25 3:25 Ben Magistro
2022-02-22 10:03 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ben Magistro @ 2022-01-25 3:25 UTC (permalink / raw)
To: dev; +Cc: ben.magistro, stephen, Ben Magistro
Currently dumpcap tries to initialize dpdk before parsing command line
arguments, this makes it impossible to check version or help without
having the primary process running already.
Signed-off-by: Ben Magistro <koncept1@gmail.com>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index c5fe440302..1cc7e80d5d 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -781,8 +781,8 @@ int main(int argc, char **argv)
progname = argv[0];
- dpdk_init();
parse_opts(argc, argv);
+ dpdk_init();
if (filter_str)
compile_filter();
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/dumpcap: allow help/version without primary process
2022-01-25 3:25 [PATCH] app/dumpcap: allow help/version without primary process Ben Magistro
@ 2022-02-22 10:03 ` Thomas Monjalon
2022-03-08 8:32 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2022-02-22 10:03 UTC (permalink / raw)
To: ben.magistro, stephen, Ben Magistro, Reshma Pattan; +Cc: dev
25/01/2022 04:25, Ben Magistro:
> Currently dumpcap tries to initialize dpdk before parsing command line
> arguments, this makes it impossible to check version or help without
> having the primary process running already.
>
> Signed-off-by: Ben Magistro <koncept1@gmail.com>
> ---
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -781,8 +781,8 @@ int main(int argc, char **argv)
>
> progname = argv[0];
>
> - dpdk_init();
> parse_opts(argc, argv);
> + dpdk_init();
Stephen, Reshma, any comment?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/dumpcap: allow help/version without primary process
2022-02-22 10:03 ` Thomas Monjalon
@ 2022-03-08 8:32 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-03-08 8:32 UTC (permalink / raw)
To: ben.magistro, Ben Magistro; +Cc: stephen, Reshma Pattan, dev
22/02/2022 11:03, Thomas Monjalon:
> 25/01/2022 04:25, Ben Magistro:
> > Currently dumpcap tries to initialize dpdk before parsing command line
> > arguments, this makes it impossible to check version or help without
> > having the primary process running already.
> >
> > Signed-off-by: Ben Magistro <koncept1@gmail.com>
> > ---
> > --- a/app/dumpcap/main.c
> > +++ b/app/dumpcap/main.c
> > @@ -781,8 +781,8 @@ int main(int argc, char **argv)
> >
> > progname = argv[0];
> >
> > - dpdk_init();
> > parse_opts(argc, argv);
> > + dpdk_init();
>
> Stephen, Reshma, any comment?
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 3:25 [PATCH] app/dumpcap: allow help/version without primary process Ben Magistro
2022-02-22 10:03 ` Thomas Monjalon
2022-03-08 8:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).