From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: jerinjacobk@gmail.com, "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: [dpdk-dev] rte_event_dev_xstats_by_name_get issues
Date: Thu, 12 Dec 2019 11:32:23 +0100 [thread overview]
Message-ID: <796ea779-91d2-2aa1-b5ff-40f725f7d5f3@ericsson.com> (raw)
Hi.
I'm looking at implementing rte_event_dev_xstats_by_name() for DSW, and
I have some API-related questions.
Shouldn't rte_event_dev_xstats_by_name_get() return mode and queue/port
id? Otherwise the caller needs to know if the name refers to a device-
or port-level stat, and in case of the latter also the port or queue id.
That information is needed in subsequent rte_event_dev_xstats_get() call.
Also, the API states that the function may return "negative value:
-EINVAL if stat not found, -ENOTSUP if not supported", which is somewhat
misleading, since the return value is of an unsigned type.
Regards,
Mattias
reply other threads:[~2019-12-12 10:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796ea779-91d2-2aa1-b5ff-40f725f7d5f3@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).