From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B3C51A0350;
Thu, 7 May 2020 17:15:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7FE921DAC1;
Thu, 7 May 2020 17:15:42 +0200 (CEST)
Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com
[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id CCF961DAAD
for <dev@dpdk.org>; Thu, 7 May 2020 17:15:40 +0200 (CEST)
Received: from eucas1p1.samsung.com (unknown [182.198.249.206])
by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id
20200507151540euoutp026f6961b8c0edf260b66f5df553a594e7~Mx_GSyhzn2996329963euoutp027
for <dev@dpdk.org>; Thu, 7 May 2020 15:15:40 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com
20200507151540euoutp026f6961b8c0edf260b66f5df553a594e7~Mx_GSyhzn2996329963euoutp027
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;
s=mail20170921; t=1588864540;
bh=fqtVmaxBYyqcbXAYCLg1uUgnmLcOE8MhQElHfexVh8w=;
h=Subject:To:Cc:From:Date:In-Reply-To:References:From;
b=tXN/j2atbyfXz9WzcirFzIaaYLOEz9RO2Co2nXDdxnaMDaPVneaj+PRmtX2UyqKR3
tPGPNjrFBctVW322rWySI3+2+Z2KNHISGb91Wi59jYI8hsLkPrL15IWuBF1cEeO0EK
IOESp2f9ahmJ4o+PamJaf+Gbs08zV85VvJZ4UTMA=
Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by
eucas1p1.samsung.com (KnoxPortal) with ESMTP id
20200507151539eucas1p1aa51240fc7874b51b2655e7b3c34bb3b~Mx_GCWFH02947529475eucas1p12;
Thu, 7 May 2020 15:15:39 +0000 (GMT)
Received: from eucas1p2.samsung.com ( [182.198.249.207]) by
eusmges2new.samsung.com (EUCPMTA) with SMTP id 8C.93.60679.B1624BE5; Thu, 7
May 2020 16:15:39 +0100 (BST)
Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by
eucas1p2.samsung.com (KnoxPortal) with ESMTPA id
20200507151539eucas1p248c72fa53bad99e43f76f3c9be090e61~Mx_Flb0A62813928139eucas1p2R;
Thu, 7 May 2020 15:15:39 +0000 (GMT)
Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by
eusmtrp2.samsung.com (KnoxPortal) with ESMTP id
20200507151539eusmtrp261df320e169633398c133da6e7f43ac1~Mx_Fk1Oaf0599705997eusmtrp2K;
Thu, 7 May 2020 15:15:39 +0000 (GMT)
X-AuditID: cbfec7f4-0cbff7000001ed07-b7-5eb4261ba125
Received: from eusmtip1.samsung.com ( [203.254.199.221]) by
eusmgms1.samsung.com (EUCPMTA) with SMTP id 27.B4.08375.B1624BE5; Thu, 7
May 2020 16:15:39 +0100 (BST)
Received: from [106.109.129.29] (unknown [106.109.129.29]) by
eusmtip1.samsung.com (KnoxPortal) with ESMTPA id
20200507151538eusmtip1083e33e94237b3a5f46ec1c7d526e2ae~Mx_FG5bmU0902409024eusmtip1O;
Thu, 7 May 2020 15:15:38 +0000 (GMT)
To: Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko
<arybchenko@solarflare.com>
Cc: dev@dpdk.org, v.kuramshin@samsung.com, david.marchand@redhat.com,
ferruh.yigit@intel.com
From: Ivan Dyukov <i.dyukov@samsung.com>
Message-ID: <7985c4b9-557e-095a-5c68-c3affb019ee5@samsung.com>
Date: Thu, 7 May 2020 18:15:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <5595669.UjTJXf6HLC@thomas>
Content-Transfer-Encoding: 8bit
Content-Language: ru-RU
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsWy7djP87rSalviDPYdMLB4MOUum8X2FV1s
Fu8+bWeyuLP3NLvFpwcnWCxO39zM7sDm8WvBUlaPxXteMnkcuzmN3eP9vqtsHn1bVjF6rH7y
gy2ALYrLJiU1J7MstUjfLoErY9mKNtaCLr6K739qGxj7uLsYOTkkBEwkjjyey9rFyMUhJLCC
UeLwnQYo5wujxPSVXewQzmdGiV+rvrPDtPx5N4cJIrGcUeL32Z1QVe8ZJZbfW8IMUiUsECSx
acE+RhBbRCBSoufpdlYQm1kgTmLFy4VgNpuAhsTpjnlMIDavgJ1E98/TYHEWARWJKfsWsYHY
ogIREv8nPWaBqBGUODnzCZjNCdR7YP8DRoiZ8hLNW2czQ9jiEh+2H2QDOUhCYBO7xIm2i0wQ
Z7tI7Ji8jgXCFpZ4dXwL1DsyEv93zoeqqZb4vuk6O0RzB6PEvUWtUEX2EltenwOyOYA2aEqs
36UPEXaU6PkMMpMDyOaTuPFWEOIGPolJ26YzQ4R5JTrahCCqlSQOnLwEFZaQ+PubZwKj0iwk
j81C8swsJM/MQli7gJFlFaN4amlxbnpqsVFearlecWJucWleul5yfu4mRmAKOv3v+JcdjLv+
JB1iFOBgVOLhtfi4OU6INbGsuDL3EKMEB7OSCC/Pj41xQrwpiZVVqUX58UWlOanFhxilOViU
xHmNF72MFRJITyxJzU5NLUgtgskycXBKNTDudGdZ4t+0bOvDDX/nrPniyJL9jWP7a+mjtUd4
hNUi1QocuzS3Vd/17wlVm7pa/Iruh+OK9xUPSliu7nifYhKY8PXrFIvvuqeNc04tzpU8Pfv4
YfesvxKMGd7pWRwure5CbxMtTfd8mNfpNSHo+MU/BxyVf8kc/yWQuyS29K1Wom/aZSu+wC9K
LMUZiYZazEXFiQCBbRFEPQMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t/xu7rSalviDHYelrB4MOUum8X2FV1s
Fu8+bWeyuLP3NLvFpwcnWCxO39zM7sDm8WvBUlaPxXteMnkcuzmN3eP9vqtsHn1bVjF6rH7y
gy2ALUrPpii/tCRVISO/uMRWKdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1J7MstUjfLkEv
Y9mKNtaCLr6K739qGxj7uLsYOTkkBEwk/rybw9TFyMUhJLCUUeLV0VaWLkYOoISExOsnzBA1
whJ/rnWxQdS8ZZS4eOkNI0hCWCBIYtOCfYwg9SICkRJL7wWBhJkF4iSuTPvIClHfyCSx4cwx
VpAEm4CGxOmOeUwgNq+AnUT3z9NgcRYBFYkp+xaxgdiiAhESnw8eYYOoEZQ4OfMJC4jNCdR7
YP8DRogFZhLzNj9khrDlJZq3zoayxSU+bD/INoFRaBaS9llIWmYhaZmFpGUBI8sqRpHU0uLc
9NxiQ73ixNzi0rx0veT83E2MwJjbduzn5h2MlzYGH2IU4GBU4uG1+Lg5Tog1say4MvcQowQH
s5IIL8+PjXFCvCmJlVWpRfnxRaU5qcWHGE2BnpvILCWanA9MB3kl8YamhuYWlobmxubGZhZK
4rwdAgdjhATSE0tSs1NTC1KLYPqYODilGhjDGNZNSzT5HWE/+9QHHb4Yg7qZytu1WdYsCk8L
+Pk4L3VB10Om6ndyJj/8Z7QHBlToNK78a2PAnc0m3cslESp/a+aHk2wZ2W2rdF45yvLcfMHv
++uCSLsI38ztU9zOBR9dVBRa8VtXo6JlZ7yrS71u/SP/T6VdXzc2cV51Vs7Sj15mxPkuXoml
OCPRUIu5qDgRAOvLh+vPAgAA
X-CMS-MailID: 20200507151539eucas1p248c72fa53bad99e43f76f3c9be090e61
X-Msg-Generator: CA
Content-Type: text/plain; charset="utf-8"
X-RootMTR: 20200507102835eucas1p2fff792b2cd349131f5614b1c031187da
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20200507102835eucas1p2fff792b2cd349131f5614b1c031187da
References: <4816966.qqrk5fENW1@thomas>
<20200427095737.11082-4-i.dyukov@samsung.com>
<0deb10b5-2ea0-e319-a23d-893b0c625e1f@solarflare.com>
<CGME20200507102835eucas1p2fff792b2cd349131f5614b1c031187da@eucas1p2.samsung.com>
<5595669.UjTJXf6HLC@thomas>
Subject: Re: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in
output
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
07.05.2020 13:28, Thomas Monjalon пишет:
> 01/05/2020 15:15, Andrew Rybchenko:
>> On 4/27/20 12:57 PM, Ivan Dyukov wrote:
>>> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
>>> ---
>>> app/test-pmd/testpmd.c | 2 +-
>>> app/test/test_pmd_perf.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
>>> index 99bacddbf..d4df23a93 100644
>>> --- a/app/test-pmd/testpmd.c
>>> +++ b/app/test-pmd/testpmd.c
>>> @@ -3005,7 +3005,7 @@ check_all_ports_link_status(uint32_t port_mask)
>>> "Port%d Link Up. speed %u Mbps- %s\n",
>>> portid, link.link_speed,
>>> (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
>>> - ("full-duplex") : ("half-duplex\n"));
>>> + ("full-duplex") : ("half-duplex"));
>>> else
>>> printf("Port %d Link Down\n", portid);
>>> continue;
>>> diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
>>> index d61be58bb..352cd4715 100644
>>> --- a/app/test/test_pmd_perf.c
>>> +++ b/app/test/test_pmd_perf.c
>>> @@ -151,7 +151,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
>>> "Port%d Link Up. Speed %u Mbps - %s\n",
>>> portid, link.link_speed,
>>> (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
>>> - ("full-duplex") : ("half-duplex\n"));
>>> + ("full-duplex") : ("half-duplex"));
>>> if (link_mbps == 0)
>>> link_mbps = link.link_speed;
>>> } else
>>>
>>
>> I think Fixes: tag is required here.
>>
>> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Yes please, we would like to backport it.
>
>
>
Ok. I'll make separate patch for that. There are about 24 same
'copy/paste' in example folder.