From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 8B5C72C08 for ; Thu, 27 Oct 2016 12:38:00 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id e69so25379525wmg.0 for ; Thu, 27 Oct 2016 03:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=2pR0xFc0Zl7L39CyPHLd6KXUwKkMjfK0TcXMik6wSlQ=; b=UEgCzeuEW3/m230+QY4T3sHBTY10Ze7LOlEbKoexAgPAX80+5JZQESstskrPyCIQeU i55yi/3ku2Rt8520D346tsfOMGdY5ZnrNerCJKqDUEzn9LQ0XzJBIC0/mhjNCdKg49KG 9uDT4Dnl7mrIwFJX7z4bOLcOjRta8bZ00Z8CrYI66Du7tQ6WtFCo4i0Rn0vz7xRl/78f PmSym2n9pYn5gKfyHU98pRQdnciEsz4PPeMafUHBgZ7LIZMugiatcT1UXYbnb1i3QrMG h7Jbhln18UMzU8G8ypfIBF9P/Y/16NIKuiE2uyOeLefQImZJrBMWNJNBW8e30XA/Qol6 kYNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=2pR0xFc0Zl7L39CyPHLd6KXUwKkMjfK0TcXMik6wSlQ=; b=UzfNqkDLJtHaXzthmiEj3428JdDMN26EVcUkcDGwMw6uwxGk8spEXIgczM4dWhV55i RNhVVNVKRJK4AaLmFkzWXUHalP+IqBun/Myxk005SQSLt3WJoG0OUj1ZvITmNWCPIzvS tTXEQoqD0od8tffTzpJmFrLvq38NgwZWka0/bx9Md9JcGvpmcjaqljfIsGOpAZqTy7Tk it1KCxNdCSi5BY4VrqXCh4alQaGGf21whl5nxSlBIsQ9Vo6d4CTXWgZ0jMikIK0Vcc1X SU74CWzS5EMsTLhSb7NaRa+WcSctpGcKDLngiasBQYh2Jqk16knRpjgcNZ7WezlIi2P/ zG4w== X-Gm-Message-State: ABUngveCGN/8gIGUyseUYskCvl5izVR+LUtIDMwfGFsixM5xszayqLlCTxPzuqzoKNKb9mc+ X-Received: by 10.194.115.168 with SMTP id jp8mr6173713wjb.27.1477564680213; Thu, 27 Oct 2016 03:38:00 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l130sm2480750wmb.18.2016.10.27.03.37.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 03:37:59 -0700 (PDT) From: Thomas Monjalon To: Andrew Rybchenko Date: Thu, 27 Oct 2016 12:37:58 +0200 Message-ID: <7987614.kmGMHz0qWb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Solarflare PMD submission question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 10:38:00 -0000 Hi, First of all, welcome to DPDK! 2016-10-27 09:34, Andrew Rybchenko: > Hi, > > we would like to include Solarflare libefx-based PMD in the DPDK 17.02 > and start the upstreaming process. > The driver supports Solarflare SFN7xxx and SFN8xxx families of 10/40 > Gbps adapters. > The driver has base driver. It is just fresh version of the same code > which is used in the FreeBSD [1], illumos [2] and some other Solarflare > drivers. Unfortunately it is common to have some big base drivers in DPDK. Note that some PMD rely on their kernel counterpart for the control path. It is a way to avoid code duplication. As far as I understand, it is easier to share queues with DPDK from kernel when the device supports an IOMMU. > The question is how to submit the base driver which is pretty big. Mail > size of the patch which imports it is about 2 Mb. First answer is a question: Have you thought about cooperating with the kernel driver for your PMD? If you really cannot use this approach, then we have to maintain this whole base driver in DPDK. It will be easier to read, understand and reference if it is a bit split. Could you try to send it as 10 to 20 patches explaining the role of each part and giving some design details? It would be also really appreciated to provide a design documentation in doc/guides/nics. Are the datasheets open? A link in the doc would help. > Further changes in the base driver will go in small patches (as it is > done, for example, in the FreeBSD). > The PMD itself is split into small and, I hope, readable and nice patches. Good to know. Thanks Please be prepare to work on several iterations of the patch series. PS: the mailing list put emails exceeding 300KB into a moderation queue.