From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01BB4A00E6 for ; Tue, 6 Aug 2019 11:00:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C47E51BE00; Tue, 6 Aug 2019 11:00:45 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BCE391B94E for ; Tue, 6 Aug 2019 11:00:44 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DAF734C0075; Tue, 6 Aug 2019 09:00:42 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 6 Aug 2019 10:00:35 +0100 To: , , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit CC: References: <20190806080206.1572-1-pbhagavatula@marvell.com> <20190806080206.1572-2-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <798d0b07-9196-2b60-b395-ac5f01c391d7@solarflare.com> Date: Tue, 6 Aug 2019 12:00:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190806080206.1572-2-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24824.003 X-TM-AS-Result: No-0.431900-8.000000-10 X-TMASE-MatchedRID: hls5oAVArl/4ECMHJTM/ufZvT2zYoYOwC/ExpXrHizw/axbZ2VgIHyJu i5ct81NNyEreRoSqMUMzbxRNgA4zXT09o8PhVkSdGUlF/M3Dxp8Hgh3sKJBzPySCvYM0up4/ZqP UmFS9eEYIOCWL/epVC3MqLmx/Omp148rH3GKAJmFTLFbi+a8u3bfHCp+e+coeQW6eCaGxKwIs5A o6EJ4a3LPIKjrFoGoyORUHw6Zsak+uNpYhT6CV5BbwCXv1ucAPy5Yp8qPpFQ8Okn+1ThwrObtHj u5e4mSshatdeffAgJU4umjFnGJ5X0faDvJitufvngIgpj8eDcByZ8zcONpAscRB0bsfrpPInxMy eYT53RnT+4jZiCT5CClUjci8tCV/h/td8IH/K008lQ170UGCBZNzIZWr8xtM8Y59FHk/yOTtuun IKbd3vOMPtYUEv05F86m+7F3rgUfUNewp4E2/TgSpmVYGQlZ3sxk1kV1Ja8cbbCVMcs1jUlZca9 RSYo/b X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.431900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24824.003 X-MDID: 1565082044-xeMKpFp0AIjZ Subject: Re: [dpdk-dev] [RFC 1/3] ethdev: add ptype as an Rx offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/6/19 11:02 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add ptype to DEV_RX_OFFLOAD_* flags which can be used to enable/disable > packet type parsing. > > Signed-off-by: Pavan Nikhilesh I like the idea. I think there are few more Rx features which lack Rx offload bit:  - delivery of RSS hash in mbuf (it is not always required when    RSS is used to distribute packets across Rx queues)  - maybe Rx mark, since it is an extra information which could    be passed by NIC to CPU and it is better to know in advance    at Rx queue setup if it should be requested and processed API breakage should be considered here. I think it is OK to introduce it in the next release cycle in a dummy way which does not affect packet type delivery for existing PMDs (i.e. add offload capability and advertise in PMD, but do not take it into account when Rx mbuf is filled in) and submit deprecation notice that it may be taken into account by PMDs in 20.02 to avoid packet type delivery if the offload is not requested. It will allow applications to make transition smoother. Acked-by: Andrew Rybchenko