From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 992A21B84E
 for <dev@dpdk.org>; Thu,  1 Feb 2018 03:07:50 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 383A720D3E;
 Wed, 31 Jan 2018 21:07:50 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 31 Jan 2018 21:07:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=QV4aRs/E+vS76c8JmVCQnMu+NY
 ZN0KmrFvdWOuStTag=; b=s/XFmGVP80v1Gs91fP7LGmAUAdANzwqPlN1mPJTvTT
 N+MqD9Zyf2Xb1Esvqrfb52lKIK2owv4CwKUPOiVOrYwiYbpATQiZySB/Muca5Yfs
 aSh8I0wKw/zRCvX9A3e3s3ySWHWxhI4pkA+qLKNQPHyvqI9n1XY7GFnAj+mYs2gA
 o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=QV4aRs
 /E+vS76c8JmVCQnMu+NYZN0KmrFvdWOuStTag=; b=FHIPtevq9aO7tkqCoyYQ0K
 g33oJUeJE8WuIQ6C/joyEJSRVtph3rkwK1oalnaL/UUpQmxRGAjcOtlakZd4nwHa
 Ah9FOSvhvd7UFqFYznVCYvNSkIRm9EfQJe5CCf07LJsTgMawzBCYiHiFk3hvS9Oc
 MKFQJ1OYo7jWDd1Bma4FoMA+LS6ChMdY0R2OjsCxfPnOv7/td1mQOL9voMLA1PEX
 mMvhWrxo455HVi6hGlnbT5ehGPTMwLf5u7DTan/ygAObeu/Ra3Tgcd+aY2pt+O3g
 6CO7/o1oN7hbwcfbx7VnZMt5yWhDBukoJtdxNwYMLrs3QaTDwd706+qaebn5dyFw
 ==
X-ME-Sender: <xms:dnZyWnxUGwimc_Ai-gaJn8Kim1RzdeZ3KjRHHSuNBSKNLwjwrGTGOg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id DAE1C7E3FA;
 Wed, 31 Jan 2018 21:07:49 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Yanglong Wu <yanglong.wu@intel.com>
Cc: dev@dpdk.org, shahafs@mellanox.com, wenzhuo.lu@intel.com
Date: Thu, 01 Feb 2018 03:07:03 +0100
Message-ID: <7990034.yJyxX93kgV@xps>
In-Reply-To: <20180201012653.173890-1-yanglong.wu@intel.com>
References: <20180201012653.173890-1-yanglong.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Feb 2018 02:07:50 -0000

01/02/2018 02:26, Yanglong Wu:
> And-operartion with a constant will
> always lead to fail for vlan filter.
> 
> fix:0074d02fc(convert to new Rx offloads API)
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
[...]
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -2288,7 +2288,7 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on)
>  
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>  	dev = &rte_eth_devices[port_id];
> -	if (!(dev->data->dev_conf.rxmode.offloads &
> +	if (!(dev->data->dev_conf.rxmode.offloads ||
>  	      DEV_RX_OFFLOAD_VLAN_FILTER)) {
>  		RTE_PMD_DEBUG_TRACE("port %d: vlan-filtering disabled\n", port_id);
>  		return -ENOSYS;

This patch is wrong.

If you are trying to use VLAN filtering with testpmd,
you must enable it with --enable-hw-vlan-filter.