From: Thomas Monjalon <thomas@monjalon.net>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask
Date: Thu, 30 Jul 2020 23:18:28 +0200 [thread overview]
Message-ID: <799298755.pgPqx7ZCVa@thomas> (raw)
In-Reply-To: <20200605134114.23149-1-sarosh.arif@emumba.com>
05/06/2020 15:41, Sarosh Arif:
> Giving invalid or zero portmask as command line option to
> packet_ordering application will have an unexpected response.
> The reason behind this is that parse_portmask's return value is
> stored in a variable called portmask.The data type of portmask
> is unsigned int, hence returning -1 in case of zero or invalid
> portmask causes an unexpected behaviour.
> If we return 0 instead of -1 this issue can be resolved.
> The program already contains the functionality to print
> "invalid portmask" and program usage if portmask is zero.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
Merged with same fix for other examples, thanks.
prev parent reply other threads:[~2020-07-30 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 13:41 Sarosh Arif
2020-07-30 21:18 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799298755.pgPqx7ZCVa@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=sarosh.arif@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).