From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DA17A0C4D; Fri, 13 Aug 2021 10:42:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7EEA40151; Fri, 13 Aug 2021 10:42:24 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C7CF840140 for ; Fri, 13 Aug 2021 10:42:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="212413812" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="212413812" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 01:42:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="440316774" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 13 Aug 2021 01:42:21 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 13 Aug 2021 01:42:20 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 01:42:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 01:42:20 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 01:42:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wpo/W6GaqO8LswmMHEZ2LlSCy/UGvCGHwySIyYfgYo19IFYyjYRmXBJjdgGduqAfY3CmPPQj8B/ZafeJcM12r+NeIZYrFE58WibtAb2RJBjDcKwuhhA56VVAe34sbZffo32J3nb7C2C79H6wsAvj3C0E/HeBlkXmn7t6RUbwYImeovguio4OhdUsgGYbEDzkJF6pykFdbaS7uVEVTz/orWixEBSdkA7WgNwLlDzmP3lErtRhl8Wlfw9F2oZkQVx5spDiDDnEnHvdlCJXPbiBWhsSU8RVl6BFvueh/5hTQyZ81cvmgKjjINw1NdA3861jVLPLSqpuEMEL+ljXPZGI1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bknPVeJruFUue4FJdoO/ppssCoHHF9yrrj0P6lmH9dI=; b=bJ/c8ZebbEZneH0hCRoUNbmf1P3oBdSZLYnMOPO8Q+h35CQLV5Ch2NVwV9sUi7M0/ExMkh3nZCyCc/Fbn1V1xWbvdX95YJOk2uqcp5WQNcNathsEPge6zMFUIZqCw6l5v8V2IVRIkP8jPj68E0mpQPOuPGr8p7cEoDSIMhV59l6mja/v2KtxjlmDcRP4dCfq2nKLggp1kGORUYTV9C9dr9HIPNms/+/3Nz3Xb1b7NQ6aSiNHhrbBdUtYbWbLIITbdKqOelCsyKpt0pW36b/CFlmUzBFQBGMrZYY+SfzGa055LLDLUqXzAo3hvx7Ldxrd1qX4XKByQfBOBjRUy6D4xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bknPVeJruFUue4FJdoO/ppssCoHHF9yrrj0P6lmH9dI=; b=WqqhTrTlKwCPEMdEhfvmld4qeZgel0NNXWiOpz3ZWZ1Ihn1QZdtkwN2bBsNggCTEEA8x0Bmy/L25JncTtiH4ctDAE18Mnw9wdfvb60cIUKqtCFYXAWQ2whdBSYhSd0ecCVSkaJTF2Kb/LvUH4YEhp3WoLSLdgN+NokbSPkfvE4k= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5142.namprd11.prod.outlook.com (2603:10b6:510:39::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Fri, 13 Aug 2021 08:42:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 08:42:18 +0000 To: Rohit Raj CC: "dev@dpdk.org" , Nipun Gupta , "Hemant Agrawal" , Sachin Saxena , Vanshika Shukla References: From: Ferruh Yigit X-User: ferruhy Message-ID: <79974313-19d2-2d57-636f-669341172b1f@intel.com> Date: Fri, 13 Aug 2021 09:42:09 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: ZR0P278CA0133.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by ZR0P278CA0133.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16 via Frontend Transport; Fri, 13 Aug 2021 08:42:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aee7811-5fd1-4ef9-80f6-08d95e364249 X-MS-TrafficTypeDiagnostic: PH0PR11MB5142: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1824; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eK6f4a+ZkwDOeXMFCJHgoPfhEOCW1Io2Nc3rxNMrAkVcMdEl804pGB+xmK6Um4r0F1G76pWWfkWqKtxgiQ4GCZGk5JSo2jVA7lrG5s2tMTdcWKFtW1uG0kr2Pr/panLxUWv6TLVeTRuqLntdsuJ1/Qz8A8wi3NFRWMC7wiaMD5RVvq/HU7jYbDnYiRRFyH9w1Q/pET+ZpyRarCD3ef6SYYQ7qynzlGmSjm/F8kGjBSnfiHdGvx+EmJDAV3ORN05QrE9Aqr4dQwLz3C3eaxDaKFn8uF7tBtSwzGwJUX1hPKYIm7khKFm0XTPPLJxxbJJXR87sWdgnUDN873NhJEPZAQVE9+q8Og03nweYy0TCmYGFgMMUIwmZTImMaxsYhNksfiwi/PriQVqvWIZpqT5Ldul5wTA3RDC8jIK1MvR5tblznrY0KQzxsKzuJqUl1rpxqwS42Mpu7dF78Gdz4e/pE+5EhsU2PPvhCohpEB2v0GDwE2v8udXjwcvgt6NcspAfAN8IFmbf4mkWIU2P5579vJe30aE1NWSMdbL5hM8dY8PmJHh9BwqECHEKpefP/vGTxfkT24TRZdHHSnDfJAY6U7QhayWIoai62LfAbg1SYKKwfvngrm/5h//SgHKaLsqLdmOWAgQ7McN2HWbbz5HifmlUL6z1sa9/2A1xfzoAHkitdK9fkgwfbtDrqeZSyTJtOC2SuowMnCbvhX8TfnG88SFe92extw6kLzZbc6YrjiQs3ACEKGP3ZhjcHf/mZ6Lot1H3i95ys187/oCFXgz+Ak91c//VnyVYVpYGQS3foaaKX42Dshzl+YENdjCRItLFVcUzf7Hiy7zerHXGB2Fn5w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(136003)(39860400002)(5660300002)(31686004)(16576012)(54906003)(966005)(316002)(83380400001)(478600001)(53546011)(6916009)(6666004)(66476007)(66556008)(956004)(2616005)(8936002)(38100700002)(86362001)(8676002)(4326008)(66946007)(6486002)(26005)(36756003)(2906002)(31696002)(44832011)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUNGcm1RZnIrNTZUUmJON3NKT3gyUktOa3JBMFZuVklqVmZTb3VaZkRKWlEx?= =?utf-8?B?ZmM5SHdEcnlOU2VJQXppMHBMbzRCZ21XQXJHeHRBMkRvNFN1MnVuL2had1Nw?= =?utf-8?B?V2lWT2pqOFFUNkJWVEJYUmZ6WXl2dlppVjUxUWdzOS91NjZXNVg1dVEwMHE0?= =?utf-8?B?L2ZvRWQrcVdJUzVPKzJqaHd6M0hneCtSQTFPVFJXZ0ZnVXpOQnZFa1lSTHQ0?= =?utf-8?B?RnNFUkhESTMrWWpLUS81SkxJWFlSMFJpcXVXWWd4ME1nOHA1Uk5VUEVWWmJY?= =?utf-8?B?OXZ4Y3RURDgvOHY4Z1RLSVJ5NjYrSVRIanpnaHVCckZEeUlDeXNrSWpSbzFl?= =?utf-8?B?bE40VHBBWWpmZklENk9jekVQdnVWdFJJdkFyNnIvTmc1bHJmbjJINmxqTzdz?= =?utf-8?B?WVFXNnhrRnU0Mm5Dc29RYWcyOTY3em05NFBFZzhBRGo2Z1ZmNndNRVduYTVQ?= =?utf-8?B?NTN0bjlRSU4xSVU0b3BwN2xDOUlwNGNMUHZGRzZrZWJycDVSM2xFM0pTQmZU?= =?utf-8?B?NnU4NXZRdU5OZWFyT1IrMnFkVjRZNGxsVWZ3eStuOXN4RjNCblRGL1Iyc0Y2?= =?utf-8?B?VEh2R241REZzNGF4OGFqUFdRSkszMHB4TC9iR2hleWZ6QzQ4Yk5MZnR5K3d5?= =?utf-8?B?YXpyaFdUMXByQUFhQjRmaHREOG9pWkh4YmliOSsxYkhSWGFZM3FPNTljVitE?= =?utf-8?B?dGNSVkhCQ3NydlJsNTc1VHZQbTNRY01KamVSRnUxVHBKU3ludHVySUtvV29n?= =?utf-8?B?bFVRYzYxWnB4cHRJejJ0TTR0aTlIelJWS211SXJOZ1NGaXBmWUtOaXBqUkVP?= =?utf-8?B?d0RJb0dKdVl4T2NvK1dPczlVZXllNHNtN3ZwT1ZGdTB0ak1LOThCLzl6Rmg5?= =?utf-8?B?azlUYXlYWUEzaTFaa3VBRUdmVTRPU2RhNHllcUtGYXJnblIzYTF5L2ZpYnM1?= =?utf-8?B?VXA4N2VOcWp5RDBoV1p2OEl1Um5KMW9BSEMzRU9MMU5mUXpXWGhsMWsrblly?= =?utf-8?B?cHBYNGttdVVUaTZwZmhKU2RIWStXSXhJRzV6T1pJNWM2ZzJ3R2ZNMUdmOHV1?= =?utf-8?B?Z0REaFdCbXZrdE5naGQ0b1MrUlFGNHlKUHplS0w5ZlVJeGhlT2JTSUpLMzR6?= =?utf-8?B?THlvSldDaE5ZL0JUaUtaU1o5NzA5cllsZ2hBMWNUVWdOSlFidEdWOE1EN016?= =?utf-8?B?aFNqY2cxWmh2NHRLbTh2bzR6VlFJclI2VWltTVM0WFB5REgrUWFYc1gwako0?= =?utf-8?B?U2pPTXZIcFByYklSMTdYSUExekM1Q3ptQjVVS1NWR0kzeHB1d0g4YmVTSlFV?= =?utf-8?B?ZEJRcmpuU2E4b3NwNmZnWVZJbStUKzZWRDBIckwwV2NpNDcvWWs1WVBxQk1y?= =?utf-8?B?YmhWNDJWNTJNRFY1Z0N0cXUzNGo3VGQ1LzlOejZFcEQzWUdsbkdjRU82Q1ZG?= =?utf-8?B?ZVpQNi92WmlaODVDeGpMK2RvcnBFOWlDbWFGYlBMMjRkbzlxTFJHOUhMNjZL?= =?utf-8?B?WEMzN0VTalYxMUNpK05JbTBPWk5lVGFaWGhsWm1oa2IvSUV1S0o1Ti9Ya2xF?= =?utf-8?B?RDUvVngveFF2WEd4Vi85amFiVHVjcEN6UU5VZEExdStRdDdWR2JKRFVyeDNr?= =?utf-8?B?WXZxWXA2RThIU01rQ3hiOG5pbW1QNEZ4TlZDRmZGZG5FYWllSTZaRjVJQ0RN?= =?utf-8?B?WkhDMWZpVkhRZGoxeXVaSGc5V0xXYXowd0FLQUFaQWZDSmxkdExxYVYycjFG?= =?utf-8?Q?fxbJu0Cgnsd0aYHgM0s0exSM62CY+XaVkQNPBIq?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6aee7811-5fd1-4ef9-80f6-08d95e364249 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 08:42:18.4193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wNlxrnH7rwIVm3TCQlbJQVXPtgXl2pKMX6pzUKsiEML9UrLc1hUXEjwVnX/O30/T0kJSO+TadQ5UNsl80F3x1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5142 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/13/2021 5:48 AM, Rohit Raj wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, August 11, 2021 5:01 PM >> To: Rohit Raj >> Cc: dev@dpdk.org; Nipun Gupta ; Hemant Agrawal >> ; Sachin Saxena ; >> Vanshika Shukla >> Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop >> issue >> >> On 7/27/2021 10:25 AM, rohit.raj@nxp.com wrote: >>> From: Rohit Raj >>> >>> l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is >>> not able to store packets with size greater than 2KB, hence these >>> packets are dropped. >>> >>> This patch fixes this issue by enabling scatter for jumbo packet, if >>> it is supported by NIC. >>> >>> If scatter is not supported by NIC and max jumbo packet length is >>> greater than default mbuf data size, then application exits with >>> proper error message. >>> >>> Fixes: f68aad7904f ("examples/l3fwd: update") >>> >>> Signed-off-by: Rohit Raj >>> Signed-off-by: Sachin Saxena >>> Signed-off-by: Vanshika Shukla >>> --- >>> examples/l3fwd/main.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index >>> 4cb800aa15..6aaaa8ecb5 100644 >>> --- a/examples/l3fwd/main.c >>> +++ b/examples/l3fwd/main.c >>> @@ -1035,6 +1035,20 @@ l3fwd_poll_resource_setup(void) >>> "Error during getting device (port %u) info: %s\n", >>> portid, strerror(-ret)); >>> >>> + /* Enable Receive side SCATTER, if supported by NIC, >>> + * when jumbo packet is enabled. >>> + */ >>> + if (local_port_conf.rxmode.offloads & >>> + DEV_RX_OFFLOAD_JUMBO_FRAME){ >>> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER) >>> + local_port_conf.rxmode.offloads |= >>> + DEV_RX_OFFLOAD_SCATTER; >>> + else if (local_port_conf.rxmode.max_rx_pkt_len > >>> + RTE_MBUF_DEFAULT_DATAROOM) >>> + rte_exit(EXIT_FAILURE, >>> + "Max packet length greater than >>> + default MBUF size\n"); >> >> This is a configuration set by application. So application is failing itself because >> of configuration it sets, seems odd. >> >> I guess the jumbo frame can be enabled when user provides '--enable-jumbo' >> argument. What do you think adding above check where that argument is >> parsed. > > We need to check if hardware supports Rx scatter. To do this, we need to get Rx > capability. Hence, this is a better place to perform this check. > Got it. There is already a patch [1] that I am trying to update the 'max_rx_pkt_len' usage and remove OFFLOAD_JUMBO_FRAME flag [2] etc.. Those touch to the same piece of code, can you please check them? After those patches, your update can be put into 'config_port_max_pkt_len()' I think. Can you be OK to wait them to merged first and make you patch on top of it? [1] https://patches.dpdk.org/project/dpdk/patch/20210722172113.3236450-1-ferruh.yigit@intel.com/ [2] https://patches.dpdk.org/project/dpdk/patch/20210722172113.3236450-4-ferruh.yigit@intel.com/ >> >> Btw, no need to enable scattered Rx if the packets fits into buffer, so above >> check can be done slightly different: >> >> if (max_rx_pkt_len > buffer_size) >> if (OFFLOAD_SCATTER supported) >> enable OFFLOAD_SCATTER >> else >> fail > > Agreed. I will do this in next version of the patch. > >> >> >>> + } >>> + >>> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) >>> local_port_conf.txmode.offloads |= >>> DEV_TX_OFFLOAD_MBUF_FAST_FREE; >>> >