From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rami Rosen <roszenrami@gmail.com>, Saleh Alsouqi <salehals@mellanox.com>
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, dev@dpdk.org,
Ori Kam <orika@mellanox.com>,
stable@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and ihl
Date: Tue, 8 Jan 2019 14:38:10 +0000 [thread overview]
Message-ID: <79a7891f-94fe-a899-f18f-79a8e0d743d6@intel.com> (raw)
In-Reply-To: <CAKoUArnYfH3q8Mm0zSGVbyAtpe2Yhn_W1O1dVDJ6UJF1mhAmrw@mail.gmail.com>
On 12/25/2018 7:29 PM, Rami Rosen wrote:
> Hi Saleh,
> Thanks for your patch.
> If you will grep into the DPDK repo you will see that there are several
> occurrences of IP_VHL_DEF, with the same functionality.
> I would consider putting the IPV4_VHL_DEF you added in a more generic
> location and not
> under testpmd, so other modules will be able to use it without the need to
> include testpmd.h, which is a bit awkard.
> Another question is whether it should be IPV4_VHL_DEF or IPV_VHL_DEF as in
> other DPDK apps. Probably other apps should be adjusted to use it.
+1.
Why not put IPV4_VERSION (IPV6_VERSION), IPV4_DEFAULT_HDRLEN & IPV4_VHL_DEF to
'librte_net/rte_ip.h' and update libs/apps to use them? cc'ed Olivier.
And instead of defining ourselves, which we are trying to get rid of, is there
any system ones that we can re-use?
>
> Regards,
> Rami Rosen
>
next prev parent reply other threads:[~2019-01-08 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 12:36 Saleh Alsouqi
2018-12-25 19:29 ` Rami Rosen
2019-01-08 14:38 ` Ferruh Yigit [this message]
2019-03-25 13:01 ` [dpdk-dev] [PATCH v2] " Saleh Alsouqi
2019-03-25 13:01 ` Saleh Alsouqi
2019-03-25 13:30 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-25 13:30 ` Ferruh Yigit
2019-04-16 9:59 ` Ferruh Yigit
2019-04-16 9:59 ` Ferruh Yigit
2019-04-16 10:02 ` Ferruh Yigit
2019-04-16 10:02 ` Ferruh Yigit
2019-07-02 13:33 ` Yigit, Ferruh
2019-07-04 7:33 ` [dpdk-dev] [PATCH v3 0/2] define ipv4 ihl and vhl Saleh Alsouqi
2019-07-04 7:33 ` [dpdk-dev] [PATCH v3 1/2] librte_net/rte_ip: " Saleh Alsouqi
2019-07-04 7:33 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix mpls ipv4 encap fields Saleh Alsouqi
2019-07-04 16:19 ` [dpdk-dev] [dpdk-stable] [PATCH v3 0/2] define ipv4 ihl and vhl Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a7891f-94fe-a899-f18f-79a8e0d743d6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=orika@mellanox.com \
--cc=roszenrami@gmail.com \
--cc=salehals@mellanox.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).