From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com
Subject: Re: [PATCH v2 01/24] net/nfp: add the stats process logic in ctrl VNIC service
Date: Mon, 10 Oct 2022 15:48:43 +0100 [thread overview]
Message-ID: <79e92e9b-6642-b3c4-40bd-26d04c7b1ea9@amd.com> (raw)
In-Reply-To: <1665382142-21684-2-git-send-email-chaoyong.he@corigine.com>
On 10/10/2022 7:08 AM, Chaoyong He wrote:
> Add the flow stats process logic in the ctrl VNIC service.
> The flower firmware pass the flow stats to nfp driver through
> control message, we store them in the flow_priv structure.
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
<...>
> +static void
> +nfp_flower_cmsg_rx_stats(struct nfp_flow_priv *flow_priv,
> + struct rte_mbuf *mbuf)
> +{
> + char *msg;
> + uint16_t i;
> + uint16_t count;
> + uint16_t msg_len;
> + uint32_t ctx_id;
> + struct nfp_flower_stats_frame *stats;
> +
> + msg = rte_pktmbuf_mtod(mbuf, char *) + NFP_FLOWER_CMSG_HLEN;
> + msg_len = mbuf->data_len - NFP_FLOWER_CMSG_HLEN;
> + count = msg_len / sizeof(struct nfp_flower_stats_frame);
> +
> + rte_spinlock_lock(&flow_priv->stats_lock);
> + for (i = 0; i < count; i++) {
> + stats = (struct nfp_flower_stats_frame *)msg + i;
> + ctx_id = rte_be_to_cpu_32(stats->stats_con_id);
> + flow_priv->stats[ctx_id].pkts += rte_be_to_cpu_32(stats->pkt_count);
> + flow_priv->stats[ctx_id].bytes += rte_be_to_cpu_64(stats->byte_count);
Like below comment, 'stats' is a pointer and I don't see any code that
allocates memory that this pointer points, at this stage it has invalid
value and above code will crash.
I assume that memory allocation is in next patch, in that case this
patch should come after it.
<...>
> void
> nfp_flower_ctrl_vnic_poll(struct nfp_app_fw_flower *app_fw_flower)
> {
> - uint16_t i;
> uint16_t count;
> struct nfp_net_rxq *rxq;
> struct nfp_net_hw *ctrl_hw;
> @@ -242,9 +308,8 @@
> count = nfp_flower_ctrl_vnic_recv(rxq, pkts_burst, MAX_PKT_BURST);
> if (count != 0) {
> app_fw_flower->ctrl_vnic_rx_count += count;
> - /* Process cmsgs here, only free for now */
> - for (i = 0; i < count; i++)
> - rte_pktmbuf_free(pkts_burst[i]);
> + /* Process cmsgs here */
> + nfp_flower_cmsg_rx(app_fw_flower->flow_priv, pkts_burst, count);
At this point, as far as I can see, 'app_fw_flower->flow_priv' is not
pointing to any allocated memory, so it is an invalid pointer.
next prev parent reply other threads:[~2022-10-10 14:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 6:08 [PATCH v2 00/24] add the basic rte_flow offload support of nfp PMD Chaoyong He
2022-10-10 6:08 ` [PATCH v2 01/24] net/nfp: add the stats process logic in ctrl VNIC service Chaoyong He
2022-10-10 14:48 ` Ferruh Yigit [this message]
2022-10-10 6:08 ` [PATCH v2 02/24] net/nfp: add the structures and functions for flow offload Chaoyong He
2022-10-10 14:49 ` Ferruh Yigit
2022-10-19 2:50 ` Chaoyong He
2022-10-19 10:48 ` Ferruh Yigit
2022-10-10 6:08 ` [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD Chaoyong He
2022-10-10 14:51 ` Ferruh Yigit
2022-10-19 3:00 ` Chaoyong He
2022-10-19 11:11 ` Ferruh Yigit
2022-10-19 11:30 ` Chaoyong He
2022-10-19 11:38 ` Ferruh Yigit
2022-10-10 6:08 ` [PATCH v2 04/24] net/nfp: add the offload support of basic items Chaoyong He
2022-10-10 6:08 ` [PATCH v2 05/24] net/nfp: add the offload support of basic actions Chaoyong He
2022-10-10 14:52 ` Ferruh Yigit
2022-10-19 11:32 ` Chaoyong He
2022-10-10 6:08 ` [PATCH v2 06/24] net/nfp: add the offload support of VLAN item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 07/24] net/nfp: add the offload support of IPv4 item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 08/24] net/nfp: add the offload support of IPv6 item Chaoyong He
2022-10-10 14:53 ` Ferruh Yigit
2022-10-19 11:33 ` Chaoyong He
2022-10-10 6:08 ` [PATCH v2 09/24] net/nfp: add the offload support of TCP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 10/24] net/nfp: add the offload support of UDP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 11/24] net/nfp: add the offload support of SCTP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 12/24] net/nfp: add the offload support of set SRC MAC action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 13/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 14/24] net/nfp: add the offload support of pop VLAN action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 15/24] net/nfp: add the offload support of push " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 16/24] net/nfp: add the offload support of set SRC IPv4 action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 17/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 18/24] net/nfp: add the offload support of set SRC IPv6 action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 19/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 20/24] net/nfp: add the offload support of set TP SRC port action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 21/24] net/nfp: add the offload support of set TP DST " Chaoyong He
2022-10-10 6:09 ` [PATCH v2 22/24] net/nfp: add the offload support of set TTL action Chaoyong He
2022-10-10 6:09 ` [PATCH v2 23/24] net/nfp: add the offload support of set IPv4 DSCP action Chaoyong He
2022-10-10 6:09 ` [PATCH v2 24/24] net/nfp: add the offload support of set IPv6 " Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79e92e9b-6642-b3c4-40bd-26d04c7b1ea9@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).