From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B38EA0C54; Fri, 3 Sep 2021 17:37:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1502F410D7; Fri, 3 Sep 2021 17:37:05 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 98641410D7 for <dev@dpdk.org>; Fri, 3 Sep 2021 17:37:03 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10096"; a="219464065" X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="219464065" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 08:37:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="447640851" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 03 Sep 2021 08:37:02 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 08:37:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 3 Sep 2021 08:37:01 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 3 Sep 2021 08:36:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njzcK7I6oIFiRfZZ1svRDKuUsIEtjOcc7ooYt356J+1L+39L2sgC5R0meyOycBvOERz1+Z33F2+nQhf2GwC622rRwh8vFnpa5RQYgLt0sfZDcOQ4qZa237BUoIsa/OaF9lyQPE8wacJ8BdVg/3judncuQgeRno7bcz1NGBpQlMQiv1bpGAB55rRAHwP87r/QiidynWMVfUz7kLw15kLUX2m7eRTodJRufQs6ckeQUuDBB+Oq52lwDy9hMqp0exnpdHVbz0/th4BYI+Hs6m49LxvMr0WralziC9W1OKJdlOTYyT2r3wArnCTEIzHTIOwl41gOHXzPwqzoyTdSXFQapw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GCFmO69Nn76JAtCaWQ7shBIzo0f3Br7IKFrsQKiw1lI=; b=f5bq/UPk1OY678tKmuq2JMBN2937KFfgZ/njzh3wJrtIzlx62pch7y+ej7NUeNnk4ncOk5MnUQvkGPNv8k7rbPIZ84ZeE2b+MY+If6DhCH1uhyWkY6i0+uuGPu3jyAIEDW1rf8QGqldHWeRCy3chTVIxsN2RY4wxY9x+j4+O+D2y03AzjERjhEXhlO2rJzlk5Tz88Xp+4Ff7vGbL0xSQTGBYzBj5zWDWRteIK6sSs+yowy1b1JaCsanMtwNBpohkLB5zgCTtMgTff6tXpLdw+TvrZB+f2AdbIBfVLhNmRQN1iPNyR9M2s9ilp8o87dzYuKjRE2WKC9C6W/vEwKrT5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GCFmO69Nn76JAtCaWQ7shBIzo0f3Br7IKFrsQKiw1lI=; b=RTZdlkG5GZeEMVXR/Ensf/icfUfrrazwGwkrwNUaKjatAtPhhT/G0M29oxw7Q8dZlfvJM6ZEXcjM8qATP3f//XsihEeKREUn58n4erd43Db5HLocnWWNcEEGdmXTmhNfCwL83a2E26aLEba5VEVF7yTf8lwnmx++H8DbFHi8mas= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5157.namprd11.prod.outlook.com (2603:10b6:510:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Fri, 3 Sep 2021 15:36:21 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a%6]) with mapi id 15.20.4478.023; Fri, 3 Sep 2021 15:36:21 +0000 To: Chengwen Feng <fengchengwen@huawei.com>, <thomas@monjalon.net>, <ferruh.yigit@intel.com>, <bruce.richardson@intel.com>, <jerinj@marvell.com>, <jerinjacobk@gmail.com>, <andrew.rybchenko@oktetlabs.ru> CC: <dev@dpdk.org>, <mb@smartsharesystems.com>, <nipun.gupta@nxp.com>, <hemant.agrawal@nxp.com>, <maxime.coquelin@redhat.com>, <honnappa.nagarahalli@arm.com>, <david.marchand@redhat.com>, <sburla@marvell.com>, <pkapoor@marvell.com>, <konstantin.ananyev@intel.com> References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1630588395-2804-1-git-send-email-fengchengwen@huawei.com> <1630588395-2804-7-git-send-email-fengchengwen@huawei.com> From: Conor Walsh <conor.walsh@intel.com> Message-ID: <79efa477-4d60-4aec-3613-3c4518a0d300@intel.com> Date: Fri, 3 Sep 2021 16:36:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <1630588395-2804-7-git-send-email-fengchengwen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DB6PR1001CA0046.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::32) To PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) MIME-Version: 1.0 Received: from [192.168.1.20] (109.79.134.22) by DB6PR1001CA0046.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 15:36:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dabe8191-e50b-4a44-a3ab-08d96ef094bc X-MS-TrafficTypeDiagnostic: PH0PR11MB5157: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <PH0PR11MB5157A531543A2E7F602E6940FFCF9@PH0PR11MB5157.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Eu2SKgF49VROP02zWNV8YyCeaMM45V8GhtF7TzjA8qkyW1nvtz3ETgNe9XYkS4v9gvPZiIJgM3v/Vse2e5T7q8hBKdr3fPqTk19GL78YNLTOH1HIa7HrveCCcFeVPFYZygFgk4bQ9Uv1NRBOMe2/tUsxsGEbWKw2Ot14Oxfd8YvALVKkgZrVA2weSu2TV6YcewUvqP+PDbLd89aRyEEGCDhMJjVgEFSYi/urmdc/KcCIeIHx4nrodoTQQ9s4LlG72b6R8m0CnmTlI2EBbBH1UvWZHYowwCU+0LHWz4FRa6ziMZ79ckudS/CsPgb2PVn2ZpJL2cq1DfkO/PO7JnIInYrDNAklOM85rGB2pYWopbRrjsmbf32hM1ly9V7K3WcedMhVpsAh5tZ7e+dcdisMgyfcovJQ2nWYI6XOKQGxWPzW47PlveezgQ7pZ/NDGtU2YG3R0uhGPlcD4v+7OxG5wXd2zUQd2U6EAojSsziTuh0UyHsYGx1SbKLaKSaVjCbrTxvJFvGSUNXs3B6e8UpWWEWyBudW4qvxtcLzLVE6iSDcrdlPLPlCXVZspUqslzoNcuQYz88zIbhjc4xAMabC2R2QWG1X0ooVsoB4xZ2D57LCIeX0KRvJc5PYL3RPm0MwAhty+9JOnKgB2YPlFE8vhmYIm5ZCdwSUi202GGkz5xl7SdLHaerjRMMzRecO7YFsEe5Qvh5/iN5ZsDy1ZnNNlJaqgw0BM4uqKnZy1jcRMec= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(5660300002)(6486002)(36756003)(66476007)(66556008)(2616005)(8676002)(4326008)(44832011)(8936002)(316002)(478600001)(6666004)(107886003)(7416002)(31696002)(26005)(956004)(186003)(66946007)(2906002)(16576012)(4744005)(31686004)(38100700002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blBucnd5ZlhaZG1LRU1saERkeDFGbjl4VXRMWkNCdk8zV0cvcmFnSlVzOVRn?= =?utf-8?B?VXVNNHJBQnJJek9BK211NlQwWHBnZS9XZG51a2lCVy9rOHp2eDlFcVdmREI5?= =?utf-8?B?OWdnZzF4NTJWZ1pnWk5RZU1nVWRyT1VoSmJnT0lvYk9vYlNwZ05hRU5ucTFV?= =?utf-8?B?bUYrSmlwVCthSGY5TUNzWk12WlhZbG0wNllRWVhEY3BLSThTdUxyMHRWeGZs?= =?utf-8?B?R1hwR2dJWE5nb3NvcGhtTUI4UGZyWXFaQ21MZDN5Z3lCVWJlcW1uQ25zeVVW?= =?utf-8?B?SmVoVlhsaW41bGlrd0ovWGVSOEQ5blkxejhHR0tsZGVKRTZMTzdleXlrUFJM?= =?utf-8?B?VDhRUmxWN3dNSm1DVHVvV0hGdVozcWZIT2ZkVElKQjM2WHFUV3VJWS9ZVlo1?= =?utf-8?B?dCt2cVpVOFU0Ry9jdVJqSm5iVGZzc0lFVkhTeWRUdFVHV0RlMmEvSDJ1WFRR?= =?utf-8?B?RGxsa2tHdkhCYWtNZTREOWh1dGpUeTBick9pTE8vaWJJTDdnMndFVXBXdjEz?= =?utf-8?B?emY4YTBmWk1SbGp0R1RsYjR2MjgzbktGODZzMjIzSkxDOUg1Q3I5dFlwcUYz?= =?utf-8?B?WnY1Yno1TGhhd0E0elhtUlZ2WlZGSXk4TDlxb3dLN0RiV3dMRTlyY2N0dTN5?= =?utf-8?B?Y0Y0ZlNzL2V2dmRkZTNTZHloeDN6MmhTNUJwU1YrSjFWU1A1QkYycTZ5c1dL?= =?utf-8?B?Wjd1U1IvSkViUmlxTDY0TXVqSkdrSFNJcFFieTRadDVRWlRzNHl3YlFISGxn?= =?utf-8?B?OWlpd250ZytydXR0WThZcjhZR3ZyRk1JOElUc1dvQWR1OEFrWnI5VDUzZVFl?= =?utf-8?B?cnJINVZCaHI3S1ZVbnc3ZUpwREpuTDhGNElHVDNsYm1xU3lZL2d5MjY1aGhX?= =?utf-8?B?TmN5RlFsaWFaUGlQeTB4L2Qwd3REZ2N2T2hpUStPSTRrQXNEU2prMDl3dVRF?= =?utf-8?B?eHRmejV4YTlvZUd2U0Q3UTJuYVZ5Y1VaazdGUTlXSkhJL01rWE1rd0JCQVJJ?= =?utf-8?B?VWpNYlpQS3dTREdzSWVVNEpDN1F6emsxTndTUWFlL2NpcHpCZ2VoQkN4TVNu?= =?utf-8?B?Q2JQbS9TaGVXUVc0RDJrYjhWTzc1Q2tRMkpWZ1ZpVmtyZjZuQWp4QlVUTG5N?= =?utf-8?B?V3ZDVHo2STlURWk5aTk0dkJpaXBkOTZ1aGdjQkZ3dG4rb0JNbEEvQ2V2dTZ4?= =?utf-8?B?STNteWRabk9pcHMvQjI4UWtTbDB5TkV5YmFVT0Z4SzlIU0pKV0JxTW1KYkRh?= =?utf-8?B?YlZVWmMrQnRYVlRJVUlsc1ZCNmJUYW1OcnpMUHV4TEV4S2pVK2x2cjl0Q09P?= =?utf-8?B?djlRVXo3cXUzVm9YS2Zyd1BKRFE1azlLMGp3OFNndmxWZFV1aFN0dlFsblkv?= =?utf-8?B?ZGhaWUFTYmtPczZuNTVXVzJ4WW9pcnBmayt4Z203aE4wYVpnSjNoNXBYdzRU?= =?utf-8?B?UjFCTkFycnVqSlg2NllKajNhQ2Z5TzZ6eFlBdGU2c1BlbmIzWldKUGphUXJO?= =?utf-8?B?d0IxMzdON20yd3A3YlgzS0lyTXR4M05XRkprQVAvSnk3Z2VZQjcyaDhmT0pC?= =?utf-8?B?NjRkVFRrd1pYVTlkNHVGVlNYNkc3QmFXN3lWa0duZnU3UUVmY0V4RWc1dHNH?= =?utf-8?B?cXpDekN4SzR1eENNREIvbWhzVnhSemlmK2cyWjlwMTlDV2pyc1ZoZG1mUkRs?= =?utf-8?B?a2xWaEZDMUZ5WTZuNDhxUjZIRFh2VHNzbUdMaDRpV2NVU3RWb01jY0tyVzda?= =?utf-8?Q?uvZoqx3VJ0+VwnGqmflcfkIg59XN4dPn8if7r/S?= X-MS-Exchange-CrossTenant-Network-Message-Id: dabe8191-e50b-4a44-a3ab-08d96ef094bc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 15:36:21.7318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eX69MP3s0GkUL7EvTuKmoRhkDTjskQCGDbIGi1DKnsT38sq5T1kJb2i1UcYhNIGiCA5PSnkupIFDK7WAcyIUpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5157 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v19 6/7] dma/skeleton: introduce skeleton dmadev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > Skeleton dmadevice driver, on the lines of rawdev skeleton, is for > showcasing of the dmadev library. > > Design of skeleton involves a virtual device which is plugged into VDEV > bus on initialization. > > Also, enable compilation of dmadev skeleton drivers. > > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> > --- <snip> > +/* Count of instances */ > +static uint16_t skeldma_init_once; Either the comment for this line or the variable name need to change as they do not line up. I would suggest: /* Count of instances, currently only 1 is supported. */ static uint16_t skeldma_count; Reviewed-by: Conor Walsh <conor.walsh@intel.com>