From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 34B922E7B for ; Mon, 6 Jul 2015 12:37:53 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 06 Jul 2015 03:37:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,414,1432623600"; d="scan'208";a="756777973" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 06 Jul 2015 03:37:38 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.39]) by IRSMSX106.ger.corp.intel.com ([169.254.8.121]) with mapi id 14.03.0224.002; Mon, 6 Jul 2015 11:37:37 +0100 From: "Mrzyglod, DanielX T" To: "Gajdzica, MaciejX T" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 00/11] ip_pipeline: ip_pipeline application enhancements Thread-Index: AQHQt853p1T7b62QHUaXPuDnVE0FaZ3OPtNg Date: Mon, 6 Jul 2015 10:37:37 +0000 Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A61D90A3A0@IRSMSX107.ger.corp.intel.com> References: <1436174936-14499-1-git-send-email-maciejx.t.gajdzica@intel.com> In-Reply-To: <1436174936-14499-1-git-send-email-maciejx.t.gajdzica@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 00/11] ip_pipeline: ip_pipeline application enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2015 10:37:54 -0000 NACK=20 ICC Compilation Errors: Pipeline/pipeline_routing_be.c: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_r= outing_be.c(740): error #188: enumerated type mixed with another type .flags =3D 0, ^ ICC wants name like PIPELINE_ROUTING_ROUTE_LOCAL but got number instead. Pipeline/Pipeline_routing.c: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_r= outing.c(851): error #188: enumerated type mixed with another type rt_params.flags =3D 0; /* remote route */ ^ The problem is that the value of PIPELINE_ROUTING_ROUTE_LOCAL is 1. After this change it looks ok.=20 Solution: We need add another enum: PIPELINE_ROUTING_ROUTE_REMOTE ICC_I686: Init.c: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/init.c(90): error #= 181: argument of type "uint64_t=3D{unsigned long long}" is incompatible wit= h format "%016lx", expecting argument of type "unsigned long" APP_LOG(app, HIGH, "CPU core mask =3D 0x%016lx", app->core_mask); ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/init.c(103): error = #181: argument of type "uint64_t=3D{unsigned long long}" is incompatible wi= th format "%lx", expecting argument of type "unsigned long" snprintf(buffer, sizeof(buffer), "-c%lx", app->core_mask); ^ pipeline_common_fe: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(525): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_in, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(526): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_by_ah, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(527): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_drop); ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(611): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_in, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(612): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_by_ah, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(613): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_drop); ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(698): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_in, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(699): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.stats.n_pkts_lookup_miss, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(700): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_by_lkp_hit_ah, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(701): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_lkp_hit, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(702): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_by_lkp_miss_ah, ^ /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_c= ommon_fe.c(703): error #181: argument of type "uint64_t=3D{unsigned long lo= ng}" is incompatible with format "%lu", expecting argument of type "unsigne= d long" stats.n_pkts_dropped_lkp_miss); ^ pipeline_routing_be.c: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_r= outing_be.c(740): error #188: enumerated type mixed with another type .flags =3D 0, ^ pipeline_routing.c: /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipeline/pipeline/pipeline_r= outing.c(851): error #188: enumerated type mixed with another type rt_params.flags =3D 0; /* remote route */ ^ compilation aborted for /mnt/shared/dtmrzglx/dpdk_pipeline/examples/ip_pipe= line/pipeline/pipeline_routing.c (code 2) /mnt/shared/dtmrzglx/macro_new_for_pipelines/mk/internal/rte.compile-pre.mk= :126: recipe for target 'pipeline_routing.o' failed > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Monday, July 06, 2015 11:29 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v5 00/11] ip_pipeline: ip_pipeline application > enhancements >=20 > This patchset enhances functionality of ip_pipeline application. New conf= ig > file syntax is introduced, so parser is changed. Changed structure of the > application. Now every global variable is stored in app_struct in app.h. > Syntax of pipeline cli commands was changed. Implementation of cli comman= ds > for every pipeline is moved to the separate file. >=20 > Changes in v2: > - renamed some files > - added more config files > - reworked flow classification pipeline implementation > - fixed some bugs >=20 > Changes in v3: > - fixed checkpatch errors > - fixed bug with message queues > - fixed bug with application log >=20 > Changes in v4: > - fixed build issue with gcc 5 > - fixed bugs in flow classification and firewall pipelines >=20 > Changes in v5: > - fixed build issue with clang 3.6 >=20 > Daniel Mrzyglod (1): > ip_pipeline: added new implementation of firewall pipeline >=20 > Jasvinder Singh (3): > ip_pipeline: added config checks > ip_pipeline: added master pipeline > ip_pipeline: added new implementation of passthrough pipeline >=20 > Maciej Gajdzica (6): > ip_pipeline: modified init to match new params struct > ip_pipeline: moved pipelines to separate folder > ip_pipeline: added application thread > ip_pipeline: moved config files to separate folder > ip_pipeline: added new implementation of routing pipeline > ip_pipeline: added new implementation of flow classification pipeline >=20 > Pawel Wodkowski (1): > ip_pipeline: add parsing for config files with new syntax >=20 > examples/ip_pipeline/Makefile | 36 +- > examples/ip_pipeline/app.h | 905 ++++++++ > examples/ip_pipeline/cmdline.c | 1976 --------------= -- > examples/ip_pipeline/config.c | 419 ---- > examples/ip_pipeline/config/ip_pipeline.cfg | 9 + > examples/ip_pipeline/config/ip_pipeline.sh | 5 + > examples/ip_pipeline/config/tm_profile.cfg | 105 + > examples/ip_pipeline/config_check.c | 397 ++++ > examples/ip_pipeline/config_parse.c | 2456 ++++++++++++++= ++++++ > examples/ip_pipeline/config_parse_tm.c | 446 ++++ > examples/ip_pipeline/cpu_core_map.c | 492 ++++ > examples/ip_pipeline/cpu_core_map.h | 69 + > examples/ip_pipeline/init.c | 1612 +++++++++---- > examples/ip_pipeline/ip_pipeline.cfg | 56 - > examples/ip_pipeline/ip_pipeline.sh | 18 - > examples/ip_pipeline/main.c | 137 +- > examples/ip_pipeline/main.h | 298 --- > examples/ip_pipeline/pipeline.h | 87 + > examples/ip_pipeline/pipeline/hash_func.h | 351 +++ > .../ip_pipeline/pipeline/pipeline_actions_common.h | 119 + > examples/ip_pipeline/pipeline/pipeline_common_be.c | 206 ++ > examples/ip_pipeline/pipeline/pipeline_common_be.h | 163 ++ > examples/ip_pipeline/pipeline/pipeline_common_fe.c | 1324 +++++++++++ > examples/ip_pipeline/pipeline/pipeline_common_fe.h | 228 ++ > examples/ip_pipeline/pipeline/pipeline_firewall.c | 1001 ++++++++ > examples/ip_pipeline/pipeline/pipeline_firewall.h | 63 + > .../ip_pipeline/pipeline/pipeline_firewall_be.c | 740 ++++++ > .../ip_pipeline/pipeline/pipeline_firewall_be.h | 138 ++ > .../pipeline/pipeline_flow_classification.c | 2057 ++++++++++++++= ++ > .../pipeline/pipeline_flow_classification.h | 105 + > .../pipeline/pipeline_flow_classification_be.c | 589 +++++ > .../pipeline/pipeline_flow_classification_be.h | 140 ++ > examples/ip_pipeline/pipeline/pipeline_master.c | 47 + > examples/ip_pipeline/pipeline/pipeline_master.h | 41 + > examples/ip_pipeline/pipeline/pipeline_master_be.c | 150 ++ > examples/ip_pipeline/pipeline/pipeline_master_be.h | 41 + > .../ip_pipeline/pipeline/pipeline_passthrough.c | 47 + > .../ip_pipeline/pipeline/pipeline_passthrough.h | 41 + > .../ip_pipeline/pipeline/pipeline_passthrough_be.c | 772 ++++++ > .../ip_pipeline/pipeline/pipeline_passthrough_be.h | 41 + > examples/ip_pipeline/pipeline/pipeline_routing.c | 1541 ++++++++++++ > examples/ip_pipeline/pipeline/pipeline_routing.h | 99 + > .../ip_pipeline/pipeline/pipeline_routing_be.c | 869 +++++++ > .../ip_pipeline/pipeline/pipeline_routing_be.h | 230 ++ > examples/ip_pipeline/pipeline_be.h | 256 ++ > examples/ip_pipeline/pipeline_firewall.c | 313 --- > .../ip_pipeline/pipeline_flow_classification.c | 306 --- > examples/ip_pipeline/pipeline_ipv4_frag.c | 184 -- > examples/ip_pipeline/pipeline_ipv4_ras.c | 181 -- > examples/ip_pipeline/pipeline_passthrough.c | 213 -- > examples/ip_pipeline/pipeline_routing.c | 474 ---- > examples/ip_pipeline/pipeline_rx.c | 385 --- > examples/ip_pipeline/pipeline_tx.c | 283 --- > examples/ip_pipeline/thread.c | 110 + > 54 files changed, 17702 insertions(+), 5669 deletions(-) > create mode 100644 examples/ip_pipeline/app.h > delete mode 100644 examples/ip_pipeline/cmdline.c > delete mode 100644 examples/ip_pipeline/config.c > create mode 100644 examples/ip_pipeline/config/ip_pipeline.cfg > create mode 100644 examples/ip_pipeline/config/ip_pipeline.sh > create mode 100644 examples/ip_pipeline/config/tm_profile.cfg > create mode 100644 examples/ip_pipeline/config_check.c > create mode 100644 examples/ip_pipeline/config_parse.c > create mode 100644 examples/ip_pipeline/config_parse_tm.c > create mode 100644 examples/ip_pipeline/cpu_core_map.c > create mode 100644 examples/ip_pipeline/cpu_core_map.h > delete mode 100644 examples/ip_pipeline/ip_pipeline.cfg > delete mode 100644 examples/ip_pipeline/ip_pipeline.sh > delete mode 100644 examples/ip_pipeline/main.h > create mode 100644 examples/ip_pipeline/pipeline.h > create mode 100644 examples/ip_pipeline/pipeline/hash_func.h > create mode 100644 > examples/ip_pipeline/pipeline/pipeline_actions_common.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_common_be.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_common_be.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_common_fe.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_common_fe.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_firewall.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_firewall.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_firewall_be.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_firewall_be.h > create mode 100644 > examples/ip_pipeline/pipeline/pipeline_flow_classification.c > create mode 100644 > examples/ip_pipeline/pipeline/pipeline_flow_classification.h > create mode 100644 > examples/ip_pipeline/pipeline/pipeline_flow_classification_be.c > create mode 100644 > examples/ip_pipeline/pipeline/pipeline_flow_classification_be.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_master.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_master.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_master_be.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_master_be.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_passthrough.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_passthrough.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_passthrough_be= .c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_passthrough_be= .h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_routing.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_routing.h > create mode 100644 examples/ip_pipeline/pipeline/pipeline_routing_be.c > create mode 100644 examples/ip_pipeline/pipeline/pipeline_routing_be.h > create mode 100644 examples/ip_pipeline/pipeline_be.h > delete mode 100644 examples/ip_pipeline/pipeline_firewall.c > delete mode 100644 examples/ip_pipeline/pipeline_flow_classification.c > delete mode 100644 examples/ip_pipeline/pipeline_ipv4_frag.c > delete mode 100644 examples/ip_pipeline/pipeline_ipv4_ras.c > delete mode 100644 examples/ip_pipeline/pipeline_passthrough.c > delete mode 100644 examples/ip_pipeline/pipeline_routing.c > delete mode 100644 examples/ip_pipeline/pipeline_rx.c > delete mode 100644 examples/ip_pipeline/pipeline_tx.c > create mode 100644 examples/ip_pipeline/thread.c >=20 > -- > 1.7.9.5