From: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Mike Davison <mdavison@brocade.com>,
Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: Add rte_pktmbuf_copy
Date: Fri, 22 Jan 2016 13:40:44 +0000 [thread overview]
Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A63346A5A4@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1436485068-30609-2-git-send-email-stephen@networkplumber.org>
>-----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
>Sent: Friday, July 10, 2015 1:38 AM
>To: dev@dpdk.org
>Cc: Mike Davison <mdavison@brocade.com>; Stephen Hemminger
><shemming@brocade.com>
>Subject: [dpdk-dev] [PATCH 1/2] mbuf: Add rte_pktmbuf_copy
>
>From: Stephen Hemminger <shemming@brocade.com>
>
>Added rte_pktmbuf_copy() function since copying multi-part
>segments is common issue and can be problematic.
>
>Signed-off-by: Mike Davison <mdavison@brocade.com>
>Reviewed-by: Stephen Hemminger <shemming@brocade.com>
>---
> lib/librte_mbuf/rte_mbuf.h | 59
>++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
>diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
>index 80419df..f0a543b 100644
>--- a/lib/librte_mbuf/rte_mbuf.h
>+++ b/lib/librte_mbuf/rte_mbuf.h
>@@ -60,6 +60,7 @@
> #include <rte_atomic.h>
> #include <rte_prefetch.h>
> #include <rte_branch_prediction.h>
>+#include <rte_memcpy.h>
>
> #ifdef __cplusplus
> extern "C" {
>@@ -1272,6 +1273,64 @@ static inline int rte_pktmbuf_is_contiguous(const
>struct rte_mbuf *m)
> return !!(m->nb_segs == 1);
> }
>
>+/*
>+ * Creates a copy of the given packet mbuf.
>+ *
>+ * Walks through all segments of the given packet mbuf, and for each of them:
>+ * - Creates a new packet mbuf from the given pool.
>+ * - Copy segment to newly created mbuf.
>+ * Then updates pkt_len and nb_segs of the new packet mbuf to match values
>+ * from the original packet mbuf.
>+ *
>+ * @param md
>+ * The packet mbuf to be copied.
>+ * @param mp
>+ * The mempool from which the mbufs are allocated.
>+ * @return
>+ * - The pointer to the new mbuf on success.
>+ * - NULL if allocation fails.
>+ */
>+static inline struct rte_mbuf *rte_pktmbuf_copy(struct rte_mbuf *md,
>+ struct rte_mempool *mp)
>+{
>+ struct rte_mbuf *mc = NULL;
>+ struct rte_mbuf **prev = &mc;
>+
>+ do {
>+ struct rte_mbuf *mi;
>+
>+ mi = rte_pktmbuf_alloc(mp);
>+ if (unlikely(mi == NULL)) {
>+ rte_pktmbuf_free(mc);
>+ return NULL;
>+ }
>+
>+ mi->data_off = md->data_off;
>+ mi->data_len = md->data_len;
>+ mi->port = md->port;
>+ mi->vlan_tci = md->vlan_tci;
>+ mi->tx_offload = md->tx_offload;
>+ mi->hash = md->hash;
>+
>+ mi->next = NULL;
>+ mi->pkt_len = md->pkt_len;
>+ mi->nb_segs = md->nb_segs;
>+ mi->ol_flags = md->ol_flags;
>+ mi->packet_type = md->packet_type;
>+
>+ rte_memcpy(rte_pktmbuf_mtod(mi, char *),
>+ rte_pktmbuf_mtod(md, char *),
>+ md->data_len);
>+
>+ *prev = mi;
>+ prev = &mi->next;
>+ } while ((md = md->next) != NULL);
>+
>+ *prev = NULL;
>+ __rte_mbuf_sanity_check(mc, 1);
>+ return mc;
>+}
>+
> /**
> * Dump an mbuf structure to the console.
> *
>--
>2.1.4
Hi Stephen :>
This patch look useful in case of backup buffs.
There will be second approach ?
next prev parent reply other threads:[~2016-01-22 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 23:37 [dpdk-dev] [PATCH 0/2] mbuf: improvements Stephen Hemminger
2015-07-09 23:37 ` [dpdk-dev] [PATCH 1/2] mbuf: Add rte_pktmbuf_copy Stephen Hemminger
2015-07-15 10:14 ` Olivier MATZ
2016-01-22 13:40 ` Mrzyglod, DanielX T [this message]
2016-01-22 17:33 ` Stephen Hemminger
2016-03-18 17:03 ` Pattan, Reshma
2016-03-18 17:40 ` Stephen Hemminger
2016-02-03 17:23 ` Olivier MATZ
[not found] ` <ccbdb829556f4423b009aff93f27c93b@BRMWP-EXMB11.corp.brocade.com>
2016-02-04 0:49 ` Stephen Hemminger
2015-07-09 23:37 ` [dpdk-dev] [PATCH 2/2] mbuf: make sure userdata is initialized Stephen Hemminger
2015-07-10 9:32 ` Bruce Richardson
2015-07-10 15:43 ` Stephen Hemminger
2015-07-15 10:10 ` Olivier MATZ
2016-02-03 17:23 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ADD74816B4C8A45B56203CBA65FE5A63346A5A4@IRSMSX107.ger.corp.intel.com \
--to=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=mdavison@brocade.com \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).