From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8354B1B63C for ; Wed, 4 Oct 2017 15:09:03 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 06:09:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,477,1500966000"; d="scan'208";a="1178571711" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 04 Oct 2017 06:09:01 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.65]) by irsmsx105.ger.corp.intel.com ([169.254.7.75]) with mapi id 14.03.0319.002; Wed, 4 Oct 2017 14:09:00 +0100 From: "Mrzyglod, DanielX T" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize Thread-Index: AQHTGurkgEIEx0M5wUGDOlNAYmYYcaLT63oQ Date: Wed, 4 Oct 2017 13:09:00 +0000 Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A660B96E2A@IRSMSX107.ger.corp.intel.com> References: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com> <94479800C636CB44BD422CB454846E013200861D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013200861D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 13:09:03 -0000 >> >> This issue was about passing unsigned argument where should be signed >> number. >> In reality this is about wrong usage of fseek and ftell to determine fil= esize. >> This patch is compliant to suggestions from FIO19-C: >> "Do not use fseek() and ftell() to compute the size of a regular file" >> >> Coverity issue: 143454 >> Fixes: a92a5a2cbbff ("app/testpmd: add command for loading DDP") >> >> Signed-off-by: Daniel Mrzyglod > >Acked-by: Beilei Xing Hi Jingjing I would like to ask for a feedback about status of proposed fix. Will it go for integration or does it need any other additional work. Best regards Daniel