From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1090F3975 for ; Mon, 17 Nov 2014 17:37:14 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 17 Nov 2014 08:47:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="417656810" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 17 Nov 2014 08:38:08 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.116]) by IRSMSX106.ger.corp.intel.com ([169.254.8.101]) with mapi id 14.03.0195.001; Mon, 17 Nov 2014 16:47:23 +0000 From: "Walukiewicz, Miroslaw" To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [PATCH v2 02/13] ixgbe: fix remaining pkt_flags variable size to 64 bits Thread-Index: AQHQAC0YVFp9ZuR22ka1YjUDgvFtR5xk30vg Date: Mon, 17 Nov 2014 16:47:22 +0000 Message-ID: <7C4248CAE043B144B1CD242D275626532FDFFE4E@IRSMSX104.ger.corp.intel.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-3-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1415984609-2484-3-git-send-email-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "jigsaw@gmail.com" Subject: Re: [dpdk-dev] [PATCH v2 02/13] ixgbe: fix remaining pkt_flags variable size to 64 bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2014 16:37:15 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, November 14, 2014 6:03 PM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yon= g; > jigsaw@gmail.com; Richardson, Bruce > Subject: [PATCH v2 02/13] ixgbe: fix remaining pkt_flags variable size to= 64 > bits >=20 > Since commit 4332beee9 "mbuf: expand ol_flags field to 64-bits", the > packet flags are now 64 bits wide. Some occurences were forgotten in > the ixgbe driver. I think it should be present in separate patch. I do no not see any relatio= n to TSO >=20 > Signed-off-by: Olivier Matz > Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index ecebbf6..7e470ce 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -817,7 +817,7 @@ end_of_tx: > static inline uint64_t > rx_desc_hlen_type_rss_to_pkt_flags(uint32_t hl_tp_rs) > { > - uint16_t pkt_flags; > + uint64_t pkt_flags; >=20 > static uint64_t ip_pkt_types_map[16] =3D { > 0, PKT_RX_IPV4_HDR, PKT_RX_IPV4_HDR_EXT, > PKT_RX_IPV4_HDR_EXT, > @@ -834,7 +834,7 @@ rx_desc_hlen_type_rss_to_pkt_flags(uint32_t > hl_tp_rs) > }; >=20 > #ifdef RTE_LIBRTE_IEEE1588 > - static uint32_t ip_pkt_etqf_map[8] =3D { > + static uint64_t ip_pkt_etqf_map[8] =3D { > 0, 0, 0, PKT_RX_IEEE1588_PTP, > 0, 0, 0, 0, > }; > @@ -903,7 +903,7 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq) > struct igb_rx_entry *rxep; > struct rte_mbuf *mb; > uint16_t pkt_len; > - uint16_t pkt_flags; > + uint64_t pkt_flags; > int s[LOOK_AHEAD], nb_dd; > int i, j, nb_rx =3D 0; >=20 > @@ -1335,7 +1335,7 @@ ixgbe_recv_scattered_pkts(void *rx_queue, struct > rte_mbuf **rx_pkts, > uint16_t nb_rx; > uint16_t nb_hold; > uint16_t data_len; > - uint16_t pkt_flags; > + uint64_t pkt_flags; >=20 > nb_rx =3D 0; > nb_hold =3D 0; > @@ -1511,9 +1511,9 @@ ixgbe_recv_scattered_pkts(void *rx_queue, struct > rte_mbuf **rx_pkts, > first_seg->vlan_tci =3D rte_le_to_cpu_16(rxd.wb.upper.vlan); > hlen_type_rss =3D > rte_le_to_cpu_32(rxd.wb.lower.lo_dword.data); > pkt_flags =3D > rx_desc_hlen_type_rss_to_pkt_flags(hlen_type_rss); > - pkt_flags =3D (uint16_t)(pkt_flags | > + pkt_flags =3D (pkt_flags | > rx_desc_status_to_pkt_flags(staterr)); > - pkt_flags =3D (uint16_t)(pkt_flags | > + pkt_flags =3D (pkt_flags | > rx_desc_error_to_pkt_flags(staterr)); > first_seg->ol_flags =3D pkt_flags; >=20 > -- > 2.1.0