DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Walukiewicz, Miroslaw" <Miroslaw.Walukiewicz@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] table: fix a crash during key8 and key32 overload
Date: Mon, 23 Mar 2015 15:22:28 +0000	[thread overview]
Message-ID: <7C4248CAE043B144B1CD242D275626532FE76AC4@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323382BD@IRSMSX108.ger.corp.intel.com>

Reviewed-by: Mirek Walukiewicz <miroslaw.walukiewicz@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dumitrescu, Cristian
> Sent: Monday, March 23, 2015 4:20 PM
> To: Gajdzica, MaciejX T; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] table: fix a crash during key8 and key32
> overload
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maciej Gajdzica
> > Sent: Monday, March 23, 2015 3:09 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] table: fix a crash during key8 and key32
> > overload
> >
> > hash_key8_ext and hash_key32_ext tables allocate cache entries to
> > support table overload cases. The crash can occur when cache entry is
> > free after use. The problem is with computing the index of the free
> > cache entry. The same case for key16 was fixed with earlier patch.
> >
> > Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
> > ---
> >  lib/librte_table/rte_table_hash_key32.c |    5 ++---
> >  lib/librte_table/rte_table_hash_key8.c  |    5 ++---
> >  2 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/librte_table/rte_table_hash_key32.c
> > b/lib/librte_table/rte_table_hash_key32.c
> > index da0ce6a..6790594 100644
> > --- a/lib/librte_table/rte_table_hash_key32.c
> > +++ b/lib/librte_table/rte_table_hash_key32.c
> > @@ -540,9 +540,8 @@ rte_table_hash_entry_delete_key32_ext(
> >
> >  					memset(bucket, 0,
> >  						sizeof(struct
> > rte_bucket_4_32));
> > -					bucket_index = (bucket -
> > -						((struct rte_bucket_4_32 *)
> > -						f->memory)) - f->n_buckets;
> > +					bucket_index = (((uint8_t *)bucket -
> > +						(uint8_t *)f->memory)/f-
> > >bucket_size) - f->n_buckets;
> >  					f->stack[f->stack_pos++] =
> > bucket_index;
> >  				}
> >
> > diff --git a/lib/librte_table/rte_table_hash_key8.c
> > b/lib/librte_table/rte_table_hash_key8.c
> > index 443ca7d..6803eb2 100644
> > --- a/lib/librte_table/rte_table_hash_key8.c
> > +++ b/lib/librte_table/rte_table_hash_key8.c
> > @@ -528,9 +528,8 @@ rte_table_hash_entry_delete_key8_ext(
> >
> >  					memset(bucket, 0,
> >  						sizeof(struct
> > rte_bucket_4_8));
> > -					bucket_index = (bucket -
> > -						((struct rte_bucket_4_8 *)
> > -						f->memory)) - f->n_buckets;
> > +					bucket_index = (((uint8_t *)bucket -
> > +						(uint8_t *)f->memory)/f-
> > >bucket_size) - f->n_buckets;
> >  					f->stack[f->stack_pos++] =
> > bucket_index;
> >  				}
> >
> > --
> > 1.7.9.5
> 
> Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Thanks, Maciej!

  reply	other threads:[~2015-03-23 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 15:09 Maciej Gajdzica
2015-03-23 15:20 ` Dumitrescu, Cristian
2015-03-23 15:22   ` Walukiewicz, Miroslaw [this message]
2015-03-27 11:19   ` Thomas Monjalon
2015-03-23 15:10 Maciej Gajdzica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7C4248CAE043B144B1CD242D275626532FE76AC4@IRSMSX104.ger.corp.intel.com \
    --to=miroslaw.walukiewicz@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=maciejx.t.gajdzica@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).