From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 753CB42FB3;
	Wed,  2 Aug 2023 04:23:29 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 05CDF410DC;
	Wed,  2 Aug 2023 04:23:29 +0200 (CEST)
Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239])
 by mails.dpdk.org (Postfix) with ESMTP id 6F28040DDB
 for <dev@dpdk.org>; Wed,  2 Aug 2023 04:23:25 +0200 (CEST)
X-QQ-mid: bizesmtp72t1690942993t8sbc8j0
Received: from LAPTOP96V0OHHN ( [183.81.182.182])
 by bizesmtp.qq.com (ESMTP) with 
 id ; Wed, 02 Aug 2023 10:23:12 +0800 (CST)
X-QQ-SSF: 00400000000000D0E000000B0000000
X-QQ-FEAT: 64bmQJo5TM+eC9FqGwK00h1iMFUhHTrAa6/hWYIJ9tR3umkfkLDUtlLygC18n
 Bmhm4JEWCb9EKVwOm4fWOzs3nTFmodkiQmXmaI7Sy527bBmRoodjOZ1aKLba3bgPKWmGY6d
 dCH3ku/C0/s2Su3gvmPxeb+RbNmqYaCLwBLSGcjP30YakZJWH0TAVBgmJ/bqceOnqAZoY7l
 cuTX/sZP+XffjYd/V1Sf9Tzc8udXGNuBtVZhMIO8McBQsc9TwQGU3actMio8OYEuUC76HSD
 rxMusdvnJRvueIEvUJt1mP5lHfpDsPCgd641ifywgmkgZIRIYbK0pLzP5JOwX23ZBUWWZsZ
 dOoCOyXVrn2dt3dy3xo7mbPsBr2UZ/8EbZlDpp+sM3o5852aF+VzmHLiAwpFK0S5llFB7pR
X-QQ-GoodBg: 2
X-BIZMAIL-ID: 9780546398493622019
From: "11" <caowenbo@mucse.com>
To: "'Stephen Hemminger'" <stephen@networkplumber.org>
Cc: "'Anatoly Burakov'" <anatoly.burakov@intel.com>,
	<dev@dpdk.org>
References: <20230801064346.805294-1-caowenbo@mucse.com>	<20230801064346.805294-4-caowenbo@mucse.com>
 <20230801082057.4e09bf99@hermes.local>
In-Reply-To: <20230801082057.4e09bf99@hermes.local>
Subject: RE: [[PATCH v1] 3/8] net/rnp: add device init and uninit
Date: Wed, 2 Aug 2023 10:23:13 +0800
Message-ID: <7E57098CA0CB2788+004e01d9c4e8$4a6bdd20$df439760$@mucse.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHE5zKPKjce+YNlv+7MflwbZRFlvwIYyqcUAMD2J+Gv6TLtoA==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:mucse.com:qybglogicsvrgz:qybglogicsvrgz5a-0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Stephen,

Why have two labels for same place, to later patches insert code here?
For this question the new code in rnp_init_port_resource
Will zmalloc dev->data->mac_addrs  and  dev->data->hash_mac_addrs
So I wish to free the zmalloc mem when init port resource failed


Regards wenbo

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>=20
Sent: 2023=C4=EA8=D4=C21=C8=D5 23:21
To: Wenbo Cao <caowenbo@mucse.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>; dev@dpdk.org
Subject: Re: [[PATCH v1] 3/8] net/rnp: add device init and uninit

On Tue,  1 Aug 2023 06:43:41 +0000
Wenbo Cao <caowenbo@mucse.com> wrote:

> +	return 0;
> +eth_alloc_error:
> +init_failed:

Why have two labels for same place, to later patches insert code here?