From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [202.32.8.206]) by dpdk.org (Postfix) with ESMTP id 420CB58EB for ; Thu, 30 Jan 2014 12:21:25 +0100 (CET) Received: from mailgate3.nec.co.jp ([10.7.69.195]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBMeOd014049; Thu, 30 Jan 2014 20:22:40 +0900 (JST) Received: from mailsv.nec.co.jp (imss62.nec.co.jp [10.7.69.157]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s0UBMeZ13009; Thu, 30 Jan 2014 20:22:40 +0900 (JST) Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBMene029634; Thu, 30 Jan 2014 20:22:40 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.144] [10.38.151.144]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-669280; Thu, 30 Jan 2014 20:22:16 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC16GP.gisp.nec.co.jp ([10.38.151.144]) with mapi id 14.02.0328.011; Thu, 30 Jan 2014 20:22:16 +0900 From: Hiroshi Shimamoto To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [memnic PATCH 1/3] pmd: remove symlink Thread-Index: AQHPHZzKjlT9pLbzY0CvWEAQpwqyEZqdG2mA Date: Thu, 30 Jan 2014 11:22:15 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD0102CF51@BPXM14GP.gisp.nec.co.jp> References: <924a3a6605ea8909ad16a6d55a6fa179b516b319.1390580092.git.thomas.monjalon@6wind.com> In-Reply-To: <924a3a6605ea8909ad16a6d55a6fa179b516b319.1390580092.git.thomas.monjalon@6wind.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [memnic PATCH 1/3] pmd: remove symlink X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2014 11:21:25 -0000 Hi, > Subject: [memnic PATCH 1/3] pmd: remove symlink >=20 > No need to have a symbolic link to a common file > when it can be simply included. Looks fine to me. When I prepared the file with a bit complex file path layout, easy to keep consistency. Because you separated the code from DPDK vSwitch, there is no reason to do that. thanks, Hiroshi >=20 > Signed-off-by: Thomas Monjalon > --- > pmd/Makefile | 2 +- > pmd/memnic.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > delete mode 120000 pmd/memnic.h >=20 > diff --git a/pmd/Makefile b/pmd/Makefile > index a96e125..7f96af1 100644 > --- a/pmd/Makefile > +++ b/pmd/Makefile > @@ -59,7 +59,7 @@ ifeq '$(RTE_INCLUDE)' '' > endif > $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \ > -I$(RTE_INCLUDE) -include $(RTE_CONFIG) \ > - -o $@ $< > + -I$S/../common -o $@ $< >=20 > install : $(DESTDIR)$(libdir)/$(SOLIB) > install -D -m 644 $S/README.rst $(DESTDIR)$(docdir)/README.rst > diff --git a/pmd/memnic.h b/pmd/memnic.h > deleted file mode 120000 > index 5303ad4..0000000 > --- a/pmd/memnic.h > +++ /dev/null > @@ -1 +0,0 @@ > -../common/memnic.h > \ No newline at end of file > -- > 1.7.10.4