Re: [dpdk-dev] [memnic PATCH 2/3] pmd: remove useless includes

[Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>]

> Subject: [memnic PATCH 2/3] pmd: remove useless includes
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  common/memnic.h  |    4 ----
>  pmd/pmd_memnic.c |    4 ----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/common/memnic.h b/common/memnic.h
> index 6ff38a0..58dd019 100644
> --- a/common/memnic.h
> +++ b/common/memnic.h
> @@ -31,10 +31,6 @@
>  #ifndef __MEMNIC_H__
>  #define __MEMNIC_H__
> 
> -#ifndef __KERNEL__
> -#include <stdint.h>
> -#endif /* __KERNEL__ */
> -

I'm not sure, but you're not seeing error, it's okay.
I put it for uintxx_t series, originally.

others, fine to me.

thanks,
Hiroshi

>  #define MEMNIC_MAGIC		0x43494e76
>  #define MEMNIC_VERSION		0x00000001
>  #define MEMNIC_VERSION_1	0x00000001
> diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
> index d16eb0d..619941a 100644
> --- a/pmd/pmd_memnic.c
> +++ b/pmd/pmd_memnic.c
> @@ -30,18 +30,14 @@
>   */
> 
>  #include <rte_ethdev.h>
> -
>  #include <rte_string_fns.h>
>  #include <rte_malloc.h>
>  #include <rte_memcpy.h>
> -#include <rte_log.h>
> 
>  #include "memnic.h"
> 
>  #include <sys/mman.h>
> -#include <sys/stat.h>
>  #include <fcntl.h>
> -#include <stdio.h>
>  #include <unistd.h>
>  #include <errno.h>
> 
> --
> 1.7.10.4