From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <h-shimamoto@ct.jp.nec.com>
Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [202.32.8.206])
 by dpdk.org (Postfix) with ESMTP id E5A1968DD
 for <dev@dpdk.org>; Thu, 30 Jan 2014 12:30:01 +0100 (CET)
Received: from mailgate3.nec.co.jp ([10.7.69.160])
 by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBVI3R017531;
 Thu, 30 Jan 2014 20:31:18 +0900 (JST)
Received: from mailsv.nec.co.jp (imss61.nec.co.jp [10.7.69.156]) by
 mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP
 id s0UBVIZ10751; Thu, 30 Jan 2014 20:31:18 +0900 (JST)
Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2])
 by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBVI6f002704;
 Thu, 30 Jan 2014 20:31:18 +0900 (JST)
Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.141] [10.38.151.141]) by
 mail02.kamome.nec.co.jp with ESMTP id BT-MMP-524586;
 Thu, 30 Jan 2014 20:30:33 +0900
Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by
 BPXC13GP.gisp.nec.co.jp ([10.38.151.141]) with mapi id 14.02.0328.011; Thu,
 30 Jan 2014 20:30:33 +0900
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [memnic PATCH 2/3] pmd: remove useless includes
Thread-Index: AQHPHZzWJppuuyWUaku7aFPzWESbg5qdIRog
Date: Thu, 30 Jan 2014 11:30:32 +0000
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD0102D004@BPXM14GP.gisp.nec.co.jp>
References: <cover.1390580092.git.thomas.monjalon@6wind.com>
 <b96ee2cdb5460abdd4a59dadb8b1ebf8e886ffad.1390580092.git.thomas.monjalon@6wind.com>
In-Reply-To: <b96ee2cdb5460abdd4a59dadb8b1ebf8e886ffad.1390580092.git.thomas.monjalon@6wind.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.205.5.123]
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [memnic PATCH 2/3] pmd: remove useless includes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 11:30:02 -0000

> Subject: [memnic PATCH 2/3] pmd: remove useless includes
>=20
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  common/memnic.h  |    4 ----
>  pmd/pmd_memnic.c |    4 ----
>  2 files changed, 8 deletions(-)
>=20
> diff --git a/common/memnic.h b/common/memnic.h
> index 6ff38a0..58dd019 100644
> --- a/common/memnic.h
> +++ b/common/memnic.h
> @@ -31,10 +31,6 @@
>  #ifndef __MEMNIC_H__
>  #define __MEMNIC_H__
>=20
> -#ifndef __KERNEL__
> -#include <stdint.h>
> -#endif /* __KERNEL__ */
> -

I'm not sure, but you're not seeing error, it's okay.
I put it for uintxx_t series, originally.

others, fine to me.

thanks,
Hiroshi

>  #define MEMNIC_MAGIC		0x43494e76
>  #define MEMNIC_VERSION		0x00000001
>  #define MEMNIC_VERSION_1	0x00000001
> diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
> index d16eb0d..619941a 100644
> --- a/pmd/pmd_memnic.c
> +++ b/pmd/pmd_memnic.c
> @@ -30,18 +30,14 @@
>   */
>=20
>  #include <rte_ethdev.h>
> -
>  #include <rte_string_fns.h>
>  #include <rte_malloc.h>
>  #include <rte_memcpy.h>
> -#include <rte_log.h>
>=20
>  #include "memnic.h"
>=20
>  #include <sys/mman.h>
> -#include <sys/stat.h>
>  #include <fcntl.h>
> -#include <stdio.h>
>  #include <unistd.h>
>  #include <errno.h>
>=20
> --
> 1.7.10.4