Re: [dpdk-dev] [memnic PATCH] pmd: fix attributes

[Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>]

> Subject: [dpdk-dev] [memnic PATCH] pmd: fix attributes
> 
> Add missing "const" and remove useless "rte_unused" attributes.

Good catch. Looks fine to me.

thanks,
Hiroshi

> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  pmd/pmd_memnic.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
> index d16eb0d..bc01746 100644
> --- a/pmd/pmd_memnic.c
> +++ b/pmd/pmd_memnic.c
> @@ -57,7 +57,7 @@ struct memnic_adapter {
>  	struct ether_addr mac_addr;
>  };
> 
> -static inline struct memnic_adapter *get_adapter(struct rte_eth_dev *dev)
> +static inline struct memnic_adapter *get_adapter(const struct rte_eth_dev *dev)
>  {
>  	return (struct memnic_adapter *)(dev->data->dev_private);
>  }
> @@ -67,7 +67,7 @@ struct memnic_queue {
>  	uint8_t port_id;
>  };
> 
> -static struct memnic_queue *memnic_queue_alloc(struct rte_eth_dev *dev,
> +static struct memnic_queue *memnic_queue_alloc(const struct rte_eth_dev *dev,
>  					       int tx, uint16_t id)
>  {
>  	struct memnic_adapter *adapter = get_adapter(dev);
> @@ -119,7 +119,7 @@ static void memnic_dev_stop(struct rte_eth_dev *dev)
>  	return;
>  }
> 
> -static void memnic_dev_infos_get(__rte_unused struct rte_eth_dev *dev,
> +static void memnic_dev_infos_get(struct rte_eth_dev *dev,
>  				 struct rte_eth_dev_info *dev_info)
>  {
>  	dev_info->driver_name = dev->driver->pci_drv.name;
> --
> 1.8.4.rc3