From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [202.32.8.193]) by dpdk.org (Postfix) with ESMTP id DA73168CF for ; Thu, 30 Jan 2014 12:36:58 +0100 (CET) Received: from mailgate3.nec.co.jp ([10.7.69.160]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBcFWE024517; Thu, 30 Jan 2014 20:38:15 +0900 (JST) Received: from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s0UBcFZ15569; Thu, 30 Jan 2014 20:38:15 +0900 (JST) Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s0UBcFJQ004707; Thu, 30 Jan 2014 20:38:15 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.141] [10.38.151.141]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-669548; Thu, 30 Jan 2014 20:37:55 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC13GP.gisp.nec.co.jp ([10.38.151.141]) with mapi id 14.02.0328.011; Thu, 30 Jan 2014 20:37:55 +0900 From: Hiroshi Shimamoto To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [memnic PATCH] pmd: fix attributes Thread-Index: AQHPHZx46a8QMKX0DECJ6igSRixN4JqdI/Rw Date: Thu, 30 Jan 2014 11:37:54 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD0102D0D4@BPXM14GP.gisp.nec.co.jp> References: <1390579140-23841-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1390579140-23841-1-git-send-email-olivier.matz@6wind.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [memnic PATCH] pmd: fix attributes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2014 11:36:59 -0000 > Subject: [dpdk-dev] [memnic PATCH] pmd: fix attributes >=20 > Add missing "const" and remove useless "rte_unused" attributes. Good catch. Looks fine to me. thanks, Hiroshi >=20 > Signed-off-by: Olivier Matz > --- > pmd/pmd_memnic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c > index d16eb0d..bc01746 100644 > --- a/pmd/pmd_memnic.c > +++ b/pmd/pmd_memnic.c > @@ -57,7 +57,7 @@ struct memnic_adapter { > struct ether_addr mac_addr; > }; >=20 > -static inline struct memnic_adapter *get_adapter(struct rte_eth_dev *dev= ) > +static inline struct memnic_adapter *get_adapter(const struct rte_eth_de= v *dev) > { > return (struct memnic_adapter *)(dev->data->dev_private); > } > @@ -67,7 +67,7 @@ struct memnic_queue { > uint8_t port_id; > }; >=20 > -static struct memnic_queue *memnic_queue_alloc(struct rte_eth_dev *dev, > +static struct memnic_queue *memnic_queue_alloc(const struct rte_eth_dev = *dev, > int tx, uint16_t id) > { > struct memnic_adapter *adapter =3D get_adapter(dev); > @@ -119,7 +119,7 @@ static void memnic_dev_stop(struct rte_eth_dev *dev) > return; > } >=20 > -static void memnic_dev_infos_get(__rte_unused struct rte_eth_dev *dev, > +static void memnic_dev_infos_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > { > dev_info->driver_name =3D dev->driver->pci_drv.name; > -- > 1.8.4.rc3