From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Hayato Momma <h-momma@ce.jp.nec.com>
Subject: [dpdk-dev] [memnic PATCH 1/5] pmd: fix race condition
Date: Tue, 11 Mar 2014 05:37:16 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD01073AD6@BPXM14GP.gisp.nec.co.jp> (raw)
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
There is a race condition, on transmit to vSwitch.
Guest PMD Host
Thread-A Thread-B vSwitch
|idx=0 |idx=0 |p[0] st!=2
|cmpxchg | |
|p[0] st->1 | |
|idx=1 | |
|fill data | |
|p[0] st->2 | |p[0] st==2
| | |receive data
| | |p[0] st->0
| |cmpxchg |
| |success |p[1] st!=2
| |p[0] st->1 |
This is BAD
That causes traffic stop.
We have to take care about that race condition with checking
whether current index is correct.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index 30d5a1b..805f0b2 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -278,6 +278,15 @@ retry:
goto retry;
}
+ if (idx != ACCESS_ONCE(adapter->down_idx)) {
+ /*
+ * vSwitch freed this and got false positive,
+ * need to recover the status and retry.
+ */
+ p->status = MEMNIC_PKT_ST_FREE;
+ goto retry;
+ }
+
if (++idx >= MEMNIC_NR_PACKET)
idx = 0;
adapter->down_idx = idx;
--
1.8.4
next reply other threads:[~2014-03-11 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 5:37 Hiroshi Shimamoto [this message]
2014-03-26 16:44 ` Olivier MATZ
2014-03-28 9:49 ` Hiroshi Shimamoto
2014-03-28 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD01073AD6@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto@ct.jp.nec.com \
--cc=dev@dpdk.org \
--cc=h-momma@ce.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).