From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [202.32.8.193]) by dpdk.org (Postfix) with ESMTP id 41558DE4 for ; Tue, 11 Mar 2014 06:41:03 +0100 (CET) Received: from mailgate3.nec.co.jp ([10.7.69.192]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s2B5gVn5024781 for ; Tue, 11 Mar 2014 14:42:31 +0900 (JST) Received: from mailsv3.nec.co.jp (imss61.nec.co.jp [10.7.69.156]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s2B5gUf21582 for ; Tue, 11 Mar 2014 14:42:31 +0900 (JST) Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s2B5fTS0006812 for ; Tue, 11 Mar 2014 14:42:30 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.143] [10.38.151.143]) by mail02.kamome.nec.co.jp with ESMTP id BT-MMP-107792; Tue, 11 Mar 2014 14:38:13 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC15GP.gisp.nec.co.jp ([10.38.151.143]) with mapi id 14.02.0328.011; Tue, 11 Mar 2014 14:38:13 +0900 From: Hiroshi Shimamoto To: "dev@dpdk.org" Thread-Topic: [memnic PATCH 2/5] pmd: check frame length from host Thread-Index: Ac887A4SZEQxSY6oRMyIjyHCgdKkEg== Date: Tue, 11 Mar 2014 05:38:12 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD01073AFA@BPXM14GP.gisp.nec.co.jp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Hayato Momma Subject: [dpdk-dev] [memnic PATCH 2/5] pmd: check frame length from host X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Mar 2014 05:41:04 -0000 From: Hiroshi Shimamoto Drop packets which have invalid length. Normally this must not happen while vSwitch works fine, however it's better to put a sentinel to prevent memory corruption. Signed-off-by: Hiroshi Shimamoto Reviewed-by: Hayato Momma --- pmd/pmd_memnic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c index 805f0b2..bf5fc2e 100644 --- a/pmd/pmd_memnic.c +++ b/pmd/pmd_memnic.c @@ -226,6 +226,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue, p =3D &data->packets[idx]; if (p->status !=3D MEMNIC_PKT_ST_FILLED) break; + if (p->len > MEMNIC_MAX_FRAME_LEN) + goto drop; mb =3D rte_pktmbuf_alloc(adapter->mp); if (!mb) break; @@ -238,6 +240,7 @@ static uint16_t memnic_recv_pkts(void *rx_queue, mb->pkt.data_len =3D p->len; rx_pkts[nr] =3D mb; =20 +drop: rte_mb(); p->status =3D MEMNIC_PKT_ST_FREE; =20 --=20 1.8.4