DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Hayato Momma <h-momma@ce.jp.nec.com>
Subject: [dpdk-dev] [memnic PATCH 5/5] pmd: handle multiple segments on xmit
Date: Tue, 11 Mar 2014 05:40:26 +0000	[thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD01073B71@BPXM14GP.gisp.nec.co.jp> (raw)

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

The current MEMNIC PMD cannot handle multiple segments.

Add the functionality to transmit a mbuf which has multiple segments.
Walk every segment in transmitting mbuf and copy the data to MEMNIC
packet buffer.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 pmd/pmd_memnic.c | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index abfd437..4ee655d 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -324,9 +324,11 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
 	pkts = bytes = errs = 0;
 
 	for (nr = 0; nr < nb_pkts; nr++) {
-		int len = rte_pktmbuf_data_len(tx_pkts[nr]);
+		int pkt_len = rte_pktmbuf_pkt_len(tx_pkts[nr]);
+		struct rte_mbuf *sg;
+		void *ptr;
 
-		if (len > MEMNIC_MAX_FRAME_LEN) {
+		if (pkt_len > MEMNIC_MAX_FRAME_LEN) {
 			errs++;
 			break;
 		}
@@ -356,12 +358,19 @@ retry:
 			idx = 0;
 		adapter->down_idx = idx;
 
-		p->len = len;
+		p->len = pkt_len;
 
-		rte_memcpy(p->data, rte_pktmbuf_mtod(tx_pkts[nr], void *), len);
+		ptr = p->data;
+		for (sg = tx_pkts[nr]; sg; sg = sg->pkt.next) {
+			void *src = rte_pktmbuf_mtod(sg, void *);
+			int data_len = sg->pkt.data_len;
+
+			rte_memcpy(ptr, src, data_len);
+			ptr += data_len;
+		}
 
 		pkts++;
-		bytes += len;
+		bytes += pkt_len;
 
 		rte_mb();
 		p->status = MEMNIC_PKT_ST_FILLED;
-- 
1.8.4

             reply	other threads:[~2014-03-11  5:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  5:40 Hiroshi Shimamoto [this message]
2014-03-26 16:48 ` Olivier MATZ
2014-03-27  9:56   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD01073B71@BPXM14GP.gisp.nec.co.jp \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=dev@dpdk.org \
    --cc=h-momma@ce.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).