From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 1/5] pmd: fix race condition
Date: Fri, 28 Mar 2014 09:49:56 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD01093011@BPXM14GP.gisp.nec.co.jp> (raw)
In-Reply-To: <533303E7.8050206@6wind.com>
Hi,
> Subject: Re: [dpdk-dev] [memnic PATCH 1/5] pmd: fix race condition
>
> Hi Hiroshi-san,
>
> Please see my comments below.
>
> On 03/11/2014 06:37 AM, Hiroshi Shimamoto wrote:
> > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >
> > There is a race condition, on transmit to vSwitch.
>
> I think we should not talk specifically about vSwitch, as
> another implementation of host memnic is possible. Maybe using
> the term "host" is more appropriate?
>
> > + if (idx != ACCESS_ONCE(adapter->down_idx)) {
> > + /*
> > + * vSwitch freed this and got false positive,
> > + * need to recover the status and retry.
> > + */
> > + p->status = MEMNIC_PKT_ST_FREE;
> > + goto retry;
> > + }
> > +
>
> The patch indeed looks to improve reliability, even if it's
> difficult to me to be sure that there is no other race condition.
> Again, I would replace "vSwitch" by "host".
okay, I'm fine with that.
Do you want me resubmit update one?
If so, will do next week.
>
> By the way, I guess the Linux code in linux/memnic_net.c should be
> modified in the same way.
Hm, yes, we should check kernel driver too.
thanks,
Hiroshi
>
> Regards,
> Olivier
next prev parent reply other threads:[~2014-03-28 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 5:37 Hiroshi Shimamoto
2014-03-26 16:44 ` Olivier MATZ
2014-03-28 9:49 ` Hiroshi Shimamoto [this message]
2014-03-28 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD01093011@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto@ct.jp.nec.com \
--cc=dev@dpdk.org \
--cc=h-momma@ce.jp.nec.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).