From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52]) by dpdk.org (Postfix) with ESMTP id 66260B0AA for ; Thu, 12 Jun 2014 11:35:49 +0200 (CEST) Received: from mailgate3.nec.co.jp ([10.7.69.193]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s5C9a2GB009380; Thu, 12 Jun 2014 18:36:02 +0900 (JST) Received: from mailsv3.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s5C9a2J15368; Thu, 12 Jun 2014 18:36:02 +0900 (JST) Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s5C9ZlVm001100; Thu, 12 Jun 2014 18:36:02 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.145] [10.38.151.145]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-220396; Thu, 12 Jun 2014 18:35:02 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC17GP.gisp.nec.co.jp ([10.38.151.145]) with mapi id 14.02.0328.011; Thu, 12 Jun 2014 18:35:01 +0900 From: Hiroshi Shimamoto To: "Cao, Waterman" , "dev@dpdk.org" Thread-Topic: [PATCH] kni: compatibility with RHEL 7 Thread-Index: Ac+GFYgZQNUE4XZ9T8WGQjHt6QzWkAACMzxQAACV2wA= Date: Thu, 12 Jun 2014 09:35:01 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD0110EB24@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E674@BPXM14GP.gisp.nec.co.jp> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Hayato Momma Subject: Re: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2014 09:35:50 -0000 Hi, > Subject: RE: [PATCH] kni: compatibility with RHEL 7 >=20 > Hi Shimamoto, >=20 > Can you give details about Linux Kernel version and complier version? > Because we tried to build code in the Redhat 7.0 before, but we don't m= eet this issue. > Please see information as the following: > Linux kernel 3.10.0-54.0.1.el7.x86_64 > RHEL70BETA_64 GCC 4.8.2 ICC: 14.0.0 Yes, Linux REHEL7RC-1 3.10.0-121.el7.x86_64 #1 SMP Tue Apr 8 10:48:19 EDT 2014 x= 86_64 x86_64 x86_64 GNU/Linux gcc version 4.8.2 20140120 (Red Hat 4.8.2-16) (GCC) I got the below error; /path/to/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3851:1: error: c= onflicting types for =1B$B!F=1B(Bskb_set_hash=1B$B!G=1B(B skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) /usr/src/kernels/3.10.0-121.el7.x86_64/include/linux/skbuff.h:762:1: note: = previous definition of =1B$B!F=1B(Bskb_set_hash=1B$B!G=1B(B was here skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type) thanks, Hiroshi >=20 > Thanks >=20 > Waterman >=20 > -----Original Message----- > >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto > >Sent: Thursday, June 12, 2014 4:10 PM > >To: dev@dpdk.org > >Cc: Hayato Momma > >Subject: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 > > > >From: Hiroshi Shimamoto > > > >Compilation in RHEL7 is failed. This fixes the build issue. > > > >RHEL7 has skb_set_hash, the kernel version is 3.10 though. > >Don't define skb_set_hash for RHEL7. > > > >Signed-off-by: Hiroshi Shimamoto > >Reviewed-by: Hayato Momma > >--- > > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > >diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/lib= rte_eal/linuxapp/kni/ethtool/igb/kcompat.h > >index 4c27d5d..b4de6e2 100644 > >--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > >+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > >@@ -3843,6 +3843,9 @@ static inline struct sk_buff *__kc__vlan_hwaccel_p= ut_tag(struct sk_buff *skb, #endif /* >=3D 3.10.0 > */ > > > > #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,14,0) ) > >+ > >+#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D > >+RHEL_RELEASE_VERSION(7,0))) > >+ > > #ifdef NETIF_F_RXHASH > > #define PKT_HASH_TYPE_L3 0 > > static inline void > >@@ -3851,6 +3854,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __al= ways_unused int type) > > skb->rxhash =3D hash; > > } > > #endif /* NETIF_F_RXHASH */ > >+#endif /* < RHEL7 */ > >+ > > #endif /* < 3.14.0 */ > > > > #endif /* _KCOMPAT_H_ */ > >-- > >1.9.1 > >