From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [210.143.35.51]) by dpdk.org (Postfix) with ESMTP id 84FE858DC for ; Mon, 4 Aug 2014 04:46:44 +0200 (CEST) Received: from mailgate3.nec.co.jp ([10.7.69.192]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s742mu7R016797; Mon, 4 Aug 2014 11:48:56 +0900 (JST) Received: from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s742muO23017; Mon, 4 Aug 2014 11:48:56 +0900 (JST) Received: from mail02.kamome.nec.co.jp (mail02.kamome.nec.co.jp [10.25.43.5]) by mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s742mtZo012208; Mon, 4 Aug 2014 11:48:55 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.145] [10.38.151.145]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-1000043; Mon, 4 Aug 2014 11:48:31 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC17GP.gisp.nec.co.jp ([10.38.151.145]) with mapi id 14.02.0328.011; Mon, 4 Aug 2014 11:48:30 +0900 From: Hiroshi Shimamoto To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id Thread-Index: AQHPpP/5HRcYWawLzUK9QPLwaiBbj5usvvzA///1kICAAKcWYP//bcMAgBMG1MA= Date: Mon, 4 Aug 2014 02:48:30 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD011767DF@BPXM14GP.gisp.nec.co.jp> References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> <3356411.EsFcTdggfg@xps13> In-Reply-To: <3356411.EsFcTdggfg@xps13> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2014 02:46:46 -0000 Hi, > Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify ma= ster lcore id >=20 > 2014-07-23 08:53, Hiroshi Shimamoto: > > 2014-07-23 09:50, Thomas Monjalon: > > > 2014-07-22 23:40, Hiroshi Shimamoto: > > > > does anyone have interest in this functionality? > > > > > > > > I think this is important and useful. > > > > Since we should care about core assignment to get high performance > > > > and the master lcore thread is special in DPDK, we will want to > > > > assign the master to the target core. > > > > For example, with hyperthreading I'd like to make a pair of packet > > > > processing threads into one physical core and separate the master > > > > thread which does some management. > > > > > > Thank you for showing your interest. > > > Does it mean you carefully reviewed this patch? In this case, I'd app= reciate > > > a note "Reviewed-by:". > > > > Not yet deeply, wait a bit, we're testing this patch in our application= . > > Will report if it works fine. Sorry a delay, I had confirmed the functionality. I'm fine to add Reviewed-by: Hiroshi Shimamoto thanks, Hiroshi > > > > By the way, we should add the same code into the BSD code, right? >=20 > Right. > I'd prefer to reduce the duplicated footprint and have more common code > between BSD and Linux. But waiting this enhancement, we have to maintain > the duplicated code for BSD. >=20 > -- > Thomas