* [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
@ 2014-09-11 7:47 Hiroshi Shimamoto
2014-09-24 15:13 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Hiroshi Shimamoto @ 2014-09-11 7:47 UTC (permalink / raw)
To: dev; +Cc: Hayato Momma
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index 994ed0a..bbb5380 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -308,8 +308,6 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
mb->pkt.in_port = q->port_id;
- mb->pkt.nb_segs = 1;
- mb->pkt.next = NULL;
mb->pkt.pkt_len = p->len;
mb->pkt.data_len = p->len;
rx_pkts[nr] = mb;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
2014-09-11 7:47 [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment Hiroshi Shimamoto
@ 2014-09-24 15:13 ` Thomas Monjalon
2014-09-24 23:58 ` Hiroshi Shimamoto
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2014-09-24 15:13 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: dev, Hayato Momma
2014-09-11 07:47, Hiroshi Shimamoto:
> Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
Is it increasing the performances?
--
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
2014-09-24 15:13 ` Thomas Monjalon
@ 2014-09-24 23:58 ` Hiroshi Shimamoto
0 siblings, 0 replies; 3+ messages in thread
From: Hiroshi Shimamoto @ 2014-09-24 23:58 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Hayato Momma
> Subject: Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
>
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
>
> Is it increasing the performances?
I hadn't tried to test, because I don't think it can be noticed.
Just clean up, removing a few redundant instructions.
thanks,
Hiroshi
>
> --
> Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-24 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-11 7:47 [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment Hiroshi Shimamoto
2014-09-24 15:13 ` Thomas Monjalon
2014-09-24 23:58 ` Hiroshi Shimamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).