DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
@ 2014-09-11  7:47 Hiroshi Shimamoto
  2014-09-24 15:14 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Hiroshi Shimamoto @ 2014-09-11  7:47 UTC (permalink / raw)
  To: dev; +Cc: Hayato Momma

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Do not touch pktmbuf directly.

Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
to access the property.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 pmd/pmd_memnic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index bbb5380..8341da7 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -308,8 +308,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
 
 		rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
 		mb->pkt.in_port = q->port_id;
-		mb->pkt.pkt_len = p->len;
-		mb->pkt.data_len = p->len;
+		rte_pktmbuf_pkt_len(mb) = p->len;
+		rte_pktmbuf_data_len(mb) = p->len;
 		rx_pkts[nr] = mb;
 
 		pkts++;
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
  2014-09-11  7:47 [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros Hiroshi Shimamoto
@ 2014-09-24 15:14 ` Thomas Monjalon
  2014-09-25  0:01   ` Hiroshi Shimamoto
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2014-09-24 15:14 UTC (permalink / raw)
  To: Hiroshi Shimamoto; +Cc: dev, Hayato Momma

2014-09-11 07:47, Hiroshi Shimamoto:
> Do not touch pktmbuf directly.
> 
> Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> to access the property.

I guess this change is for compatibility with DPDK 1.8.
Does it have an impact on performance?

-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
  2014-09-24 15:14 ` Thomas Monjalon
@ 2014-09-25  0:01   ` Hiroshi Shimamoto
  0 siblings, 0 replies; 3+ messages in thread
From: Hiroshi Shimamoto @ 2014-09-25  0:01 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Hayato Momma

> Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
> 
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Do not touch pktmbuf directly.
> >
> > Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
> > to access the property.
> 
> I guess this change is for compatibility with DPDK 1.8.

Yep, I had the thought need to prepare upcoming code.

> Does it have an impact on performance?

No, it must not.

thanks,
Hiroshi

> 
> --
> Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-24 23:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-11  7:47 [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros Hiroshi Shimamoto
2014-09-24 15:14 ` Thomas Monjalon
2014-09-25  0:01   ` Hiroshi Shimamoto

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git