From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52]) by dpdk.org (Postfix) with ESMTP id 8E5CB5909 for ; Fri, 12 Sep 2014 01:45:27 +0200 (CEST) Received: from mailgate3.nec.co.jp ([10.7.69.192]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8BNoe4F011977; Fri, 12 Sep 2014 08:50:40 +0900 (JST) Received: from mailsv4.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s8BNod302367; Fri, 12 Sep 2014 08:50:39 +0900 (JST) Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8BNodsh027122; Fri, 12 Sep 2014 08:50:39 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.146] [10.38.151.146]) by mail02.kamome.nec.co.jp with ESMTP id BT-MMP-1871157; Fri, 12 Sep 2014 08:47:53 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.238]) by BPXC18GP.gisp.nec.co.jp ([10.38.151.146]) with mapi id 14.02.0328.011; Fri, 12 Sep 2014 08:47:53 +0900 From: Hiroshi Shimamoto To: Bruce Richardson , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/3] eal affinitize low priority threads to lcore 0 Thread-Index: AQHPzcvvI1R9ViDJkEW7FloddkBM3pv8koWg Date: Thu, 11 Sep 2014 23:47:52 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD011AC7A6@BPXM14GP.gisp.nec.co.jp> References: <1410445387-4849-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1410445387-4849-1-git-send-email-bruce.richardson@intel.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] eal affinitize low priority threads to lcore 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Sep 2014 23:45:28 -0000 Hi Bruce, > Subject: [dpdk-dev] [PATCH 0/3] eal affinitize low priority threads to lc= ore 0 >=20 > This patchset sets things up so that we can affinitize the interrupt, > vfio management, and hpet timer management threads to lcore 0, so that > they never interfere with data plane threads. I don't think it works well always. The management threads can be floating all cpus on demand, because those threads are created before the master thread affinity is set. The kernel scheduler will take care of it. And we should isolate cpus which data plane threads are pinned to, so the management threads cannot run on those isolat= ed cpus data plane thread run. In some cases, the user may run data plane thread on lcore 0, but with this patchset the data plane pinned to lcore 0 always run with the management threads. That doesn't seem good. I think this functionality should be conditional. How about to add a parameter to specify the mask for the management threads instead of statically assignment to lcore 0? thanks, Hiroshi >=20 > Bruce Richardson (3): > eal: add core id param to eal_thread_set_affinity > eal: increase scope of eal_thread_set_affinity > eal: affinitize low-priority threads to lcore 0 >=20 > lib/librte_eal/bsdapp/eal/eal_thread.c | 12 ++++++------ > lib/librte_eal/common/include/eal_private.h | 10 ++++++++++ > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +++++ > lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 6 ++++++ > lib/librte_eal/linuxapp/eal/eal_thread.c | 12 ++++++------ > lib/librte_eal/linuxapp/eal/eal_timer.c | 5 +++++ > 6 files changed, 38 insertions(+), 12 deletions(-) >=20 > -- > 1.9.3