From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <h-shimamoto@ct.jp.nec.com>
Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52])
 by dpdk.org (Postfix) with ESMTP id B0A8E1F5
 for <dev@dpdk.org>; Thu, 25 Sep 2014 01:55:24 +0200 (CEST)
Received: from mailgate3.nec.co.jp ([10.7.69.160])
 by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8P01aLd010446;
 Thu, 25 Sep 2014 09:01:36 +0900 (JST)
Received: from mailsv3.nec.co.jp (imss63.nec.co.jp [10.7.69.158]) by
 mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP
 id s8P01a229636; Thu, 25 Sep 2014 09:01:36 +0900 (JST)
Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7])
 by mailsv3.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8P01a1S020321;
 Thu, 25 Sep 2014 09:01:36 +0900 (JST)
Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.144] [10.38.151.144]) by
 mail02.kamome.nec.co.jp with ESMTP id BT-MMP-2098380;
 Thu, 25 Sep 2014 09:01:21 +0900
Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by
 BPXC16GP.gisp.nec.co.jp ([10.38.151.144]) with mapi id 14.03.0174.002; Thu,
 25 Sep 2014 09:01:20 +0900
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
Thread-Index: AQHP2ApVisbzPHO6qUmpJSBKkNhvgpwQ9vJQ
Date: Thu, 25 Sep 2014 00:01:20 +0000
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD02AD9E6D@BPXM14GP.gisp.nec.co.jp>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD011A9915@BPXM14GP.gisp.nec.co.jp>
 <2846511.VthLZyxgb4@xps13>
In-Reply-To: <2846511.VthLZyxgb4@xps13>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.205.5.123]
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Sep 2014 23:55:25 -0000

> Subject: Re: [dpdk-dev] [memnic PATCH 3/7] pmd: use helper macros
>=20
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Do not touch pktmbuf directly.
> >
> > Instead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_dat=
a_len()
> > to access the property.
>=20
> I guess this change is for compatibility with DPDK 1.8.

Yep, I had the thought need to prepare upcoming code.

> Does it have an impact on performance?

No, it must not.

thanks,
Hiroshi

>=20
> --
> Thomas