From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Hayato Momma <h-momma@ce.jp.nec.com>
Subject: [dpdk-dev] [memnic PATCH v2 3/7] pmd: use helper macros
Date: Tue, 30 Sep 2014 11:13:08 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp> (raw)
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Do not touch pktmbuf directly.
Intead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len()
to access the property.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index bbb5380..872f3c4 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -308,8 +308,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
mb->pkt.in_port = q->port_id;
- mb->pkt.pkt_len = p->len;
- mb->pkt.data_len = p->len;
+ rte_pktmbuf_pkt_len(mb) = p->len;
+ rte_pktmbuf_data_len(mb) = p->len;
rx_pkts[nr] = mb;
pkts++;
@@ -394,7 +394,7 @@ retry:
ptr = p->data;
for (sg = tx_pkts[nr]; sg; sg = sg->pkt.next) {
void *src = rte_pktmbuf_mtod(sg, void *);
- int data_len = sg->pkt.data_len;
+ int data_len = rte_pktmbuf_data_len(sg);
rte_memcpy(ptr, src, data_len);
ptr += data_len;
--
1.8.3.1
reply other threads:[~2014-09-30 11:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto@ct.jp.nec.com \
--cc=dev@dpdk.org \
--cc=h-momma@ce.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).