From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Hayato Momma <h-momma@ce.jp.nec.com>
Subject: [dpdk-dev] [memnic PATCH v2 7/7] pmd: burst mbuf freeing in xmit
Date: Tue, 30 Sep 2014 11:15:28 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp> (raw)
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
In rte_pktmbuf_free(), there might be cache miss/memory stall issue.
In small packet case, it could harm the performance.
>From the result of memnic-tester, in less than 1024 frame size the
performance could be improved.
Using Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU.
size | before | after
64 | 5.55Mpps | 5.83Mpps
128 | 5.44Mpps | 5.71Mpps
256 | 5.22Mpps | 5.40Mpps
512 | 4.52Mpps | 4.64Mpps
1024 | 3.73Mpps | 3.68Mpps
1280 | 3.22Mpps | 3.17Mpps
1518 | 2.93Mpps | 2.90Mpps
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index 875d3ea..59ee332 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -344,7 +344,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
struct memnic_adapter *adapter = q->adapter;
struct memnic_data *data = &adapter->nic->down;
struct memnic_packet *p;
- uint16_t nr;
+ uint16_t i, nr;
int idx;
struct rte_eth_stats *st = &adapter->stats[rte_lcore_id()];
uint64_t pkts, bytes, errs;
@@ -408,9 +408,9 @@ retry:
rte_compiler_barrier();
p->status = MEMNIC_PKT_ST_FILLED;
-
- rte_pktmbuf_free(tx_pkts[nr]);
}
+ for (i = 0; i < nr; i++)
+ rte_pktmbuf_free(tx_pkts[i]);
/* stats */
st->opackets += pkts;
--
1.8.3.1
reply other threads:[~2014-09-30 11:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD02AE26EC@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto@ct.jp.nec.com \
--cc=dev@dpdk.org \
--cc=h-momma@ce.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).